Re: [Django] #15321: Models._get_unique_checks() does not return grandparents' unique checks

[Django]

#15321: Models._get_unique_checks() does not return grandparents' unique checks
-------------------------------------+-------------------------------------
Reporter: jku | Owner: sswang
Type: Bug | Status: assigned
Component: Database layer | Version: 1.2
(models, ORM) | Resolution:
Severity: Normal | Triage Stage: Accepted
Keywords: models, unique | Needs documentation: 0
checks | Patch needs improvement: 1
Has patch: 1 | UI/UX: 0
Needs tests: 0 |
Easy pickings: 0 |
-------------------------------------+-------------------------------------
Changes (by lrekucki):

* needs_better_patch: 0 => 1
* ui_ux: => 0
* easy: => 0

--
Ticket URL: <https://code.djangoproject.com/ticket/15321#comment:7>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

[Django]

#15321: Models._get_unique_checks() does not return grandparents' unique checks
-------------------------------------+-------------------------------------

Reporter: jku | Owner: aron45

Type: Bug | Status: assigned
Component: Database layer | Version: 1.2
(models, ORM) |

Severity: Normal | Resolution:
Keywords: models, unique | Triage Stage: Accepted
checks |
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by aron45):

* owner: sswang => aron45

Comment:

opened pull request https://github.com/django/django/pull/3968

--
Ticket URL: <https://code.djangoproject.com/ticket/15321#comment:8>

[Django]

#15321: Models._get_unique_checks() does not return grandparents' unique checks
-------------------------------------+-------------------------------------
Reporter: jku | Owner: aron45

Type: Bug | Status: closed

Component: Database layer | Version: 1.2
(models, ORM) |

Severity: Normal | Resolution: fixed

Keywords: models, unique | Triage Stage: Accepted
checks |
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by aron45):

* status: assigned => closed
* resolution: => fixed

--
Ticket URL: <https://code.djangoproject.com/ticket/15321#comment:9>

[Django]

#15321: Models._get_unique_checks() does not return grandparents' unique checks
-------------------------------------+-------------------------------------
Reporter: jku | Owner: aron45

Type: Bug | Status: new

Component: Database layer | Version: 1.2
(models, ORM) |
Severity: Normal | Resolution:

Keywords: models, unique | Triage Stage: Accepted
checks |
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by jarshwah):

* status: closed => new
* needs_better_patch: 1 => 0
* resolution: fixed =>

Comment:

I presume you didn't mean to close this case off, since you've linked a
pull request.

--
Ticket URL: <https://code.djangoproject.com/ticket/15321#comment:10>

[Django]

#15321: Models._get_unique_checks() does not return grandparents' unique checks
-------------------------------------+-------------------------------------
Reporter: jku | Owner: aron45
Type: Bug | Status: new

Component: Database layer | Version: master

(models, ORM) |
Severity: Normal | Resolution:
Keywords: models, unique | Triage Stage: Accepted
checks |
Has patch: 1 | Needs documentation: 0

Needs tests: 1 | Patch needs improvement: 1

Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by charettes):

* needs_better_patch: 0 => 1

* version: 1.2 => master
* needs_tests: 0 => 1

--
Ticket URL: <https://code.djangoproject.com/ticket/15321#comment:11>

[Django]

#15321: Models._get_unique_checks() does not return grandparents' unique checks
-------------------------------------+-------------------------------------
Reporter: jku | Owner: aron45
Type: Bug | Status: new
Component: Database layer | Version: master
(models, ORM) |
Severity: Normal | Resolution:
Keywords: models, unique | Triage Stage: Accepted
checks |
Has patch: 1 | Needs documentation: 0
Needs tests: 1 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by aron45):

* cc: aron45 (added)

--
Ticket URL: <https://code.djangoproject.com/ticket/15321#comment:12>

[Django]

#15321: Models._get_unique_checks() does not return grandparents' unique checks
-------------------------------------+-------------------------------------
Reporter: jku | Owner: aron45
Type: Bug | Status: new
Component: Database layer | Version: master
(models, ORM) |
Severity: Normal | Resolution:
Keywords: models, unique | Triage Stage: Accepted
checks |
Has patch: 1 | Needs documentation: 0
Needs tests: 1 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by aron45):

I updated the pull request

--
Ticket URL: <https://code.djangoproject.com/ticket/15321#comment:13>

[Django]

#15321: Models._get_unique_checks() does not return grandparents' unique checks
-------------------------------------+-------------------------------------
Reporter: jku | Owner: aron45
Type: Bug | Status: new
Component: Database layer | Version: master
(models, ORM) |
Severity: Normal | Resolution:

Keywords: models, unique | Triage Stage: Ready for
checks | checkin

Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by timgraham):

* needs_better_patch: 1 => 0

* needs_tests: 1 => 0
* stage: Accepted => Ready for checkin

--
Ticket URL: <https://code.djangoproject.com/ticket/15321#comment:14>

[Django]

#15321: Models._get_unique_checks() does not return grandparents' unique checks
-------------------------------------+-------------------------------------
Reporter: jku | Owner: aron45

Type: Bug | Status: closed

Component: Database layer | Version: master
(models, ORM) |

Severity: Normal | Resolution: fixed

Keywords: models, unique | Triage Stage: Ready for
checks | checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Simon Charette <charette.s@…>):

* status: new => closed
* resolution: => fixed

Comment:

In [changeset:"79f27f2b61aeac763ae048416ef8a97c2b639ae8"]:
{{{
#!CommitTicketReference repository=""
revision="79f27f2b61aeac763ae048416ef8a97c2b639ae8"
Fixed #15321 -- Honored ancestors unique checks.

Thanks to Tim for the review.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/15321#comment:15>

[Django]

#15321: Models._get_unique_checks() does not return grandparents' unique checks
-------------------------------------+-------------------------------------
Reporter: jku | Owner: aron45
Type: Bug | Status: closed
Component: Database layer | Version: master
(models, ORM) |
Severity: Normal | Resolution: fixed
Keywords: models, unique | Triage Stage: Ready for
checks | checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Simon Charette <charette.s@…>):

In [changeset:"fc49e736484892eaa516826d93660c7ab53a6c3e"]:
{{{
#!CommitTicketReference repository=""
revision="fc49e736484892eaa516826d93660c7ab53a6c3e"
[1.8.x] Fixed #15321 -- Honored ancestors unique checks.

Thanks to Tim for the review.

Backport of 79f27f2b61aeac763ae048416ef8a97c2b639ae8 from master
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/15321#comment:16>