[Django] #13875: cannot customize admin submit

Django

unread,

Jul 3, 2010, 11:45:22 AM7/3/10

to djang...@holovaty.com, django-...@googlegroups.com

#13875: cannot customize admin submit_row
----------------------------------+-----------------------------------------
Reporter: drul | Owner: nobody
Status: new | Milestone: 1.3
Component: django.contrib.admin | Version: 1.2
Keywords: | Stage: Unreviewed
Has_patch: 0 |
----------------------------------+-----------------------------------------
django submit_row inclusion tag doesn't pass extra_context from
ModelAdmin.(add|change|..)_view to submit_row.html template. Because of
that, i cannot add extra button to submit row (i.e. print invoice). this
tag should pass whole context to the template

--
Ticket URL: <http://code.djangoproject.com/ticket/13875>
Django <http://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,

Jul 3, 2010, 12:00:36 PM7/3/10

to djang...@holovaty.com, django-...@googlegroups.com

#13875: cannot customize admin submit_row

-------------------------------------------+--------------------------------

Reporter: drul | Owner: nobody
Status: new | Milestone: 1.3
Component: django.contrib.admin | Version: 1.2

Resolution: | Keywords:
Stage: Unreviewed | Has_patch: 1
Needs_docs: 0 | Needs_tests: 0
Needs_better_patch: 0 |
-------------------------------------------+--------------------------------
Changes (by drul):

* cc: tomas...@invert-it.pl (added)
* needs_better_patch: => 0
* has_patch: 0 => 1
* needs_tests: => 0
* needs_docs: => 0

--
Ticket URL: <http://code.djangoproject.com/ticket/13875#comment:1>

Django

unread,

Nov 13, 2010, 10:03:19 AM11/13/10

to djang...@holovaty.com, django-...@googlegroups.com

#13875: cannot customize admin submit_row

-------------------------------------------+--------------------------------

Reporter: drul | Owner: nobody
Status: new | Milestone: 1.3
Component: django.contrib.admin | Version: 1.2

Resolution: | Keywords:
Stage: Accepted | Has_patch: 1

Needs_docs: 0 | Needs_tests: 0
Needs_better_patch: 0 |
-------------------------------------------+--------------------------------

Changes (by dmoisset):

* stage: Unreviewed => Accepted

--
Ticket URL: <http://code.djangoproject.com/ticket/13875#comment:2>

Django

unread,

Jan 3, 2011, 6:48:20 PM1/3/11

to djang...@holovaty.com, django-...@googlegroups.com

#13875: cannot customize admin submit_row

-------------------------------------------+--------------------------------

Reporter: drul | Owner: nobody
Status: new | Milestone: 1.3
Component: django.contrib.admin | Version: 1.2

Resolution: | Keywords:
Stage: Accepted | Has_patch: 1
Needs_docs: 0 | Needs_tests: 0
Needs_better_patch: 0 |
-------------------------------------------+--------------------------------

Comment (by ramiro):

See also #11974.

--
Ticket URL: <http://code.djangoproject.com/ticket/13875#comment:3>

Django

unread,

Jan 25, 2011, 10:26:16 PM1/25/11

to djang...@holovaty.com, django-...@googlegroups.com

#13875: cannot customize admin submit_row

-------------------------------------------+--------------------------------

Reporter: drul | Owner: nobody
Status: new | Milestone:

Changes (by julien):

* milestone: 1.3 =>

Comment:

This is technically a new feature and therefore I'm removing the 1.3
milestone since we're in beta stage right now. Passing the whole context
to the template is a good thing, however the general context should not be
modified with the `{% submit_row %}`'s specific variables (as done in
drul's patch). Instead a disposable specific new context should be passed
through (as done in my suggested patch).

--
Ticket URL: <http://code.djangoproject.com/ticket/13875#comment:4>

Django

unread,

Apr 2, 2011, 12:33:03 AM4/2/11

to djang...@holovaty.com, django-...@googlegroups.com

#13875: cannot customize admin submit_row

---------------------------------------+-----------------------------
Reporter: drul | Owner: nobody
Type: New feature | Status: new
Milestone: | Component: contrib.admin
Version: 1.2 | Severity: Normal
Resolution: | Keywords:
Triage Stage: Accepted | Has patch: 1
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 |
---------------------------------------+-----------------------------
Changes (by graham_king):

* type: => New feature
* severity: => Normal

--
Ticket URL: <http://code.djangoproject.com/ticket/13875#comment:5>

Django

unread,

May 5, 2011, 11:26:24 AM5/5/11

to django-...@googlegroups.com

#13875: cannot customize admin submit_row

---------------------------------------+-------------------------------

Patch needs improvement: 0 | Easy pickings: 0
---------------------------------------+-------------------------------
Changes (by andybak):

* cc: andybak (added)
* easy: => 0

--
Ticket URL: <http://code.djangoproject.com/ticket/13875#comment:6>

Django

unread,

May 5, 2011, 2:40:40 PM5/5/11

to django-...@googlegroups.com

Patch needs improvement: 1 | Easy pickings: 0
---------------------------------------+-------------------------------
Changes (by patchhammer):

* needs_better_patch: 0 => 1

Comment:

13875_submit_row_whole_context.diff fails to apply cleanly on to trunk

--
Ticket URL: <http://code.djangoproject.com/ticket/13875#comment:7>
Django <https://code.djangoproject.com/>

Django

unread,

Jun 10, 2011, 9:51:43 AM6/10/11

to django-...@googlegroups.com

#13875: cannot customize admin submit_row
---------------------------------------+-------------------------------

Reporter: drul | Owner: dArignac
Type: New feature | Status: assigned

UI/UX: 1 |
---------------------------------------+-------------------------------
Changes (by dArignac):

* owner: nobody => dArignac
* status: new => assigned

--
Ticket URL: <https://code.djangoproject.com/ticket/13875#comment:9>

Django

unread,

Jun 10, 2011, 9:53:14 AM6/10/11

to django-...@googlegroups.com

#13875: cannot customize admin submit_row
---------------------------------------+-------------------------------
Reporter: drul | Owner: dArignac
Type: New feature | Status: assigned
Milestone: | Component: contrib.admin
Version: 1.2 | Severity: Normal
Resolution: | Keywords:
Triage Stage: Accepted | Has patch: 1
Needs documentation: 0 | Needs tests: 0

Patch needs improvement: 0 | Easy pickings: 0

UI/UX: 1 |
---------------------------------------+-------------------------------
Changes (by dArignac):

* needs_better_patch: 1 => 0

Comment:

fixed patch for current source

--
Ticket URL: <https://code.djangoproject.com/ticket/13875#comment:10>

Django

unread,

Jun 14, 2011, 10:24:00 PM6/14/11

to django-...@googlegroups.com

#13875: cannot customize admin submit_row
---------------------------------------+-------------------------------
Reporter: drul | Owner: dArignac
Type: New feature | Status: assigned
Milestone: | Component: contrib.admin
Version: 1.2 | Severity: Normal
Resolution: | Keywords:
Triage Stage: Accepted | Has patch: 1

Needs documentation: 0 | Needs tests: 1

Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 1 |
---------------------------------------+-------------------------------

Changes (by julien):

* needs_tests: 0 => 1

--
Ticket URL: <https://code.djangoproject.com/ticket/13875#comment:11>

Django

unread,

Jun 27, 2011, 9:22:31 PM6/27/11

to django-...@googlegroups.com

#13875: cannot customize admin submit_row
---------------------------------------+-------------------------------
Reporter: drul | Owner: dArignac
Type: New feature | Status: assigned
Milestone: | Component: contrib.admin
Version: 1.2 | Severity: Normal
Resolution: | Keywords:
Triage Stage: Accepted | Has patch: 1
Needs documentation: 0 | Needs tests: 1
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 1 |
---------------------------------------+-------------------------------

Comment (by benatkin):

Another thing: it would be nice if I could individually override the
button row in a template. In change_form.html there's:

{{{
{% submit_row %}
}}}

If it got changed to something like:

{{{
{% block submit_button_row %}
{% submit_row %}
{% endblock %}
}}}

I could override it individually. In fact, I copied the entire
change_form.html from django/contrib/templates to my own template
directory and made this modification for my project.

--
Ticket URL: <https://code.djangoproject.com/ticket/13875#comment:12>

Django

unread,

Jun 27, 2011, 9:25:01 PM6/27/11

to django-...@googlegroups.com

#13875: cannot customize admin submit_row
---------------------------------------+-------------------------------
Reporter: drul | Owner: dArignac
Type: New feature | Status: assigned
Milestone: | Component: contrib.admin
Version: 1.2 | Severity: Normal
Resolution: | Keywords:
Triage Stage: Accepted | Has patch: 1
Needs documentation: 0 | Needs tests: 1
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 1 |
---------------------------------------+-------------------------------

Changes (by benatkin):

* cc: benatkin (added)

Comment:

I realize I could also override the template tag, but this makes it easier
to modify one change form without having to worry about messing up the
other change forms.

--
Ticket URL: <https://code.djangoproject.com/ticket/13875#comment:13>

Django

unread,

Jun 28, 2011, 9:56:22 PM6/28/11

to django-...@googlegroups.com

#13875: cannot customize admin submit_row
---------------------------------------+-------------------------------
Reporter: drul | Owner: dArignac
Type: New feature | Status: assigned
Milestone: | Component: contrib.admin
Version: 1.2 | Severity: Normal
Resolution: | Keywords:
Triage Stage: Accepted | Has patch: 1
Needs documentation: 0 | Needs tests: 1
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 1 |
---------------------------------------+-------------------------------

Changes (by vasiliyeah):

* cc: vvangelovski@… (added)

--
Ticket URL: <https://code.djangoproject.com/ticket/13875#comment:14>

Django

unread,

Oct 10, 2011, 6:20:00 PM10/10/11

to django-...@googlegroups.com

#13875: cannot customize admin submit_row

-------------------------------+------------------------------------

Reporter: drul | Owner: dArignac
Type: New feature | Status: assigned

-------------------------------+------------------------------------

Comment (by ramiro):

In [16956]:
{{{
#!CommitTicketReference repository="" revision="16956"
Fixed #9460 -- Added template blocks for submit buttons rows in admin app
model add/change views.

This allows for easier customization. Thanks kosmik for report and patch.

Refs #13875.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/13875#comment:15>

Django

unread,

Feb 2, 2016, 10:57:48 AM2/2/16

to django-...@googlegroups.com

#13875: cannot customize admin submit_row
-------------------------------+------------------------------------
Reporter: drul | Owner: dArignac
Type: New feature | Status: assigned
Component: contrib.admin | Version: 1.2
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 1 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------+------------------------------------

Comment (by nemesisdesign):

it is not clear if the patch needs improvements or not.

--
Ticket URL: <https://code.djangoproject.com/ticket/13875#comment:16>

Django

unread,

Feb 3, 2016, 4:10:55 AM2/3/16

to django-...@googlegroups.com

#13875: cannot customize admin submit_row
-------------------------------+------------------------------------
Reporter: drul | Owner: dArignac
Type: New feature | Status: assigned

Component: contrib.admin | Version: master

Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 1 | Patch needs improvement: 1
Easy pickings: 1 | UI/UX: 1
-------------------------------+------------------------------------
Changes (by nemesisdesign):

[Django] #13875: cannot customize admin submit_row

Django

Django

Django

Django

Django

Django

Django

Django

Django

Django

Django

Django

Django

Django

Django

Django

Django