[Django] #21152: Small grammatical error in comment
Django
----------------------------------------------+---------------------
Reporter: office.nightcrawler@… | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: Database layer (models, ORM) | Version: master
Severity: Normal | Keywords: grammar
Triage Stage: Unreviewed | Has patch: 1
Easy pickings: 1 | UI/UX: 0
----------------------------------------------+---------------------
There's a small grammatical error in one of the comments in
django.db.models.sql.subqueries.delete_qs at line 65
https://github.com/django/django/blob/master/django/db/models/sql/subqueries.py#L65
'there are no filtering' should be changed to 'there is no filtering'.
Created pull request on github https://github.com/django/django/pull/1675.
--
Ticket URL: <https://code.djangoproject.com/ticket/21152>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
Reporter: office.nightcrawler@… | Owner: nobody
Type: Cleanup/optimization | Status: closed
Component: Database layer (models, ORM) | Version: master
Keywords: grammar | Triage Stage: Unreviewed
Has patch: 1 | Easy pickings: 1
UI/UX: 0 |
Changes (by Preston Holmes <preston@…>):
* status: new => closed
* resolution: => fixed
Comment:
In [changeset:"fd8d7db4d7f5329fc2e2b348fc60ed6e81d47b13"]:
{{{
#!CommitTicketReference repository=""
revision="fd8d7db4d7f5329fc2e2b348fc60ed6e81d47b13"
Merge pull request #1675 from NiGhTTraX/typoFix
Fixed #21152: Corrected small grammatical error in comment.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/21152#comment:1>
Django
Reporter: | Owner: nobody
office.nightcrawler@… | Status: closed
Type: | Version: master
Cleanup/optimization | Resolution: fixed
Component: Database layer | Triage Stage:
(models, ORM) | Unreviewed
Severity: Normal | Needs documentation: 0
Keywords: grammar | Patch needs improvement: 0
Has patch: 1 | UI/UX: 0
Needs tests: 0 |
Easy pickings: 1 |
-------------------------------------+-------------------------------------
Changes (by ptone):
* needs_better_patch: => 0
* needs_tests: => 0
* needs_docs: => 0
Comment:
Thanks for the catch. For future reference, small fixes like these don't
require a ticket here in trac.
--
Ticket URL: <https://code.djangoproject.com/ticket/21152#comment:2>
Django
Reporter: | Owner: nobody
office.nightcrawler@… | Status: closed
Type: | Version: master
Cleanup/optimization | Resolution: fixed
Component: Database layer | Triage Stage:
(models, ORM) | Unreviewed
Severity: Normal | Needs documentation: 0
Keywords: grammar | Patch needs improvement: 0
Has patch: 1 | UI/UX: 0
Needs tests: 0 |
Easy pickings: 1 |
-------------------------------------+-------------------------------------
Comment (by NiGhTTraX):
Replying to [comment:2 ptone]:
> Thanks for the catch. For future reference, small fixes like these don't
require a ticket here in trac.
Glad to help and thanks for the info. I only created a ticket for it
because I've read the Django contrib docs on github saying that any pull
request would be ignored without a ticket here.
--
Ticket URL: <https://code.djangoproject.com/ticket/21152#comment:3>