Re: [Django] #34119: ModelForm fields with callable defaults don't correctly propagate default values

9 views
Skip to first unread message

Django

unread,
Oct 27, 2022, 3:49:25 AM10/27/22
to django-...@googlegroups.com
#34119: ModelForm fields with callable defaults don't correctly propagate default
values
---------------------------------+-----------------------------------------
Reporter: Benjamin Rigaud | Owner: David Sanders
Type: Bug | Status: assigned
Component: Forms | Version: 4.1
Severity: Normal | Resolution:
Keywords: modelform | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
---------------------------------+-----------------------------------------
Changes (by Mariusz Felisiak):

* stage: Ready for checkin => Accepted


Comment:

You shouldn't mark your own PRs as ''"Ready for Checkin"''.

--
Ticket URL: <https://code.djangoproject.com/ticket/34119#comment:7>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Nov 2, 2022, 6:13:39 AM11/2/22
to django-...@googlegroups.com
#34119: ModelForm fields with callable defaults don't correctly propagate default
values
---------------------------------+-----------------------------------------
Reporter: Benjamin Rigaud | Owner: David Sanders
Type: Bug | Status: assigned
Component: Forms | Version: 4.1
Severity: Normal | Resolution:
Keywords: modelform | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
---------------------------------+-----------------------------------------

Comment (by Mariusz Felisiak):

#33871 was a duplicate for `JSONField`.

--
Ticket URL: <https://code.djangoproject.com/ticket/34119#comment:8>

Django

unread,
Nov 17, 2022, 6:43:07 AM11/17/22
to django-...@googlegroups.com
#34119: ModelForm fields with callable defaults don't correctly propagate default
values
-------------------------------------+-------------------------------------

Reporter: Benjamin Rigaud | Owner: David
| Sanders
Type: Bug | Status: assigned
Component: Forms | Version: 4.1
Severity: Normal | Resolution:
Keywords: modelform | Triage Stage: Ready for
| checkin

Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Carlton Gibson):

* stage: Accepted => Ready for checkin


--
Ticket URL: <https://code.djangoproject.com/ticket/34119#comment:9>

Django

unread,
Nov 18, 2022, 8:35:49 AM11/18/22
to django-...@googlegroups.com
#34119: ModelForm fields with callable defaults don't correctly propagate default
values
-------------------------------------+-------------------------------------
Reporter: Benjamin Rigaud | Owner: David
| Sanders
Type: Bug | Status: closed
Component: Forms | Version: 4.1
Severity: Normal | Resolution: fixed

Keywords: modelform | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak <felisiak.mariusz@…>):

* status: assigned => closed
* resolution: => fixed


Comment:

In [changeset:"25904db9154c5be3ecda9585d96f536841af9126" 25904db9]:
{{{
#!CommitTicketReference repository=""
revision="25904db9154c5be3ecda9585d96f536841af9126"
Fixed #34119 -- Prevented callable default hidden widget value from being
overridden.

Thanks to Benjamin Rigaud for the report.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/34119#comment:10>

Django

unread,
Nov 28, 2022, 3:48:25 AM11/28/22
to django-...@googlegroups.com
#34119: ModelForm fields with callable defaults don't correctly propagate default
values
-------------------------------------+-------------------------------------
Reporter: Benjamin Rigaud | Owner: David
| Sanders
Type: Bug | Status: closed
Component: Forms | Version: 4.1
Severity: Normal | Resolution: fixed
Keywords: modelform | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by GitHub <noreply@…>):

In [changeset:"60a7bd89860e504c0c33b02c78edcac87f6d1b5a" 60a7bd8]:
{{{
#!CommitTicketReference repository=""
revision="60a7bd89860e504c0c33b02c78edcac87f6d1b5a"
Refs #34119 -- Skipped
test_callable_default_hidden_widget_value_not_overridden when JSONField is
not supported.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/34119#comment:11>

Reply all
Reply to author
Forward
0 new messages