[Django] #34315: Close button read only changeview of admin does not preserve filters
Django
-----------------------------------------+------------------------
Reporter: Jan Hošek | Owner: nobody
Type: Bug | Status: new
Component: contrib.admin | Version: 4.1
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
-----------------------------------------+------------------------
Save and Delete buttons in change view of admin send you back to list view
with preserved filters. In some cases (for example user does not have
change permission) there is Close button instead of save buttons.
Suggested change to make the behavior of Close button consistent with Save
is in template:
contrib/admin/templates/admin/submit_line.html
{{{
{% if show_close %}
{% url opts|admin_urlname:'changelist' as close_url %}
<a href="{% add_preserved_filters close_url %}" class="closelink">{%
translate 'Close' %}</a>
{% endif %}
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/34315>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
Reporter: Jan Hošek | Owner: Rahmat Faisal
Type: Bug | Status: assigned
Component: contrib.admin | Version: 4.1
Severity: Normal | Resolution:
Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Rahmat Faisal):
* owner: nobody => Rahmat Faisal
* status: new => assigned
--
Ticket URL: <https://code.djangoproject.com/ticket/34315#comment:1>
Django
-------------------------------+-----------------------------------------
Reporter: Jan Hošek | Owner: Rahmat Faisal
Type: Bug | Status: assigned
Component: contrib.admin | Version: 4.1
Severity: Normal | Resolution:
Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------+-----------------------------------------
Comment (by Rahmat Faisal):
gonna look
--
Ticket URL: <https://code.djangoproject.com/ticket/34315#comment:2>
Django
-------------------------------+-----------------------------------------
Reporter: Jan Hošek | Owner: Rahmat Faisal
Type: Bug | Status: assigned
Component: contrib.admin | Version: 4.1
Severity: Normal | Resolution:
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------+-----------------------------------------
* stage: Unreviewed => Accepted
Comment:
Thanks for the report.
--
Ticket URL: <https://code.djangoproject.com/ticket/34315#comment:3>
Django
-------------------------------+-----------------------------------------
Reporter: Jan Hošek | Owner: Rahmat Faisal
Type: Bug | Status: assigned
Component: contrib.admin | Version: 4.1
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------+-----------------------------------------
Comment (by Bakdolot):
[https://github.com/django/django/pull/16531 PR]
--
Ticket URL: <https://code.djangoproject.com/ticket/34315#comment:4>
Django
-------------------------------+-----------------------------------------
Reporter: Jan Hošek | Owner: Rahmat Faisal
Type: Bug | Status: assigned
Component: contrib.admin | Version: 4.1
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 1 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------+-----------------------------------------
* has_patch: 0 => 1
* needs_tests: 0 => 1
--
Ticket URL: <https://code.djangoproject.com/ticket/34315#comment:5>
Django
Reporter: Jan Hošek | Owner: Rahmat
| Faisal
Type: Bug | Status: assigned
Component: contrib.admin | Version: 4.1
Severity: Normal | Resolution:
| checkin
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Mariusz Felisiak):
* needs_tests: 1 => 0
* stage: Accepted => Ready for checkin
--
Ticket URL: <https://code.djangoproject.com/ticket/34315#comment:6>
Django
-------------------------------------+-------------------------------------
Reporter: Jan Hošek | Owner: Rahmat
| Faisal
Component: contrib.admin | Version: 4.1
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* status: assigned => closed
* resolution: => fixed
Comment:
In [changeset:"325c44ac6c070465ef2b3b7b8ed06cbcb88a3f10" 325c44a]:
{{{
#!CommitTicketReference repository=""
revision="325c44ac6c070465ef2b3b7b8ed06cbcb88a3f10"
Fixed #34315 -- Preserved admin changelist filters on "Close" button.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/34315#comment:7>
Django
-------------------------------------+-------------------------------------
Reporter: Jan Hošek | Owner: Rahmat
| Faisal
Type: Bug | Status: closed
Component: contrib.admin | Version: 4.1
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Mariusz Felisiak <felisiak.mariusz@…>):
In [changeset:"1f193f7f56d0f83c188dca8b03266fbaa339d0f5" 1f193f7]:
{{{
#!CommitTicketReference repository=""
revision="1f193f7f56d0f83c188dca8b03266fbaa339d0f5"
[4.2.x] Fixed #34315 -- Preserved admin changelist filters on "Close"
button.
Backport of 325c44ac6c070465ef2b3b7b8ed06cbcb88a3f10 from main
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/34315#comment:8>