[Django] #28433: comparing GEOSGeometry with non-canonical WKT string return False

4 views
Skip to first unread message

Django

unread,
Jul 25, 2017, 3:49:41 AM7/25/17
to django-...@googlegroups.com
#28433: comparing GEOSGeometry with non-canonical WKT string return False
-------------------------------------------+------------------------
Reporter: Sergey Fedoseev | Owner: nobody
Type: Bug | Status: new
Component: GIS | Version: 1.11
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
-------------------------------------------+------------------------
{{{
In [2]: from django.contrib.gis.geos import GEOSGeometry

In [3]: GEOSGeometry('POINT (0 0)') == 'POINT (0 0)'
Out[3]: True

In [4]: GEOSGeometry('POINT (0 0)') == GEOSGeometry('POINT (0.0 0.0)')
Out[4]: True

In [5]: GEOSGeometry('POINT (0 0)') == 'POINT (0.0 0.0)'
Out[5]: False
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/28433>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Jul 25, 2017, 3:49:46 AM7/25/17
to django-...@googlegroups.com
#28433: comparing GEOSGeometry with non-canonical WKT string return False
-------------------------------------+-------------------------------------
Reporter: Sergey Fedoseev | Owner: Sergey
| Fedoseev
Type: Bug | Status: assigned
Component: GIS | Version: 1.11
Severity: Normal | Resolution:

Keywords: | Triage Stage:
| Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Sergey Fedoseev):

* status: new => assigned
* owner: nobody => Sergey Fedoseev


--
Ticket URL: <https://code.djangoproject.com/ticket/28433#comment:1>

Django

unread,
Jul 25, 2017, 5:15:46 AM7/25/17
to django-...@googlegroups.com
#28433: comparing GEOSGeometry with non-canonical WKT string return False
-------------------------------------+-------------------------------------
Reporter: Sergey Fedoseev | Owner: Sergey
| Fedoseev
Type: Bug | Status: assigned
Component: GIS | Version: 1.11
Severity: Normal | Resolution:

Keywords: | Triage Stage:
| Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Sergey Fedoseev):

[https://github.com/django/django/pull/8808 PR]

--
Ticket URL: <https://code.djangoproject.com/ticket/28433#comment:2>

Django

unread,
Jul 25, 2017, 5:15:53 AM7/25/17
to django-...@googlegroups.com
#28433: comparing GEOSGeometry with non-canonical WKT string return False
-------------------------------------+-------------------------------------
Reporter: Sergey Fedoseev | Owner: Sergey
| Fedoseev
Type: Bug | Status: assigned
Component: GIS | Version: 1.11
Severity: Normal | Resolution:
Keywords: | Triage Stage:
| Unreviewed
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Sergey Fedoseev):

* has_patch: 0 => 1


--
Ticket URL: <https://code.djangoproject.com/ticket/28433#comment:3>

Django

unread,
Jul 25, 2017, 6:59:03 PM7/25/17
to django-...@googlegroups.com
#28433: comparing GEOSGeometry with non-canonical WKT string return False
-------------------------------------+-------------------------------------
Reporter: Sergey Fedoseev | Owner: Sergey
| Fedoseev
Type: Bug | Status: assigned
Component: GIS | Version: 1.11
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1

Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Tim Graham):

* needs_better_patch: 0 => 1
* stage: Unreviewed => Accepted


--
Ticket URL: <https://code.djangoproject.com/ticket/28433#comment:4>

Django

unread,
Jul 26, 2017, 3:41:42 AM7/26/17
to django-...@googlegroups.com
#28433: comparing GEOSGeometry with non-canonical WKT string return False
-------------------------------------+-------------------------------------
Reporter: Sergey Fedoseev | Owner: Sergey
| Fedoseev
Type: Bug | Status: assigned
Component: GIS | Version: 1.11

Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Sergey Fedoseev):

* needs_better_patch: 1 => 0


--
Ticket URL: <https://code.djangoproject.com/ticket/28433#comment:5>

Django

unread,
Jul 26, 2017, 10:04:36 AM7/26/17
to django-...@googlegroups.com
#28433: comparing GEOSGeometry with non-canonical WKT string return False
-------------------------------------+-------------------------------------
Reporter: Sergey Fedoseev | Owner: Sergey
| Fedoseev
Type: Bug | Status: closed
Component: GIS | Version: 1.11
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Tim Graham <timograham@…>):

* status: assigned => closed
* resolution: => fixed


Comment:

In [changeset:"5ccbcc5bf61c746a1d5ec2b3d2e0dc56c1a63fe0" 5ccbcc5b]:
{{{
#!CommitTicketReference repository=""
revision="5ccbcc5bf61c746a1d5ec2b3d2e0dc56c1a63fe0"
Fixed #28433 -- Made GEOSGeometry.__eq__() work correctly with non-
canonical EWKT string.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/28433#comment:6>

Reply all
Reply to author
Forward
0 new messages