* cc: dbrgn (added)
--
Ticket URL: <https://code.djangoproject.com/ticket/12090#comment:15>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
* owner: => jgmize
* status: new => assigned
Comment:
submitted pull request: https://github.com/django/django/pull/928
--
Ticket URL: <https://code.djangoproject.com/ticket/12090#comment:16>
* cc: jgmize (added)
--
Ticket URL: <https://code.djangoproject.com/ticket/12090#comment:17>
* cc: apollo13 (added)
Comment:
@jgmize I can't comment about the design but I'd like to propose some
changes: It would be nice if one where able to reuse the existing actions,
this would mean supporting `short_description` and
`short_description_plural` and using the correct version depending on the
page (+some backwards shim). Also it would be interesting to see how your
current stuff looks with `save_on_top = True`
--
Ticket URL: <https://code.djangoproject.com/ticket/12090#comment:18>
* needs_better_patch: 0 => 1
--
Ticket URL: <https://code.djangoproject.com/ticket/12090#comment:19>
* has_patch: 0 => 1
Comment:
A very old patch, but a start nonetheless in
f62d6e44dda5f457d8108fbae005e026b82e138e in the PR linked above.
--
Ticket URL: <https://code.djangoproject.com/ticket/12090#comment:20>
* owner: jgmize => (none)
* status: assigned => new
--
Ticket URL: <https://code.djangoproject.com/ticket/12090#comment:21>
* owner: (none) => Marcelo Galigniana
* needs_better_patch: 1 => 0
* has_patch: 1 => 0
* status: new => assigned
--
Ticket URL: <https://code.djangoproject.com/ticket/12090#comment:22>
* has_patch: 0 => 1
--
Ticket URL: <https://code.djangoproject.com/ticket/12090#comment:23>
Comment (by Marcelo Galigniana):
[https://github.com/django/django/pull/16012 PR]
--
Ticket URL: <https://code.djangoproject.com/ticket/12090#comment:24>
* needs_better_patch: 0 => 1
Comment:
Going to change actions buttons -> dropdown with actions (same as list)
--
Ticket URL: <https://code.djangoproject.com/ticket/12090#comment:25>
Comment (by Marcelo Galigniana):
I'm leaving a message here to let you know that I'm still active and
contributing but I don't have enough time to dedicate to this big ticket
yet.
If someone has the time to work in it feel free to claim it! If not ->
I'll be working on it later for sure, but I don't know exactly when.
Thank you!
--
Ticket URL: <https://code.djangoproject.com/ticket/12090#comment:26>
Comment (by Marcelo Galigniana):
Update: I've started to working again! Pull request in draft, with test
passing, but there is documentation and other changes to do!
--
Ticket URL: <https://code.djangoproject.com/ticket/12090#comment:27>
* cc: Danilo Bargen (removed)
--
Ticket URL: <https://code.djangoproject.com/ticket/12090#comment:28>
* needs_better_patch: 1 => 0
* ui_ux: 1 => 0
--
Ticket URL: <https://code.djangoproject.com/ticket/12090#comment:29>
* needs_better_patch: 0 => 1
* ui_ux: 0 => 1
--
Ticket URL: <https://code.djangoproject.com/ticket/12090#comment:30>
* needs_better_patch: 1 => 0
* ui_ux: 1 => 0
--
Ticket URL: <https://code.djangoproject.com/ticket/12090#comment:31>
* needs_better_patch: 0 => 1
Comment:
Test failing!
Working on fix.
--
Ticket URL: <https://code.djangoproject.com/ticket/12090#comment:32>
* needs_better_patch: 1 => 0
Comment:
Tests passing
--
Ticket URL: <https://code.djangoproject.com/ticket/12090#comment:33>