Re: [Django] #36594: Clarify UniqueConstraint's nulls_distinct system check warning

[Django]

#36594: Clarify UniqueConstraint's nulls_distinct system check warning
-------------------------------------+-------------------------------------
Reporter: Russell Owen | Owner: Mridul
Type: | Status: assigned
Cleanup/optimization |
Component: Database layer | Version: 5.2
(models, ORM) |
Severity: Normal | Resolution:
Keywords: UniqueConstraint | Triage Stage: Accepted
nulls_distinct |
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Mridul):

* owner: (none) => Mridul
* status: new => assigned

--
Ticket URL: <https://code.djangoproject.com/ticket/36594#comment:3>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

[Django]

#36594: Clarify UniqueConstraint's nulls_distinct system check warning
-------------------------------------+-------------------------------------
Reporter: Russell Owen | Owner: Mridul
Type: | Status: assigned
Cleanup/optimization |
Component: Database layer | Version: 5.2
(models, ORM) |
Severity: Normal | Resolution:
Keywords: UniqueConstraint | Triage Stage: Accepted
nulls_distinct |
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Samriddha Kumar Tripathi):

I’ve opened a pull request for this:
https://github.com/django/django/pull/19839
--
Ticket URL: <https://code.djangoproject.com/ticket/36594#comment:4>

[Django]

#36594: Clarify UniqueConstraint's nulls_distinct system check warning
-------------------------------------+-------------------------------------
Reporter: Russell Owen | Owner: Mridul
Type: | Status: assigned
Cleanup/optimization |
Component: Database layer | Version: 5.2
(models, ORM) |
Severity: Normal | Resolution:
Keywords: UniqueConstraint | Triage Stage: Accepted
nulls_distinct |

Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Samriddha Kumar Tripathi):

* has_patch: 0 => 1

--
Ticket URL: <https://code.djangoproject.com/ticket/36594#comment:5>

[Django]

#36594: Clarify UniqueConstraint's nulls_distinct system check warning
-------------------------------------+-------------------------------------
Reporter: Russell Owen | Owner: Mridul
Type: | Status: assigned
Cleanup/optimization |
Component: Database layer | Version: 5.2
(models, ORM) |
Severity: Normal | Resolution:
Keywords: UniqueConstraint | Triage Stage: Accepted
nulls_distinct |

Has patch: 0 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Mridul):

* has_patch: 1 => 0

Comment:

Hi Samriddha,
I just noticed that you submitted a PR for this ticket, which I had
already assigned to myself and have been working on.

Also, the PR doesn’t include the required documentation changes noted in
the ticket. I request you to hold off on further work and let me finish it
from here
--
Ticket URL: <https://code.djangoproject.com/ticket/36594#comment:6>

[Django]

#36594: Clarify UniqueConstraint's nulls_distinct system check warning
-------------------------------------+-------------------------------------
Reporter: Russell Owen | Owner: Mridul
Type: | Status: assigned
Cleanup/optimization |
Component: Database layer | Version: 5.2
(models, ORM) |
Severity: Normal | Resolution:
Keywords: UniqueConstraint | Triage Stage: Accepted
nulls_distinct |
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Mridul):

Will have a PR ready before the end of this week
--
Ticket URL: <https://code.djangoproject.com/ticket/36594#comment:7>

[Django]

#36594: Clarify UniqueConstraint's nulls_distinct system check warning
-------------------------------------+-------------------------------------
Reporter: Russell Owen | Owner: Mridul
Type: | Status: assigned
Cleanup/optimization |
Component: Database layer | Version: 5.2
(models, ORM) |
Severity: Normal | Resolution:
Keywords: UniqueConstraint | Triage Stage: Accepted
nulls_distinct |

Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Mridul):

* has_patch: 0 => 1

Comment:

PR: [https://github.com/django/django/pull/19870]
--
Ticket URL: <https://code.djangoproject.com/ticket/36594#comment:8>

[Django]

#36594: Clarify UniqueConstraint's nulls_distinct system check warning
-------------------------------------+-------------------------------------
Reporter: Russell Owen | Owner: Mridul
Type: | Status: assigned
Cleanup/optimization |
Component: Database layer | Version: 5.2
(models, ORM) |
Severity: Normal | Resolution:
Keywords: UniqueConstraint | Triage Stage: Accepted
nulls_distinct |
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 1

Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Sarah Boyce):

* needs_better_patch: 0 => 1

--
Ticket URL: <https://code.djangoproject.com/ticket/36594#comment:9>

[Django]

#36594: Clarify UniqueConstraint's nulls_distinct system check warning
-------------------------------------+-------------------------------------
Reporter: Russell Owen | Owner: Mridul
Type: | Status: assigned
Cleanup/optimization |
Component: Database layer | Version: 5.2
(models, ORM) |
Severity: Normal | Resolution:
Keywords: UniqueConstraint | Triage Stage: Accepted
nulls_distinct |
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Mridul):

* needs_better_patch: 1 => 0

--
Ticket URL: <https://code.djangoproject.com/ticket/36594#comment:10>

[Django]

#36594: Clarify UniqueConstraint's nulls_distinct system check warning
-------------------------------------+-------------------------------------
Reporter: Russell Owen | Owner: Mridul
Type: | Status: assigned
Cleanup/optimization |
Component: Database layer | Version: 5.2
(models, ORM) |
Severity: Normal | Resolution:

Keywords: UniqueConstraint | Triage Stage: Ready for
nulls_distinct | checkin

Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Jacob Walls):

* stage: Accepted => Ready for checkin

--
Ticket URL: <https://code.djangoproject.com/ticket/36594#comment:11>

[Django]

#36594: Clarify UniqueConstraint's nulls_distinct system check warning
-------------------------------------+-------------------------------------
Reporter: Russell Owen | Owner: Mridul

Type: | Status: closed

Cleanup/optimization |
Component: Database layer | Version: 5.2
(models, ORM) |

Severity: Normal | Resolution: fixed

Keywords: UniqueConstraint | Triage Stage: Ready for
nulls_distinct | checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Jacob Walls <jacobtylerwalls@…>):

* resolution: => fixed
* status: assigned => closed

Comment:

In [changeset:"d1a4979fa55071581411b7d62eb1ee20f2380ae3" d1a4979]:
{{{#!CommitTicketReference repository=""
revision="d1a4979fa55071581411b7d62eb1ee20f2380ae3"
Fixed #36594 -- Improved UniqueConstraint's nulls_distinct system check
message.

Clarified that the nulls_distinct argument is not supported, as opposed
to certain values for the argument.

Thanks Russell Owen for the report.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/36594#comment:12>