[Django] #24737: Unnecesary kwarg passed in UserManager's _create_user
Django
----------------------------------------------+--------------------
Reporter: delgiudices | Owner: nobody
Type: Uncategorized | Status: new
Component: Database layer (models, ORM) | Version: 1.8
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Easy pickings: 0 | UI/UX: 0
----------------------------------------------+--------------------
From {{{django/contrib/auth/models.py}}}
{{{
user = self.model(username=username, email=email,
is_staff=is_staff, is_active=True,
is_superuser=is_superuser,
date_joined=now, **extra_fields)
}}}
date_joined is being specified but in the model declaration ( line 406 )
date_joined is set to now by default.
{{{406: date_joined = models.DateTimeField(_('date joined'),
default=timezone.now }}}
I've removed the date_joined kwarg and all tests were ok. I've pushed what
i think is the solution here:
[https://github.com/delgiudices/django/blob/test_user/django/contrib/auth/models.py#L178]
--
Ticket URL: <https://code.djangoproject.com/ticket/24737>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
Reporter: delgiudices | Owner:
| delgiudices
Type: Uncategorized | Status: assigned
Component: Database layer | Version: 1.8
(models, ORM) |
Severity: Normal | Resolution:
Keywords: | Triage Stage:
| Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by delgiudices):
* status: new => assigned
* needs_docs: => 0
* owner: nobody => delgiudices
* needs_tests: => 0
* needs_better_patch: => 0
--
Ticket URL: <https://code.djangoproject.com/ticket/24737#comment:1>
Django
Reporter: delgiudices | Owner:
Type: | delgiudices
Cleanup/optimization | Status: assigned
Component: contrib.auth | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Changes (by MarkusH):
* type: Uncategorized => Cleanup/optimization
* version: 1.8 => master
* component: Database layer (models, ORM) => contrib.auth
* stage: Unreviewed => Accepted
--
Ticket URL: <https://code.djangoproject.com/ticket/24737#comment:2>
Django
Reporter: delgiudices | Owner:
Type: | delgiudices
Cleanup/optimization | Status: assigned
Component: contrib.auth | Version: master
Severity: Normal | Resolution:
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by timgraham):
* has_patch: 0 => 1
* stage: Accepted => Ready for checkin
--
Ticket URL: <https://code.djangoproject.com/ticket/24737#comment:3>
Django
Reporter: delgiudices | Owner:
Type: | delgiudices
Component: contrib.auth | Version: master
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Tim Graham <timograham@…>):
* status: assigned => closed
* resolution: => fixed
Comment:
In [changeset:"db0a0c4b8ae490d0596f2c210d3edba3d700374a" db0a0c4]:
{{{
#!CommitTicketReference repository=""
revision="db0a0c4b8ae490d0596f2c210d3edba3d700374a"
Fixed #24737 -- Removed unnecesary kwargs in UserManager._create_user()
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/24737#comment:4>