[Django] #25123: Incorrect makemessage command help text

14 views
Skip to first unread message

Django

unread,
Jul 14, 2015, 5:20:58 AM7/14/15
to django-...@googlegroups.com
#25123: Incorrect makemessage command help text
--------------------------------------------+--------------------
Reporter: canassa | Owner: nobody
Type: Uncategorized | Status: new
Component: Core (Management commands) | Version: 1.8
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Easy pickings: 0 | UI/UX: 0
--------------------------------------------+--------------------
The help text from the makemessage commands says this about --extensions
flag:

{{{
The file extension(s) to examine (default: "html,txt",
or "js" if the domain is "djangojs"). Separate
multiple extensions with commas, or use -e multiple
times.
}}}

But the default file extensions is "html,txt,py" and not "html,txt". Not
listing the "py" extension might imply that this extension and always set
and that user don't need to specify it in case he/she decides to override
it.

--
Ticket URL: <https://code.djangoproject.com/ticket/25123>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Jul 14, 2015, 5:27:27 AM7/14/15
to django-...@googlegroups.com
#25123: Incorrect makemessage command help text
-------------------------------------+-------------------------------------

Reporter: canassa | Owner: nobody
Type: Uncategorized | Status: new
Component: Core (Management | Version: 1.8
commands) |
Severity: Normal | Resolution:
Keywords: | Triage Stage:
| Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by canassa):

* needs_better_patch: => 0
* needs_tests: => 0
* needs_docs: => 0


Old description:

> The help text from the makemessage commands says this about --extensions
> flag:
>
> {{{
> The file extension(s) to examine (default: "html,txt",
> or "js" if the domain is "djangojs"). Separate
> multiple extensions with commas, or use -e multiple
> times.
> }}}
>
> But the default file extensions is "html,txt,py" and not "html,txt". Not
> listing the "py" extension might imply that this extension and always set
> and that user don't need to specify it in case he/she decides to override
> it.

New description:

The help text from the makemessage commands says this about --extensions
flag:

{{{
The file extension(s) to examine (default: "html,txt",
or "js" if the domain is "djangojs"). Separate
multiple extensions with commas, or use -e multiple
times.
}}}

But the default file extensions is "html,txt,py" and not "html,txt". Not

listing the "py" extension might imply that this extension is always set
and that user don't need to specify it in case he/she decides to add
another extension.

--

--
Ticket URL: <https://code.djangoproject.com/ticket/25123#comment:1>

Django

unread,
Jul 14, 2015, 5:36:31 AM7/14/15
to django-...@googlegroups.com
#25123: Incorrect makemessage command help text
-------------------------------------+-------------------------------------

Reporter: canassa | Owner: nobody
Type: Uncategorized | Status: new
Component: Core (Management | Version: 1.8
commands) |
Severity: Normal | Resolution:
Keywords: | Triage Stage:
| Unreviewed

Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Description changed by canassa:

Old description:

> The help text from the makemessage commands says this about --extensions
> flag:
>
> {{{
> The file extension(s) to examine (default: "html,txt",
> or "js" if the domain is "djangojs"). Separate
> multiple extensions with commas, or use -e multiple
> times.
> }}}
>
> But the default file extensions is "html,txt,py" and not "html,txt". Not

> listing the "py" extension might imply that this extension is always set
> and that user don't need to specify it in case he/she decides to add
> another extension.

New description:

The help text from the makemessage commands says this about --extensions
flag:

{{{
The file extension(s) to examine (default: "html,txt",
or "js" if the domain is "djangojs"). Separate
multiple extensions with commas, or use -e multiple
times.
}}}

But the default file extensions is "html,txt,py" and not "html,txt". Not

listing the "py" extension might imply that this extension is always set
and that user don't need to specify it in case he/she decides to add
another extension.

https://github.com/django/django/pull/4996

--

--
Ticket URL: <https://code.djangoproject.com/ticket/25123#comment:2>

Django

unread,
Jul 14, 2015, 7:34:10 AM7/14/15
to django-...@googlegroups.com
#25123: Incorrect makemessage command help text
-------------------------------------+-------------------------------------
Reporter: canassa | Owner: nobody
Type: | Status: new
Cleanup/optimization |

Component: Core (Management | Version: 1.8
commands) |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by timgraham):

* has_patch: 0 => 1
* type: Uncategorized => Cleanup/optimization
* stage: Unreviewed => Ready for checkin


--
Ticket URL: <https://code.djangoproject.com/ticket/25123#comment:3>

Django

unread,
Jul 14, 2015, 7:36:00 AM7/14/15
to django-...@googlegroups.com
#25123: Incorrect makemessage command help text
-------------------------------------+-------------------------------------
Reporter: canassa | Owner: nobody
Type: | Status: closed

Cleanup/optimization |
Component: Core (Management | Version: 1.8
commands) |
Severity: Normal | Resolution: fixed

Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Tim Graham <timograham@…>):

* status: new => closed
* resolution: => fixed


Comment:

In [changeset:"561c018d88203826cb9fd370e03a28e829871b75" 561c018]:
{{{
#!CommitTicketReference repository=""
revision="561c018d88203826cb9fd370e03a28e829871b75"
Fixed #25123 -- Corrected makemessages --extension help text
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/25123#comment:4>

Django

unread,
Jul 14, 2015, 7:36:35 AM7/14/15
to django-...@googlegroups.com
#25123: Incorrect makemessage command help text
-------------------------------------+-------------------------------------
Reporter: canassa | Owner: nobody

Type: | Status: closed
Cleanup/optimization |
Component: Core (Management | Version: 1.8
commands) |
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Tim Graham <timograham@…>):

In [changeset:"83b32422aade053515b5e485ef85228511908723" 83b3242]:
{{{
#!CommitTicketReference repository=""
revision="83b32422aade053515b5e485ef85228511908723"
[1.8.x] Fixed #25123 -- Corrected makemessages --extension help text

Backport of 561c018d88203826cb9fd370e03a28e829871b75 from master
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/25123#comment:5>

Reply all
Reply to author
Forward
0 new messages