[Django] #32905: Add `nonform` CSS class for non form errors in FormSets
Django
------------------------------------------------+--------------------------
Reporter: Ties Jan Hefting | Owner: nobody
Type: Cleanup/optimization | Status: assigned
Component: Forms | Version: dev
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 1
UI/UX: 0 |
------------------------------------------------+--------------------------
Forms add the `nonfield` CSS class for non field errors in ErrorClass
instances. This is documented in a section on
[https://docs.djangoproject.com/en/dev/topics/forms/#rendering-form-error-
messages rendering form error messages]. Similarly, in FormSets I'd expect
to see the `nonform` CSS class added for non form errors. This would allow
a custom ErrorClass to make a distinction in form field errors, non field
errors (forms) and non form errors (FormSets) when rendering error
messages. Therefore I'd suggest to add this `nonform` CSS class and
document it for developers to use.
--
Ticket URL: <https://code.djangoproject.com/ticket/32905>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
Reporter: Ties Jan Hefting | Owner: Ties Jan
Type: | Hefting
Cleanup/optimization | Status: assigned
Component: Forms | Version: dev
Keywords: | Triage Stage:
| Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
Changes (by Ties Jan Hefting):
* owner: nobody => Ties Jan Hefting
--
Ticket URL: <https://code.djangoproject.com/ticket/32905#comment:1>
Django
Reporter: Ties Jan Hefting | Owner: Ties Jan
| Hefting
Type: New feature | Status: assigned
Component: Forms | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak):
* type: Cleanup/optimization => New feature
* easy: 1 => 0
* stage: Unreviewed => Accepted
Comment:
Seems reasonable (similar to #11776).
--
Ticket URL: <https://code.djangoproject.com/ticket/32905#comment:2>
Django
Reporter: Ties Jan Hefting | Owner: Ties Jan
| Hefting
Component: Forms | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
-------------------------------------+-------------------------------------
* has_patch: 0 => 1
Old description:
> Forms add the `nonfield` CSS class for non field errors in ErrorClass
> instances. This is documented in a section on
> [https://docs.djangoproject.com/en/dev/topics/forms/#rendering-form-
> error-messages rendering form error messages]. Similarly, in FormSets I'd
> expect to see the `nonform` CSS class added for non form errors. This
> would allow a custom ErrorClass to make a distinction in form field
> errors, non field errors (forms) and non form errors (FormSets) when
> rendering error messages. Therefore I'd suggest to add this `nonform` CSS
> class and document it for developers to use.
New description:
Forms add the `nonfield` CSS class for non field errors in ErrorList
instances. This is documented in a section on
[https://docs.djangoproject.com/en/dev/topics/forms/#rendering-form-error-
messages rendering form error messages]. Similarly, in FormSets I'd expect
to see the `nonform` CSS class added for non form errors. This would allow
a custom ErrorList to make a distinction in form field errors, non field
errors (forms) and non form errors (FormSets) when rendering error
messages. Therefore I'd suggest to add this `nonform` CSS class and
document it for developers to use.
--
Comment:
[https://github.com/django/django/pull/14608 PR]
--
Ticket URL: <https://code.djangoproject.com/ticket/32905#comment:3>
Django
Reporter: Ties Jan Hefting | Owner: Ties Jan
| Hefting
Component: Forms | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* needs_better_patch: 0 => 1
--
Ticket URL: <https://code.djangoproject.com/ticket/32905#comment:4>
Django
Reporter: Ties Jan Hefting | Owner: Ties Jan
| Hefting
Component: Forms | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
-------------------------------------+-------------------------------------
* needs_better_patch: 1 => 0
--
Ticket URL: <https://code.djangoproject.com/ticket/32905#comment:5>
Django
Reporter: Ties Jan Hefting | Owner: Ties Jan
| Hefting
Component: Forms | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
-------------------------------------+-------------------------------------
* stage: Accepted => Ready for checkin
--
Ticket URL: <https://code.djangoproject.com/ticket/32905#comment:6>
Django
Reporter: Ties Jan Hefting | Owner: Ties Jan
| Hefting
Component: Forms | Version: dev
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Needs tests: 0 | Patch needs improvement: 0
-------------------------------------+-------------------------------------
* status: assigned => closed
* resolution: => fixed
Comment:
In [changeset:"84400d2e9db7c51fee4e9bb04c028f665b8e7624" 84400d2e]:
{{{
#!CommitTicketReference repository=""
revision="84400d2e9db7c51fee4e9bb04c028f665b8e7624"
Fixed #32905 -- Added CSS class for non-form errors of formsets.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/32905#comment:7>