[Django] #25052: UserCreationForm missing password_validaton.{validate, set}_password?

14 views
Skip to first unread message

Django

unread,
Jul 2, 2015, 11:14:39 AM7/2/15
to django-...@googlegroups.com
#25052: UserCreationForm missing password_validaton.{validate,set}_password?
------------------------------+--------------------
Reporter: lamby | Owner: nobody
Type: Bug | Status: new
Component: contrib.auth | Version: 1.8
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Easy pickings: 0 | UI/UX: 0
------------------------------+--------------------
Using the new password validation framework, it looks like
UserCreationForm is missing hooks to validate passwords as well as a
trigger to set_password after successful creation of the user.

If this is deliberate, I think it would deserve an entry into docs; it's
reasonable to assume that this form would validate passwords if there is a
global setting for it.

--
Ticket URL: <https://code.djangoproject.com/ticket/25052>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Jul 2, 2015, 11:46:19 AM7/2/15
to django-...@googlegroups.com
#25052: UserCreationForm missing password_validaton.{validate,set}_password?
---------------------------------+------------------------------------

Reporter: lamby | Owner: nobody
Type: Bug | Status: new
Component: contrib.auth | Version: master
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0
---------------------------------+------------------------------------
Changes (by timgraham):

* severity: Normal => Release blocker
* needs_better_patch: => 0
* needs_tests: => 0
* version: 1.8 => master
* needs_docs: => 0
* stage: Unreviewed => Accepted


Comment:

No, it's not an intentional omission (confirmed on the
[https://groups.google.com/d/msg/django-
developers/9GBhgGXmEKs/NGRqdLMAdzAJ django-developers thread]).

--
Ticket URL: <https://code.djangoproject.com/ticket/25052#comment:1>

Django

unread,
Jul 6, 2015, 6:20:11 PM7/6/15
to django-...@googlegroups.com
#25052: UserCreationForm missing password_validaton.{validate,set}_password?
---------------------------------+------------------------------------

Reporter: lamby | Owner: nobody
Type: Bug | Status: new
Component: contrib.auth | Version: master
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0
---------------------------------+------------------------------------
Changes (by timgraham):

* has_patch: 0 => 1


Comment:

[https://github.com/django/django/pull/4955 PR]

--
Ticket URL: <https://code.djangoproject.com/ticket/25052#comment:2>

Django

unread,
Jul 20, 2015, 1:45:06 PM7/20/15
to django-...@googlegroups.com
#25052: UserCreationForm missing password_validaton.{validate,set}_password?
---------------------------------+------------------------------------
Reporter: lamby | Owner: nobody
Type: Bug | Status: closed
Component: contrib.auth | Version: master
Severity: Release blocker | Resolution: fixed

Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0
---------------------------------+------------------------------------
Changes (by Tim Graham <timograham@…>):

* status: new => closed
* resolution: => fixed


Comment:

In [changeset:"774c16d16ed67d7cf12bc2b2752768b544bdb363" 774c16d1]:
{{{
#!CommitTicketReference repository=""
revision="774c16d16ed67d7cf12bc2b2752768b544bdb363"
Fixed #25052; refs #16860 -- Added password validation to
UserCreationForm.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/25052#comment:3>

Reply all
Reply to author
Forward
0 new messages