[Django] #35645: Inline H3 header style is visually stronger than the page's H1 (admin, light theme).

[Django]

#35645: Inline H3 header style is visually stronger than the page's H1 (admin,
light theme).
------------------------------------------+--------------------------------
Reporter: Natalia Bidart | Owner: Natalia Bidart
Type: Bug | Status: assigned
Component: contrib.admin | Version: 5.1
Severity: Normal | Keywords: accessibility
Triage Stage: Unreviewed | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 1 |
------------------------------------------+--------------------------------
Following the review of [https://github.com/django/django/pull/18308/ PR
18308] (which fixes #35558 and a fix landed in
e510bb1ab1fb22837c169e0459b81cf388b6d8d2), it was noticed that since the
inline H3 header was set to `--body-loud-color`, in the light theme this
color (black) is stronger than the page's H1, which is `--body-quiet-
color` (`#666`, dark-ish gray).

The page's H1 should be visually stronger than the H2 and H3 headings, so
I'm proposing to:

1. Have the table headers for `required` fields use `--body-fg` (`#333`),
instead of black, to match what every other `required` form label uses,
and to visually show a difference between the inline H3 and its content
(this is what motivated the changes in #35558).
2. Have the page's H1 use `--body-loud-color` to ensure this header is
visually stronger than any other heading in the page.

PR coming up shortly.
--
Ticket URL: <https://code.djangoproject.com/ticket/35645>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

[Django]

#35645: Inline H3 header style is visually stronger than the page's H1 (admin,
light theme).

--------------------------------+------------------------------------------

Reporter: Natalia Bidart | Owner: Natalia Bidart
Type: Bug | Status: assigned
Component: contrib.admin | Version: 5.1

Severity: Normal | Resolution:

Keywords: accessibility | Triage Stage: Unreviewed

Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1

--------------------------------+------------------------------------------
Changes (by Natalia Bidart):

* has_patch: 0 => 1

--
Ticket URL: <https://code.djangoproject.com/ticket/35645#comment:1>

[Django]

#35645: Inline H3 header style is visually stronger than the page's H1 (admin,
light theme).

-------------------------------------+-------------------------------------

Reporter: Natalia Bidart | Owner: Natalia
| Bidart
Type: Bug | Status: assigned
Component: contrib.admin | Version: 5.1

Severity: Release blocker | Resolution:
Keywords: accessibility | Triage Stage: Accepted

Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1

-------------------------------------+-------------------------------------
Changes (by Sarah Boyce):

* severity: Normal => Release blocker
* stage: Unreviewed => Accepted

Comment:

Thank you for following up
Unfortunately this would require an update to almost all images in
`docs/ref/contrib/admin/_images` and `docs/intro/_images`
--
Ticket URL: <https://code.djangoproject.com/ticket/35645#comment:2>

[Django]

#35645: Inline H3 header style is visually stronger than the page's H1 (admin,
light theme).
-------------------------------------+-------------------------------------
Reporter: Natalia Bidart | Owner: Natalia
| Bidart
Type: Bug | Status: assigned
Component: contrib.admin | Version: 5.1
Severity: Release blocker | Resolution:
Keywords: accessibility | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 1

Easy pickings: 0 | UI/UX: 1
-------------------------------------+-------------------------------------
Changes (by Sarah Boyce):

* needs_better_patch: 0 => 1

--
Ticket URL: <https://code.djangoproject.com/ticket/35645#comment:3>

[Django]

#35645: Inline H3 header style is visually stronger than the page's H1 (admin,
light theme).
-------------------------------------+-------------------------------------
Reporter: Natalia Bidart | Owner: Natalia
| Bidart

Type: Bug | Status: closed
Component: contrib.admin | Version: 5.1
Severity: Release blocker | Resolution: fixed

Keywords: accessibility | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 1
-------------------------------------+-------------------------------------

Changes (by nessita <124304+nessita@…>):

* resolution: => fixed
* status: assigned => closed

Comment:

In [changeset:"6e66c77089fa5498066d2aa593979e4f76f5bedc" 6e66c77]:
{{{#!CommitTicketReference repository=""
revision="6e66c77089fa5498066d2aa593979e4f76f5bedc"
Fixed #35645, Refs #35558 -- Added "medium" color in the admin CSS to
improve accessibility of headings.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/35645#comment:4>

[Django]

#35645: Inline H3 header style is visually stronger than the page's H1 (admin,
light theme).
-------------------------------------+-------------------------------------
Reporter: Natalia Bidart | Owner: Natalia
| Bidart
Type: Bug | Status: closed
Component: contrib.admin | Version: 5.1
Severity: Release blocker | Resolution: fixed

Keywords: accessibility | Triage Stage: Ready for
| checkin

Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 1
-------------------------------------+-------------------------------------

Changes (by Natalia Bidart):

* needs_better_patch: 1 => 0
* stage: Accepted => Ready for checkin

--
Ticket URL: <https://code.djangoproject.com/ticket/35645#comment:5>

[Django]

#35645: Inline H3 header style is visually stronger than the page's H1 (admin,
light theme).
-------------------------------------+-------------------------------------
Reporter: Natalia Bidart | Owner: Natalia
| Bidart
Type: Bug | Status: closed
Component: contrib.admin | Version: 5.1
Severity: Release blocker | Resolution: fixed
Keywords: accessibility | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------------+-------------------------------------

Comment (by Natalia <124304+nessita@…>):

In [changeset:"2c4f0c06dbb74a9752771e9d341f634602fb298a" 2c4f0c06]:
{{{#!CommitTicketReference repository=""
revision="2c4f0c06dbb74a9752771e9d341f634602fb298a"
[5.1.x] Fixed #35645, Refs #35558 -- Added "medium" color in the admin CSS

to improve accessibility of headings.

Backport of 6e66c77089fa5498066d2aa593979e4f76f5bedc from main.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/35645#comment:6>