Re: [Django] #15184: Error when subclassing models.ForeignKey field

10 views
Skip to first unread message

Django

unread,
Jun 13, 2014, 3:34:40 PM6/13/14
to django-...@googlegroups.com
#15184: Error when subclassing models.ForeignKey field
-------------------------------------+-------------------------------------
Reporter: rupa108 | Owner:
Type: Bug | furious_luke
Component: Database layer | Status: new
(models, ORM) | Version: master
Severity: Normal | Resolution:
Keywords: ForeignKey, models, | Triage Stage: Accepted
subclassing | Needs documentation: 0
Has patch: 1 | Patch needs improvement: 1
Needs tests: 0 | UI/UX: 0
Easy pickings: 0 |
-------------------------------------+-------------------------------------
Changes (by timo):

* needs_better_patch: 0 => 1


Comment:

Patch needs to be updated to apply cleanly.

--
Ticket URL: <https://code.djangoproject.com/ticket/15184#comment:13>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Oct 18, 2014, 7:28:54 AM10/18/14
to django-...@googlegroups.com
#15184: Error when subclassing models.ForeignKey field
-------------------------------------+-------------------------------------
Reporter: rupa108 | Owner:
Type: Bug | furious_luke
Component: Database layer | Status: new
(models, ORM) | Version: master
Severity: Normal | Resolution:
Keywords: ForeignKey, models, | Triage Stage: Accepted
subclassing | Needs documentation: 0
Has patch: 1 | Patch needs improvement: 1
Needs tests: 0 | UI/UX: 0
Easy pickings: 0 |
-------------------------------------+-------------------------------------

Comment (by timgraham):

`SubfieldBase` has been
[https://docs.djangoproject.com/en/dev/releases/1.8/#subfieldbase
deprecated in Django 1.8]. Can the issue be reproduced without it? If so,
please update the patch, thanks. If not, we should close this ticket.

--
Ticket URL: <https://code.djangoproject.com/ticket/15184#comment:14>

Django

unread,
Oct 19, 2014, 11:10:17 PM10/19/14
to django-...@googlegroups.com
#15184: Error when subclassing models.ForeignKey field
-------------------------------------+-------------------------------------
Reporter: rupa108 | Owner:
Type: Bug | furious_luke
Component: Database layer | Status: new
(models, ORM) | Version: master
Severity: Normal | Resolution:
Keywords: ForeignKey, models, | Triage Stage: Accepted
subclassing | Needs documentation: 0
Has patch: 1 | Patch needs improvement: 1
Needs tests: 0 | UI/UX: 0
Easy pickings: 0 |
-------------------------------------+-------------------------------------

Comment (by furious-luke):

The deprecation of `SubfieldBase` appears to have eliminated the issue!

--
Ticket URL: <https://code.djangoproject.com/ticket/15184#comment:15>

Django

unread,
Oct 20, 2014, 12:40:21 AM10/20/14
to django-...@googlegroups.com
#15184: Error when subclassing models.ForeignKey field
-------------------------------------+-------------------------------------
Reporter: rupa108 | Owner:
Type: Bug | furious_luke
Component: Database layer | Status: closed
(models, ORM) | Version: master
Severity: Normal | Resolution: fixed

Keywords: ForeignKey, models, | Triage Stage: Accepted
subclassing | Needs documentation: 0
Has patch: 1 | Patch needs improvement: 1
Needs tests: 0 | UI/UX: 0
Easy pickings: 0 |
-------------------------------------+-------------------------------------
Changes (by charettes):

* status: new => closed
* resolution: => fixed


Comment:

@furious-luke, we'll close the ticket as fixed then.

--
Ticket URL: <https://code.djangoproject.com/ticket/15184#comment:16>

Reply all
Reply to author
Forward
0 new messages