[Django] #23566: On "Community blog posts" Feeds RSS updated for nothing

9 views
Skip to first unread message

Django

unread,
Sep 29, 2014, 3:49:37 AM9/29/14
to django-...@googlegroups.com
#23566: On "Community blog posts" Feeds RSS updated for nothing
-------------------------------------+--------------------
Reporter: foxmask | Owner: nobody
Type: Uncategorized | Status: new
Component: *.djangoproject.com | Version: 1.7
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+--------------------
Hi,
I made a tools that grab data from Feeds and put them to others service
(like Evernote in my case)
And I think I spotted an issue with the RSS Feeds on
https://www.djangoproject.com/community/ the "Community blog posts" part
(may be the others are impacted but I didnt check). The date of the feeds
is updated but the provider of the feeds did not change anything.

For example, the current last post is on "Community blog posts":

on https://www.vlent.nl/weblog/feed.atom ; its last post has :

<id>tag:www.vlent.nl,2014-09-28:/weblog/2014/09/28/how-we-use-
virtualenv-buildout-and-docker/</id>
<updated>2014-09-28T21:53:00Z</updated>

But on https://www.djangoproject.com/community/ the Feeds tell us :

<lastBuildDate>Sun, 28 Sep 2014 21:53:00 -0500</lastBuildDate>

As my batch works each hour from a crontab, I received this "news" more
than once.

It looks like this is the last build date of the entire Feeds "Community
blog posts" itself, but not the last update of the provider source
https://www.vlent.nl/weblog/feed.atom.

Regards

--
Ticket URL: <https://code.djangoproject.com/ticket/23566>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Oct 1, 2014, 10:01:12 AM10/1/14
to django-...@googlegroups.com
#23566: On "Community blog posts" Feeds RSS updated for nothing
-------------------------------------+-------------------------------------

Reporter: foxmask | Owner: nobody
Type: Uncategorized | Status: new
Component: *.djangoproject.com | Version: 1.7
Severity: Normal | Resolution:
Keywords: | Triage Stage:
Has patch: 0 | Unreviewed
Needs tests: 0 | Needs documentation: 0
Easy pickings: 0 | Patch needs improvement: 0
| UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by timgraham):

* needs_better_patch: => 0
* needs_tests: => 0
* needs_docs: => 0


Comment:

Here is the logic for how the feed's `lastBuildDate` is generated:
https://github.com/django/django/blob/fe2afcd318493c933ab1191a5a64271869a1227f/django/utils/feedgenerator.py#L194-L209

I don't understand the issue. It looks like the two dates in your example
above are the same?

--
Ticket URL: <https://code.djangoproject.com/ticket/23566#comment:1>

Django

unread,
Oct 1, 2014, 10:42:38 AM10/1/14
to django-...@googlegroups.com
#23566: On "Community blog posts" Feeds RSS updated for nothing
-------------------------------------+-------------------------------------

Reporter: foxmask | Owner: nobody
Type: Uncategorized | Status: new
Component: *.djangoproject.com | Version: 1.7
Severity: Normal | Resolution:
Keywords: | Triage Stage:
Has patch: 0 | Unreviewed
Needs tests: 0 | Needs documentation: 0
Easy pickings: 0 | Patch needs improvement: 0
| UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by foxmask):

Hi,

the two date are different as one of them use a TIMEZONE (-0500) and not
the second one. I'm not a datetime expert but may be this should be handle
in the piece of code you linked above ?

--
Ticket URL: <https://code.djangoproject.com/ticket/23566#comment:2>

Django

unread,
Oct 1, 2014, 11:03:14 AM10/1/14
to django-...@googlegroups.com
#23566: Incorrect timezone handling in feed community blog post aggregator?
-------------------------------------+------------------------------------
Reporter: foxmask | Owner: nobody
Type: Bug | Status: new
Component: *.djangoproject.com | Version:
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0
-------------------------------------+------------------------------------
Changes (by timgraham):

* version: 1.7 =>
* type: Uncategorized => Bug
* stage: Unreviewed => Accepted


Comment:

I guess we have timezone issues in the `feed_updated()` function of the
models.py file here:
https://github.com/django/djangoproject.com/tree/master/aggregator.

--
Ticket URL: <https://code.djangoproject.com/ticket/23566#comment:3>

Django

unread,
Oct 1, 2014, 11:13:34 AM10/1/14
to django-...@googlegroups.com
#23566: Incorrect timezone handling in feed community blog post aggregator?
-------------------------------------+------------------------------------
Reporter: foxmask | Owner: nobody
Type: Bug | Status: new
Component: *.djangoproject.com | Version:

Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0
-------------------------------------+------------------------------------

Comment (by foxmask):

from the models.py I see here
https://github.com/django/djangoproject.com/blob/master/aggregator/models.py#L159-164,
on my side, I had to do this to handle the same behavior
https://github.com/foxmask/django-
th/blob/master/django_th/management/commands/fire_th.py#L36-43 but without
dropping the end of the date (by using [:6] if 'im not wrong) makes more
problem than it solves them.

--
Ticket URL: <https://code.djangoproject.com/ticket/23566#comment:4>

Django

unread,
Oct 1, 2014, 12:15:09 PM10/1/14
to django-...@googlegroups.com
#23566: Incorrect timezone handling in feed community blog post aggregator?
-------------------------------------+------------------------------------
Reporter: foxmask | Owner: nobody
Type: Bug | Status: new
Component: *.djangoproject.com | Version:

Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0
-------------------------------------+------------------------------------

Comment (by timgraham):

Care to submit a pull request?

--
Ticket URL: <https://code.djangoproject.com/ticket/23566#comment:5>

Django

unread,
Dec 18, 2014, 4:01:50 PM12/18/14
to django-...@googlegroups.com
#23566: Incorrect timezone handling in feed community blog post aggregator?
-------------------------------------+-------------------------------------
Reporter: foxmask | Owner: nobody
Type: Bug | Status: closed
Component: *.djangoproject.com | Version:
Severity: Normal | Resolution: duplicate

Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by timgraham):

* status: new => closed
* resolution: => duplicate


Comment:

Moved to https://github.com/django/djangoproject.com/issues/241.

--
Ticket URL: <https://code.djangoproject.com/ticket/23566#comment:6>

Reply all
Reply to author
Forward
0 new messages