[Django] #36667: How to Request PR Reviews Without Overstepping

8 views
Skip to first unread message

Django

unread,
Oct 16, 2025, 8:06:02 AM (6 days ago) Oct 16
to django-...@googlegroups.com
#36667: How to Request PR Reviews Without Overstepping
-------------------------------------+-------------------------------------
Reporter: Eddy ADEGNANDJOU | Type:
| Cleanup/optimization
Status: new | Component:
| Documentation
Version: dev | Severity: Normal
Keywords: | Triage Stage:
| Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Co-authored by: Sarah Boyce

Contributors often express uncertainty about how to get feedback or
reviews on their Django pull requests. While maintainers and fellows
eventually review all submissions, the waiting period can be unclear, and
contributors may hesitate to reach out for fear of being intrusive.

This ticket is inspired by a discussion between Josh Thomas and Sarah
Boyce, and proposes adding a section to the Contributing to Django
documentation that outlines respectful and effective ways for contributors
to request reviews.
--
Ticket URL: <https://code.djangoproject.com/ticket/36667>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Oct 16, 2025, 8:06:16 AM (6 days ago) Oct 16
to django-...@googlegroups.com
#36667: How to Request PR Reviews Without Overstepping
-------------------------------------+-------------------------------------
Reporter: Eddy ADEGNANDJOU | Owner: Eddy
Type: | ADEGNANDJOU
Cleanup/optimization | Status: assigned
Component: Documentation | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage:
| Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Eddy ADEGNANDJOU):

* owner: (none) => Eddy ADEGNANDJOU
* status: new => assigned

--
Ticket URL: <https://code.djangoproject.com/ticket/36667#comment:1>

Django

unread,
Oct 17, 2025, 7:18:23 AM (5 days ago) Oct 17
to django-...@googlegroups.com
#36667: How to Request PR Reviews Without Overstepping
-------------------------------------+-------------------------------------
Reporter: Eddy ADEGNANDJOU | Owner: Eddy
Type: | ADEGNANDJOU
Cleanup/optimization | Status: assigned
Component: Documentation | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage:
| Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Mariusz Felisiak):

This is already covered by
[https://docs.djangoproject.com/en/dev/faq/contributing/ FAQ: Contributing
code]. I don't see a reason to duplicate it in another section in docs.
--
Ticket URL: <https://code.djangoproject.com/ticket/36667#comment:2>

Django

unread,
Oct 17, 2025, 9:15:54 AM (5 days ago) Oct 17
to django-...@googlegroups.com
#36667: How to Request PR Reviews Without Overstepping
-------------------------------------+-------------------------------------
Reporter: Eddy ADEGNANDJOU | Owner: Eddy
Type: | ADEGNANDJOU
Cleanup/optimization | Status: closed
Component: Documentation | Version: dev
Severity: Normal | Resolution: needsinfo
Keywords: | Triage Stage:
| Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Jacob Walls):

* resolution: => needsinfo
* status: assigned => closed

Comment:

Thanks for the link, Mariusz. Eddy, if you have a concrete edit to suggest
to that page we can take a look, but I agree we shouldn't create a new
one.
--
Ticket URL: <https://code.djangoproject.com/ticket/36667#comment:3>

Django

unread,
Oct 18, 2025, 12:50:45 AM (4 days ago) Oct 18
to django-...@googlegroups.com
#36667: How to Request PR Reviews Without Overstepping
-------------------------------------+-------------------------------------
Reporter: Eddy ADEGNANDJOU | Owner: Eddy
Type: | ADEGNANDJOU
Cleanup/optimization | Status: closed
Component: Documentation | Version: dev
Severity: Normal | Resolution: needsinfo
Keywords: | Triage Stage:
| Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Eddy ADEGNANDJOU):

Here is the discussion that suggests the ticket:

[[https://discord.com/channels/1114005656937177168/1418046832717725807/1418313613680312393|Discord:
Advice on getting reviews for Django PR]]

The idea is to update
[[https://docs.djangoproject.com/en/5.2/faq/contributing/#new-
contributors-faq|FAQ: Contributing code]] area of the Django docs to
include a set of guidelines mentionned in the discussion.
--
Ticket URL: <https://code.djangoproject.com/ticket/36667#comment:4>

Django

unread,
Oct 18, 2025, 10:42:24 AM (4 days ago) Oct 18
to django-...@googlegroups.com
#36667: How to Request PR Reviews Without Overstepping
-------------------------------------+-------------------------------------
Reporter: Eddy ADEGNANDJOU | Owner: Eddy
Type: | ADEGNANDJOU
Cleanup/optimization | Status: closed
Component: Documentation | Version: dev
Severity: Normal | Resolution: needsinfo
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Jacob Walls):

* stage: Unreviewed => Accepted

Comment:

Makes sense, we can rewrite this section to incorporate Sarah's advice.
--
Ticket URL: <https://code.djangoproject.com/ticket/36667#comment:5>

Django

unread,
Oct 18, 2025, 10:42:32 AM (4 days ago) Oct 18
to django-...@googlegroups.com
#36667: How to Request PR Reviews Without Overstepping
-------------------------------------+-------------------------------------
Reporter: Eddy ADEGNANDJOU | Owner: Eddy
Type: | ADEGNANDJOU
Cleanup/optimization | Status: new
Component: Documentation | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Jacob Walls):

* resolution: needsinfo =>
* status: closed => new

--
Ticket URL: <https://code.djangoproject.com/ticket/36667#comment:6>
Reply all
Reply to author
Forward
0 new messages