[Django] #31791: Make technical 404 page always show tried URL patterns

36 views
Skip to first unread message

Django

unread,
Jul 14, 2020, 3:06:41 PM7/14/20
to django-...@googlegroups.com
#31791: Make technical 404 page always show tried URL patterns
-------------------------------------------+------------------------
Reporter: Jon Dufresne | Owner: (none)
Type: New feature | Status: new
Component: Error reporting | Version: master
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
-------------------------------------------+------------------------
Right now, the technical 404 page (shown in DEBUG mode) shows the URL
patterns when a URL is not matched. This is quite handy for debugging, as
it helps show why a URL resulted in a 404. However, when a URL is matched
and the view raises `Http404`, this information is not shown. I'm
suggesting we show all URLs that were tried up to the point of resolution
of the URL to provide more debugging info.

(Extracted from https://github.com/django/django/pull/13134)

--
Ticket URL: <https://code.djangoproject.com/ticket/31791>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Jul 14, 2020, 3:08:34 PM7/14/20
to django-...@googlegroups.com
#31791: Make technical 404 page always show tried URL patterns
---------------------------------+--------------------------------------

Reporter: Jon Dufresne | Owner: (none)
Type: New feature | Status: new
Component: Error reporting | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Unreviewed
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
---------------------------------+--------------------------------------
Changes (by Jon Dufresne):

* has_patch: 0 => 1


Comment:

https://github.com/django/django/pull/13189

--
Ticket URL: <https://code.djangoproject.com/ticket/31791#comment:1>

Django

unread,
Jul 15, 2020, 6:26:12 AM7/15/20
to django-...@googlegroups.com
#31791: Make technical 404 page always show tried URL patterns
---------------------------------+--------------------------------------

Reporter: Jon Dufresne | Owner: (none)
Type: New feature | Status: new
Component: Error reporting | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Unreviewed
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
---------------------------------+--------------------------------------

Comment (by Carlton Gibson):

Thanks Jon. This looked like a nice win when I glanced at it before, so
very happy to take this for review. 👍

--
Ticket URL: <https://code.djangoproject.com/ticket/31791#comment:2>

Django

unread,
Jul 15, 2020, 8:56:07 AM7/15/20
to django-...@googlegroups.com
#31791: Make technical 404 page always show tried URL patterns
---------------------------------+------------------------------------

Reporter: Jon Dufresne | Owner: (none)
Type: New feature | Status: new
Component: Error reporting | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
---------------------------------+------------------------------------
Changes (by Carlton Gibson):

* stage: Unreviewed => Accepted


--
Ticket URL: <https://code.djangoproject.com/ticket/31791#comment:3>

Django

unread,
Jul 16, 2020, 10:00:53 AM7/16/20
to django-...@googlegroups.com
#31791: Make technical 404 page always show tried URL patterns
---------------------------------+----------------------------------------
Reporter: Jon Dufresne | Owner: Jon Dufresne
Type: New feature | Status: assigned

Component: Error reporting | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
---------------------------------+----------------------------------------
Changes (by Nick Pope):

* owner: (none) => Jon Dufresne
* status: new => assigned


--
Ticket URL: <https://code.djangoproject.com/ticket/31791#comment:4>

Django

unread,
Sep 4, 2020, 4:14:46 AM9/4/20
to django-...@googlegroups.com
#31791: Make technical 404 page always show tried URL patterns
---------------------------------+----------------------------------------
Reporter: Jon Dufresne | Owner: Jon Dufresne
Type: New feature | Status: assigned
Component: Error reporting | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1

Easy pickings: 0 | UI/UX: 0
---------------------------------+----------------------------------------
Changes (by felixxm):

* needs_better_patch: 0 => 1


--
Ticket URL: <https://code.djangoproject.com/ticket/31791#comment:5>

Django

unread,
Sep 6, 2020, 12:56:34 PM9/6/20
to django-...@googlegroups.com
#31791: Make technical 404 page always show tried URL patterns
---------------------------------+----------------------------------------
Reporter: Jon Dufresne | Owner: Jon Dufresne
Type: New feature | Status: assigned
Component: Error reporting | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
---------------------------------+----------------------------------------
Changes (by Jon Dufresne):

* needs_better_patch: 1 => 0


--
Ticket URL: <https://code.djangoproject.com/ticket/31791#comment:6>

Django

unread,
Sep 7, 2020, 1:42:58 AM9/7/20
to django-...@googlegroups.com
#31791: Make technical 404 page always show tried URL patterns
---------------------------------+----------------------------------------
Reporter: Jon Dufresne | Owner: Jon Dufresne
Type: New feature | Status: closed

Component: Error reporting | Version: master
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
---------------------------------+----------------------------------------
Changes (by Mariusz Felisiak <felisiak.mariusz@…>):

* status: assigned => closed
* resolution: => fixed


Comment:

In [changeset:"11ebc6479ffda87376b60c9475d33d8120f86368" 11ebc647]:
{{{
#!CommitTicketReference repository=""
revision="11ebc6479ffda87376b60c9475d33d8120f86368"
Fixed #31791 -- Made technical 404 debug page display the tried URL
patterns for Http404.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/31791#comment:7>

Django

unread,
Jan 11, 2021, 1:49:39 AM1/11/21
to django-...@googlegroups.com
#31791: Make technical 404 page always show tried URL patterns
---------------------------------+----------------------------------------
Reporter: Jon Dufresne | Owner: Jon Dufresne
Type: New feature | Status: closed
Component: Error reporting | Version: master
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
---------------------------------+----------------------------------------

Comment (by GitHub <noreply@…>):

In [changeset:"622fcb81199864cad1ec9d0b25820a96ef3f586f" 622fcb8]:
{{{
#!CommitTicketReference repository=""
revision="622fcb81199864cad1ec9d0b25820a96ef3f586f"
Refs #31791 -- Improved performance of URLResolver.resolve().

Performance regression in 11ebc6479ffda87376b60c9475d33d8120f86368.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/31791#comment:8>

Reply all
Reply to author
Forward
0 new messages