[Django] #37164: Support jsonl Deserializer subclasses' _get_lines methods

4 views
Skip to first unread message

Django

unread,
Jun 11, 2026, 6:26:18 PM (8 days ago) Jun 11
to django-...@googlegroups.com
#37164: Support jsonl Deserializer subclasses' _get_lines methods
-------------------------------------+-------------------------------------
Reporter: Adam | Owner: Adam Johnson
Johnson |
Type: | Status: assigned
Cleanup/optimization |
Component: Core | Version: dev
(Serialization) |
Severity: Normal | Keywords:
Triage Stage: | Has patch: 0
Unreviewed |
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
-------------------------------------+-------------------------------------
The jsonl `Deserializer` class calls `Deserializer._get_lines()` directly,
rather than via `self`, preventing subclasses from overriding this methods
(for example, to use an alternative JSON library). This has been the case
since ee5147cfd7de2add74a285537a8968ec074e70cd. Let's change it to use
`self`.
--
Ticket URL: <https://code.djangoproject.com/ticket/37164>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Jun 11, 2026, 6:35:34 PM (8 days ago) Jun 11
to django-...@googlegroups.com
#37164: Support jsonl Deserializer subclasses' _get_lines methods
-------------------------------------+-------------------------------------
Reporter: Adam Johnson | Owner: Adam
Type: | Johnson
Cleanup/optimization | Status: assigned
Component: Core | Version: dev
(Serialization) |
Severity: Normal | Resolution:
Keywords: | Triage Stage:
| Unreviewed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Adam Johnson):

* has_patch: 0 => 1

--
Ticket URL: <https://code.djangoproject.com/ticket/37164#comment:1>

Django

unread,
Jun 17, 2026, 10:27:09 AM (2 days ago) Jun 17
to django-...@googlegroups.com
#37164: Support jsonl Deserializer subclasses' _get_lines methods
-------------------------------------+-------------------------------------
Reporter: Adam Johnson | Owner: Adam
Type: | Johnson
Cleanup/optimization | Status: assigned
Component: Core | Version: dev
(Serialization) |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Tim Graham):

* stage: Unreviewed => Ready for checkin

--
Ticket URL: <https://code.djangoproject.com/ticket/37164#comment:2>

Django

unread,
Jun 18, 2026, 3:25:27 PM (yesterday) Jun 18
to django-...@googlegroups.com
#37164: Support jsonl Deserializer subclasses' _get_lines methods
-------------------------------------+-------------------------------------
Reporter: Adam Johnson | Owner: Adam
Type: | Johnson
Cleanup/optimization | Status: closed
Component: Core | Version: dev
(Serialization) |
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Jacob Walls <jacobtylerwalls@…>):

* resolution: => fixed
* status: assigned => closed

Comment:

In [changeset:"189c2d2ce58482db5c09d8b1e1464d1456dc9bab" 189c2d2c]:
{{{#!CommitTicketReference repository=""
revision="189c2d2ce58482db5c09d8b1e1464d1456dc9bab"
Fixed #37164 -- Supported subclasses’ _get_lines() in jsonl Deserializer.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/37164#comment:3>
Reply all
Reply to author
Forward
0 new messages