[Django] #28558: Simplify code by removing OGRIndexError

4 views
Skip to first unread message

Django

unread,
Sep 2, 2017, 3:10:04 AM9/2/17
to django-...@googlegroups.com
#28558: Simplify code by removing OGRIndexError
-------------------------------------+-------------------------------------
Reporter: Nick Pope | Owner: Nick Pope
Type: | Status: assigned
Cleanup/optimization |
Component: GIS | Version: master
Severity: Normal | Keywords: gis
Triage Stage: | Has patch: 0
Unreviewed |
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
-------------------------------------+-------------------------------------
Ticket #25225 cleaned up `GEOSIndexError` as template engine lookups began
handling `IndexError` and it was no longer required.
([[https://code.djangoproject.com/ticket/25225#comment:3|comment]])

It looks as though this fix for catching `IndexError` was made in #23489.

The proposal is to make the equivalent changes as in #25225 for
`OGRIndexError` which also allows for related simplifications, e.g.
removal of `__iter__` in many GDAL objects.

--
Ticket URL: <https://code.djangoproject.com/ticket/28558>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Sep 2, 2017, 3:50:47 AM9/2/17
to django-...@googlegroups.com
#28558: Simplify code by removing OGRIndexError
-------------------------------------+-------------------------------------
Reporter: Nick Pope | Owner: Nick Pope
Type: | Status: assigned
Cleanup/optimization |
Component: GIS | Version: master
Severity: Normal | Resolution:
Keywords: gis | Triage Stage:
| Unreviewed
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Nick Pope):

* has_patch: 0 => 1


Comment:

[[https://github.com/django/django/pull/9006|PR]]

--
Ticket URL: <https://code.djangoproject.com/ticket/28558#comment:1>

Django

unread,
Sep 2, 2017, 2:59:06 PM9/2/17
to django-...@googlegroups.com
#28558: Simplify code by removing OGRIndexError
-------------------------------------+-------------------------------------
Reporter: Nick Pope | Owner: Nick Pope
Type: | Status: assigned
Cleanup/optimization |
Component: GIS | Version: master
Severity: Normal | Resolution:
Keywords: gis | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1

Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Tim Graham):

* needs_better_patch: 0 => 1
* stage: Unreviewed => Accepted


--
Ticket URL: <https://code.djangoproject.com/ticket/28558#comment:2>

Django

unread,
Sep 3, 2017, 6:09:39 PM9/3/17
to django-...@googlegroups.com
#28558: Simplify code by removing OGRIndexError
-------------------------------------+-------------------------------------
Reporter: Nick Pope | Owner: Nick Pope
Type: | Status: assigned
Cleanup/optimization |
Component: GIS | Version: master
Severity: Normal | Resolution:
Keywords: gis | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Nick Pope):

* needs_better_patch: 1 => 0


--
Ticket URL: <https://code.djangoproject.com/ticket/28558#comment:3>

Django

unread,
Sep 3, 2017, 9:19:54 PM9/3/17
to django-...@googlegroups.com
#28558: Simplify code by removing OGRIndexError
-------------------------------------+-------------------------------------
Reporter: Nick Pope | Owner: Nick Pope
Type: | Status: closed

Cleanup/optimization |
Component: GIS | Version: master
Severity: Normal | Resolution: fixed

Keywords: gis | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Tim Graham <timograham@…>):

* status: assigned => closed
* resolution: => fixed


Comment:

In [changeset:"9397d3add47f220249c8e543c79489618aaf50d6" 9397d3ad]:
{{{
#!CommitTicketReference repository=""
revision="9397d3add47f220249c8e543c79489618aaf50d6"
Fixed #28558 -- Simplified code to remove OGRIndexError.

The test is a regression for refs #4740 to show that the original fix of
OGRIndexError is no longer needed.

This is similar to the removal of GEOSIndexError in
197b1878105504b5ac7e399e1f52a6093c88baa3.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/28558#comment:4>

Reply all
Reply to author
Forward
0 new messages