[Django] #23900: Section on Preventing header injection does not include some imports
Django
--------------------------------------+----------------------------------
Reporter: kevgathuku | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: Uncategorized | Version: 1.7
Severity: Normal | Keywords: BadHeaderError, docs
Triage Stage: Unreviewed | Has patch: 0
Easy pickings: 1 | UI/UX: 0
--------------------------------------+----------------------------------
The documentation section on Preventing header injection
https://docs.djangoproject.com/en/1.7/topics/email/#preventing-header-
injection, and specifically, the example provided uses HttpResponse and
HttpResponseRedirect yet they are not imported.
--
Ticket URL: <https://code.djangoproject.com/ticket/23900>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
Reporter: kevgathuku | Owner:
Type: | kevgathuku
Cleanup/optimization | Status: assigned
Component: Uncategorized | Version: 1.7
Severity: Normal | Resolution:
Keywords: BadHeaderError, | Triage Stage:
docs | Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
Changes (by kevgathuku):
* status: new => assigned
* needs_docs: => 0
* owner: nobody => kevgathuku
* needs_tests: => 0
* needs_better_patch: => 0
--
Ticket URL: <https://code.djangoproject.com/ticket/23900#comment:1>
Django
Reporter: kevgathuku | Owner:
Type: | kevgathuku
Cleanup/optimization | Status: assigned
Severity: Normal | Resolution:
Keywords: BadHeaderError, | Triage Stage:
docs | Unreviewed
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
Changes (by kevgathuku):
* has_patch: 0 => 1
--
Ticket URL: <https://code.djangoproject.com/ticket/23900#comment:2>
Django
Reporter: kevgathuku | Owner:
Type: | kevgathuku
Cleanup/optimization | Status: assigned
Severity: Normal | Resolution:
Keywords: BadHeaderError, | Triage Stage: Accepted
docs | Needs documentation: 0
Has patch: 1 | Patch needs improvement: 0
Needs tests: 0 | UI/UX: 0
Easy pickings: 1 |
-------------------------------------+-------------------------------------
Changes (by berkerpeksag):
* version: 1.7 => master
* component: Uncategorized => Documentation
* stage: Unreviewed => Accepted
Comment:
PR is at https://github.com/django/django/pull/3608 and LGTM.
--
Ticket URL: <https://code.djangoproject.com/ticket/23900#comment:3>
Django
Reporter: kevgathuku | Owner:
Type: | kevgathuku
Cleanup/optimization | Status: assigned
Component: Documentation | Version: master
Severity: Normal | Resolution:
docs | checkin
Has patch: 1 | Needs documentation: 0
Easy pickings: 1 | UI/UX: 0
Changes (by berkerpeksag):
* stage: Accepted => Ready for checkin
--
Ticket URL: <https://code.djangoproject.com/ticket/23900#comment:4>
Django
Reporter: kevgathuku | Owner:
Type: | kevgathuku
Component: Documentation | Version: master
Severity: Normal | Resolution: fixed
Keywords: BadHeaderError, | Triage Stage: Ready for
docs | checkin
Has patch: 1 | Needs documentation: 0
Easy pickings: 1 | UI/UX: 0
Changes (by Baptiste Mispelon <bmispelon@…>):
* status: assigned => closed
* resolution: => fixed
Comment:
In [changeset:"0d74209ef66111f29f122d5f5fdf8e2964890cc5"]:
{{{
#!CommitTicketReference repository=""
revision="0d74209ef66111f29f122d5f5fdf8e2964890cc5"
Fixed #23900 -- Added missing imports in code example.
The Preventing header injection example included
classes that are not imported.
Thanks to Collin Anderson and Berker Peksağ for the
reviews.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/23900#comment:5>
Django
Reporter: kevgathuku | Owner:
Type: | kevgathuku
Cleanup/optimization | Status: closed
Component: Documentation | Version: master
Severity: Normal | Resolution: fixed
Keywords: BadHeaderError, | Triage Stage: Ready for
docs | checkin
Has patch: 1 | Needs documentation: 0
Easy pickings: 1 | UI/UX: 0
Comment (by Baptiste Mispelon <bmispelon@…>):
In [changeset:"22d292e23b1b60fd5c304b3d867ecf70860e7048"]:
{{{
#!CommitTicketReference repository=""
revision="22d292e23b1b60fd5c304b3d867ecf70860e7048"
[1.7.x] Fixed #23900 -- Added missing imports in code example.
The Preventing header injection example included
classes that are not imported.
Thanks to Collin Anderson and Berker Peksağ for the
reviews.
Backport of 0d74209ef66111f29f122d5f5fdf8e2964890cc5 from master.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/23900#comment:6>
Django
Reporter: kevgathuku | Owner:
Type: | kevgathuku
Cleanup/optimization | Status: closed
Component: Documentation | Version: master
Severity: Normal | Resolution: fixed
Keywords: BadHeaderError, | Triage Stage: Ready for
docs | checkin
Has patch: 1 | Needs documentation: 0
Easy pickings: 1 | UI/UX: 0
Comment (by Baptiste Mispelon <bmispelon@…>):
In [changeset:"db227d9d20d848c56f94ce0ca175fde7e1180c21"]:
{{{
#!CommitTicketReference repository=""
revision="db227d9d20d848c56f94ce0ca175fde7e1180c21"
[1.6.x] Fixed #23900 -- Added missing imports in code example.
The Preventing header injection example included
classes that are not imported.
Thanks to Collin Anderson and Berker Peksağ for the
reviews.
Backport of 0d74209ef66111f29f122d5f5fdf8e2964890cc5 from master.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/23900#comment:7>