Re: [Django] #31703: Name all initial migrations "NNNN_initial".

15 views
Skip to first unread message

Django

unread,
Jun 23, 2020, 3:21:48 AM6/23/20
to django-...@googlegroups.com
#31703: Name all initial migrations "NNNN_initial".
-------------------------------------+-------------------------------------
Reporter: Jon Dufresne | Owner: Jon
Type: | Dufresne
Cleanup/optimization | Status: assigned
Component: Migrations | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by felixxm):

* owner: nobody => Jon Dufresne
* needs_better_patch: 0 => 1
* status: new => assigned


--
Ticket URL: <https://code.djangoproject.com/ticket/31703#comment:3>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Jun 24, 2020, 1:19:43 AM6/24/20
to django-...@googlegroups.com
#31703: Name all initial migrations "NNNN_initial".
-------------------------------------+-------------------------------------
Reporter: Jon Dufresne | Owner: Jon
Type: | Dufresne
Cleanup/optimization | Status: assigned
Component: Migrations | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Ready for
| checkin

Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by felixxm):

* needs_better_patch: 1 => 0
* stage: Accepted => Ready for checkin


--
Ticket URL: <https://code.djangoproject.com/ticket/31703#comment:4>

Django

unread,
Jun 24, 2020, 2:05:02 AM6/24/20
to django-...@googlegroups.com
#31703: Name all initial migrations "NNNN_initial".
-------------------------------------+-------------------------------------
Reporter: Jon Dufresne | Owner: Jon
Type: | Dufresne
Cleanup/optimization | Status: closed
Component: Migrations | Version: master
Severity: Normal | Resolution: fixed

Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak <felisiak.mariusz@…>):

* status: assigned => closed
* resolution: => fixed


Comment:

In [changeset:"6f3e3e87ab72eb64dcce8e646f8eea07be6c3b7e" 6f3e3e87]:
{{{
#!CommitTicketReference repository=""
revision="6f3e3e87ab72eb64dcce8e646f8eea07be6c3b7e"
Fixed #31703 -- Made makemigrations name all initial migrations "initial".

When the MigrationAutodetector creates more than one initial migration
in a app, name all initial migrations "initial" rather than the opaque
"auto_<DATE>_<TIME>" name.

Initial migrations that have a descriptive name continue to use the
descriptive name.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/31703#comment:7>

Django

unread,
Jun 24, 2020, 2:05:02 AM6/24/20
to django-...@googlegroups.com
#31703: Name all initial migrations "NNNN_initial".
-------------------------------------+-------------------------------------
Reporter: Jon Dufresne | Owner: Jon
Type: | Dufresne
Cleanup/optimization | Status: assigned

Component: Migrations | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Mariusz Felisiak <felisiak.mariusz@…>):

In [changeset:"01195c4a83cf237f4417be94e1a44aef9762b1c2" 01195c4a]:
{{{
#!CommitTicketReference repository=""
revision="01195c4a83cf237f4417be94e1a44aef9762b1c2"
Refs #31703 -- Added Migration.suggest_name() test for initial migration
with multiple CreateModels.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/31703#comment:6>

Django

unread,
Jun 24, 2020, 2:05:03 AM6/24/20
to django-...@googlegroups.com
#31703: Name all initial migrations "NNNN_initial".
-------------------------------------+-------------------------------------
Reporter: Jon Dufresne | Owner: Jon
Type: | Dufresne
Cleanup/optimization | Status: assigned
Component: Migrations | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Mariusz Felisiak <felisiak.mariusz@…>):

In [changeset:"bce180dd05c425341261240fab1d2642e6d4bc65" bce180dd]:
{{{
#!CommitTicketReference repository=""
revision="bce180dd05c425341261240fab1d2642e6d4bc65"
Refs #31703 -- Moved MigrationAutodetector.suggest_name() to Migration.

Allows expanding the method to inspect additional attributes of the
migration instance. For example, the Migration.initial attribute.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/31703#comment:5>

Django

unread,
Mar 12, 2021, 4:35:22 AM3/12/21
to django-...@googlegroups.com
#31703: Name all initial migrations "NNNN_initial".
-------------------------------------+-------------------------------------
Reporter: Jon Dufresne | Owner: Jon
Type: | Dufresne
Cleanup/optimization | Status: closed
Component: Migrations | Version: dev
Severity: Normal | Resolution: fixed

Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Mariusz Felisiak <felisiak.mariusz@…>):

In [changeset:"b1cb923883829b8e2d3d550ba125e574979d8230" b1cb9238]:
{{{
#!CommitTicketReference repository=""
revision="b1cb923883829b8e2d3d550ba125e574979d8230"
Refs #31516, Refs #31703 -- Made makemigrations always name initial
migrations "initial".
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/31703#comment:8>

Reply all
Reply to author
Forward
0 new messages