[Django] #20010: Tests for CaptureQueriesContext fail under Oracle
Django
---------------------------------------------+------------------------
Reporter: aaugustin | Owner: nobody
Type: Bug | Status: new
Component: Testing framework | Version: master
Severity: Release blocker | Keywords:
Triage Stage: Accepted | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
---------------------------------------------+------------------------
http://ci.djangoproject.com/job/Django%20Oracle/lastCompletedBuild/database=oracle,python=python2.7/testReport/test_utils.tests/CaptureQueriesContextManagerTests/
These tests were introduced in 952ba5237ea62e7647cdd5214b1df79c0e7cea38.
They rely on query parameters being listed in
`connection._last_executed_query`, which doesn't appear to be true under
Oracle.
Two solutions:
- change the tests for `CaptureQueriesContext`
- change `_last_executed_query` to be more like SQLite
--
Ticket URL: <https://code.djangoproject.com/ticket/20010>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
Reporter: aaugustin | Owner: nobody
Type: Bug | Status: new
Component: Testing framework | Version: master
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by apollo13):
* cc: apollo13 (added)
--
Ticket URL: <https://code.djangoproject.com/ticket/20010#comment:1>
Django
Reporter: aaugustin | Owner: charettes
Type: Bug | Status: assigned
Component: Testing framework | Version: master
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by charettes):
* owner: nobody => charettes
* status: new => assigned
Comment:
I guess I should fix my own mess. I think I'll favor the behave-more-like-
SQLite approach.
--
Ticket URL: <https://code.djangoproject.com/ticket/20010#comment:2>
Django
Reporter: aaugustin | Owner: charettes
Type: Bug | Status: assigned
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Comment (by charettes):
Added a patch I can't test.
--
Ticket URL: <https://code.djangoproject.com/ticket/20010#comment:3>
Django
Reporter: aaugustin | Owner: charettes
Type: Bug | Status: assigned
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by charettes):
* has_patch: 0 => 1
--
Ticket URL: <https://code.djangoproject.com/ticket/20010#comment:4>
Django
Reporter: aaugustin | Owner: charettes
Type: Bug | Status: assigned
Keywords: | Triage Stage: Ready for
Has patch: 1 | checkin
Needs tests: 0 | Needs documentation: 0
Easy pickings: 0 | Patch needs improvement: 0
| UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by aaugustin):
* stage: Accepted => Ready for checkin
Comment:
Tests pass with this patch under Oracle.
Do you think it's useful to add a line in the "backwards incompatible
changes" section of the release notes?
--
Ticket URL: <https://code.djangoproject.com/ticket/20010#comment:5>
Django
Reporter: aaugustin | Owner: charettes
Type: Bug | Status: assigned
Keywords: | Triage Stage: Ready for
Has patch: 1 | checkin
Needs tests: 0 | Needs documentation: 0
| UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by charettes):
That can't hurt, I'll adjust the patch.
--
Ticket URL: <https://code.djangoproject.com/ticket/20010#comment:6>
Django
Reporter: aaugustin | Owner: charettes
Type: Bug | Status: assigned
Keywords: | Triage Stage: Ready for
Has patch: 1 | checkin
Needs tests: 0 | Needs documentation: 0
Easy pickings: 0 | Patch needs improvement: 0
| UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by charettes):
Wondering if it's worth it, the change to SQLite3 wasn't documented AFAIK
6605ac331a9e03fa41c301d122c5727c0d98b970.
--
Ticket URL: <https://code.djangoproject.com/ticket/20010#comment:7>
Django
Reporter: aaugustin | Owner: charettes
Type: Bug | Status: assigned
Keywords: | Triage Stage: Ready for
Has patch: 1 | checkin
Needs tests: 0 | Needs documentation: 0
Easy pickings: 0 | Patch needs improvement: 0
| UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by aaugustin):
It's your call!
--
Ticket URL: <https://code.djangoproject.com/ticket/20010#comment:8>
Django
Reporter: aaugustin | Owner: charettes
Component: Testing framework | Version: master
Keywords: | Triage Stage: Ready for
Has patch: 1 | checkin
Needs tests: 0 | Needs documentation: 0
| UI/UX: 0
-------------------------------------+-------------------------------------
* status: assigned => closed
* resolution: => fixed
Comment:
In [changeset:"bc7a10299f7ad7f468fa78d5990b7b545d4d599d"]:
{{{
#!CommitTicketReference repository=""
revision="bc7a10299f7ad7f468fa78d5990b7b545d4d599d"
Fixed #20010 -- Make sure `last_executed_query` contains it's associated
parameters on Oracle.
Also removed some unused imports.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/20010#comment:9>
Django
Reporter: Aymeric Augustin | Owner: Simon
| Charette
Type: Bug | Status: closed
Component: Testing framework | Version: master
Keywords: | Triage Stage: Ready for
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Comment (by GitHub <noreply@…>):
In [changeset:"79065b55a70cd220820a260a1c54851b7be0615a" 79065b5]:
{{{
#!CommitTicketReference repository=""
revision="79065b55a70cd220820a260a1c54851b7be0615a"
Refs #20010 -- Unified DatabaseOperations.last_executed_query() on Oracle
with other db backends.
Thanks Simon Charette for the review.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/20010#comment:10>