[Django] #20510: Form field's label should be unicode
Django
------------------------------------+-----------------------------
Reporter: akaariai | Owner: nobody
Type: Bug | Status: new
Component: Forms | Version: 1.6-alpha-1
Severity: Normal | Keywords:
Triage Stage: Accepted | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
------------------------------------+-----------------------------
Form field's label should always be converted to unicode when using Python
2, even if it is defined as non-unicode string. The conversion is done in
1.5, but not in 1.6-alpha-1. See
https://github.com/akaariai/django/commit/88595c900225357756f9d3a6d19be871cd2e5584
and
https://github.com/akaariai/django/commit/398d32277f08b20327c5f9955644dfeffe8cae0e
for master and stable/1.5.x test cases.
--
Ticket URL: <https://code.djangoproject.com/ticket/20510>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
Reporter: akaariai | Owner: nobody
Type: Bug | Status: new
Component: Forms | Version: 1.6-alpha-1
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by bmispelon):
* cc: bmispelon@… (added)
Comment:
Looks like this was intended behavior, introduced by
066bf42675040abd7b1a42e5559890e5f9881058.
--
Ticket URL: <https://code.djangoproject.com/ticket/20510#comment:1>
Django
Reporter: akaariai | Owner: nobody
Type: Bug | Status: new
Component: Forms | Version: 1.6-alpha-1
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by claudep):
* has_patch: 0 => 1
Comment:
Just attached one way to solve this (failing loudly).
--
Ticket URL: <https://code.djangoproject.com/ticket/20510#comment:2>
Django
Reporter: akaariai | Owner: nobody
Type: Bug | Status: new
Component: Forms | Version: 1.6-alpha-1
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Comment (by akaariai):
I just don't see what is gained by not doing the conversion in field's
init. Django allows mixing unicode and str in a lot of places, so why
removing that ability from this place only is a good idea? I can see what
is gained by consistent use of unicode strings everywhere in Django, but
that isn't gained by the original commit.
Still, I don't feel too strongly about this, so if nobody else complains
about this then I don't see a need to act on this ticket.
--
Ticket URL: <https://code.djangoproject.com/ticket/20510#comment:3>
Django
Reporter: akaariai | Owner: nobody
Type: Bug | Status: closed
Component: Forms | Version: 1.6-alpha-1
Severity: Normal | Resolution: invalid
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by akaariai):
* status: new => closed
* resolution: => invalid
Comment:
Nobody seems to be complaining, so closing this.
--
Ticket URL: <https://code.djangoproject.com/ticket/20510#comment:4>