Re: [Django] #35007: Add a formatter for CSS and JS

[Django]

#35007: Add a formatter for CSS and JS
-------------------------------------+-------------------------------------
Reporter: Tom Carrick | Owner: Tom
Type: | Carrick
Cleanup/optimization | Status: assigned
Component: Core (Other) | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Tom Carrick):

I made some changes to the description and summary to make this tool-
agnostic as there are discussions around using other tools, particularly
Biome, which I would like to draft a PR for soon.
--
Ticket URL: <https://code.djangoproject.com/ticket/35007#comment:7>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

[Django]

#35007: Add a formatter for CSS and JS
-------------------------------------+-------------------------------------
Reporter: Tom Carrick | Owner: Tom
Type: | Carrick
Cleanup/optimization | Status: assigned
Component: Core (Other) | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Tom Carrick):

I had another look into this today. Before trying Biome I'd like to wait
for 2.0, it will make some things easier and it would be nice to not add a
formatter and then not long after need to migrate to a new version.
--
Ticket URL: <https://code.djangoproject.com/ticket/35007#comment:8>

[Django]

#35007: Add a formatter for CSS and JS
-------------------------------------+-------------------------------------
Reporter: Tom Carrick | Owner: Tom
Type: | Carrick
Cleanup/optimization | Status: assigned
Component: Core (Other) | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by JaeHyuckSa):

* cc: JaeHyuckSa (added)

Comment:

Replying to [comment:8 Tom Carrick]:

> I had another look into this today. Before trying Biome I'd like to wait
for 2.0, it will make some things easier and it would be nice to not add a
formatter and then not long after need to migrate to a new version.

Just a quick reminder, Tom — Biome is up to 2.2.2 now; might be a good
time to give it a try.
--
Ticket URL: <https://code.djangoproject.com/ticket/35007#comment:9>

[Django]

#35007: Add a formatter for CSS and JS
-------------------------------------+-------------------------------------
Reporter: Tom Carrick | Owner: Tom
Type: | Carrick
Cleanup/optimization | Status: assigned
Component: Core (Other) | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted

Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Tom Carrick):

* has_patch: 0 => 1

--
Ticket URL: <https://code.djangoproject.com/ticket/35007#comment:10>

[Django]

#35007: Add a formatter for CSS and JS
-------------------------------------+-------------------------------------
Reporter: Tom Carrick | Owner: Tom
Type: | Carrick
Cleanup/optimization | Status: assigned
Component: Core (Other) | Version: dev
Severity: Normal | Resolution:

Keywords: | Triage Stage: Ready for
| checkin

Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Jacob Walls):

* stage: Accepted => Ready for checkin

--
Ticket URL: <https://code.djangoproject.com/ticket/35007#comment:11>

[Django]

#35007: Add a formatter for CSS and JS
-------------------------------------+-------------------------------------
Reporter: Tom Carrick | Owner: Tom
Type: | Carrick
Cleanup/optimization | Status: assigned
Component: Core (Other) | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Jacob Walls <jacobtylerwalls@…>):

In [changeset:"4a6f797e480ff918cad7a93a331e48b45df091dc" 4a6f797e]:
{{{#!CommitTicketReference repository=""
revision="4a6f797e480ff918cad7a93a331e48b45df091dc"
Refs #35007 -- Added biome to lint and format CSS files.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/35007#comment:12>

[Django]

#35007: Add a formatter for CSS and JS
-------------------------------------+-------------------------------------
Reporter: Tom Carrick | Owner: Tom
Type: | Carrick
Cleanup/optimization | Status: assigned
Component: Core (Other) | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Ready for
| checkin

Has patch: 0 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Jacob Walls):

* has_patch: 1 => 0

--
Ticket URL: <https://code.djangoproject.com/ticket/35007#comment:13>

[Django]

#35007: Add a formatter for CSS and JS
-------------------------------------+-------------------------------------
Reporter: Tom Carrick | Owner: Tom
Type: | Carrick
Cleanup/optimization | Status: assigned
Component: Core (Other) | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Jacob Walls <jacobtylerwalls@…>):

In [changeset:"1b0d46f715849de53563aaf6912b4ded7d61641d" 1b0d46f]:
{{{#!CommitTicketReference repository=""
revision="1b0d46f715849de53563aaf6912b4ded7d61641d"
Refs #35007 -- Ignored CSS formatting changes in git blame.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/35007#comment:14>

[Django]

#35007: Add a formatter for CSS and JS
-------------------------------------+-------------------------------------
Reporter: Tom Carrick | Owner: Tom
Type: | Carrick
Cleanup/optimization | Status: assigned
Component: Core (Other) | Version: dev
Severity: Normal | Resolution:

Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Tom Carrick):

* has_patch: 0 => 1

* stage: Ready for checkin => Accepted

--
Ticket URL: <https://code.djangoproject.com/ticket/35007#comment:15>

[Django]

#35007: Add a formatter for CSS and JS
-------------------------------------+-------------------------------------
Reporter: Tom Carrick | Owner: Tom
Type: | Carrick
Cleanup/optimization | Status: assigned
Component: Core (Other) | Version: dev
Severity: Normal | Resolution:

Keywords: | Triage Stage: Ready for
| checkin

Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Jacob Walls):

* stage: Accepted => Ready for checkin

--
Ticket URL: <https://code.djangoproject.com/ticket/35007#comment:16>

[Django]

#35007: Add a formatter for CSS and JS
-------------------------------------+-------------------------------------
Reporter: Tom Carrick | Owner: Tom
Type: | Carrick
Cleanup/optimization | Status: assigned
Component: Core (Other) | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Jacob Walls):

Dropping `eslint` allows dropping the messy workaround in
d29852ae725f673843c46085bb51cbc740d374d7 to allow pre-commit hooks for all
contributors to work without having to install node modules.
--
Ticket URL: <https://code.djangoproject.com/ticket/35007#comment:17>

[Django]

#35007: Add a formatter for CSS and JS
-------------------------------------+-------------------------------------
Reporter: Tom Carrick | Owner: Tom
Type: | Carrick

Cleanup/optimization | Status: closed

Component: Core (Other) | Version: dev

Severity: Normal | Resolution: fixed

Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Jacob Walls <jacobtylerwalls@…>):

* resolution: => fixed
* status: assigned => closed

Comment:

In [changeset:"290fefe6f8e47c2f35a9d857749c1e5166d9288b" 290fefe6]:
{{{#!CommitTicketReference repository=""
revision="290fefe6f8e47c2f35a9d857749c1e5166d9288b"
Fixed #35007 -- Replaced ESLint with Biome for JavaScript linting and
formatting.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/35007#comment:18>

[Django]

#35007: Add a formatter for CSS and JS
-------------------------------------+-------------------------------------
Reporter: Tom Carrick | Owner: Tom
Type: | Carrick
Cleanup/optimization | Status: closed
Component: Core (Other) | Version: dev
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Jacob Walls <jacobtylerwalls@…>):

In [changeset:"47789e3a2b471995ed753c87ce69ffbaa59c0601" 47789e3a]:
{{{#!CommitTicketReference repository=""
revision="47789e3a2b471995ed753c87ce69ffbaa59c0601"
Refs #35007 -- Removed eslint disable in a test.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/35007#comment:19>

[Django]

#35007: Add a formatter for CSS and JS
-------------------------------------+-------------------------------------
Reporter: Tom Carrick | Owner: Tom
Type: | Carrick
Cleanup/optimization | Status: closed
Component: Core (Other) | Version: dev
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Jacob Walls <jacobtylerwalls@…>):

In [changeset:"d3ccbde03447a615b14dafc1352fa1f4d77a9f5e" d3ccbde0]:
{{{#!CommitTicketReference repository=""
revision="d3ccbde03447a615b14dafc1352fa1f4d77a9f5e"
Refs #35007 -- Ignored JS formatting changes in git blame.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/35007#comment:20>

[Django]

#35007: Add a formatter for CSS and JS
-------------------------------------+-------------------------------------
Reporter: Tom Carrick | Owner: Tom
Type: | Carrick
Cleanup/optimization | Status: closed
Component: Core (Other) | Version: dev
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Jacob Walls <jacobtylerwalls@…>):

In [changeset:"017d7f6f12e597e6179de7ffdf330a52c2b22053" 017d7f6]:
{{{#!CommitTicketReference repository=""
revision="017d7f6f12e597e6179de7ffdf330a52c2b22053"
Refs #35007 -- Pinned exact biome version.

Avoid drift against the following in biome.json:
"$schema": "https://biomejs.dev/schemas/2.4.12/schema.json"
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/35007#comment:21>