[Django] #31556: Remove useless (and inefficient) listcomp in the poll tutorial
Django
------------------------------------------------+------------------------
Reporter: yahya-abou-imran | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: Documentation | Version: 3.0
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
------------------------------------------------+------------------------
`output = ', '.join([q.question_text for q in latest_question_list])`
This is not needed since a long time.
--
Ticket URL: <https://code.djangoproject.com/ticket/31556>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
Reporter: Alexandre Poitevin | Owner: nobody
Type: | Status: new
Cleanup/optimization |
Component: Documentation | Version: 3.0
Severity: Normal | Resolution:
Keywords: | Triage Stage:
| Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Comment (by Sergey Fedoseev):
Could you elaborate on its uselessness?
--
Ticket URL: <https://code.djangoproject.com/ticket/31556#comment:1>
Django
Reporter: Alexandre Poitevin | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: Documentation | Version: 3.0
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Simon Charette):
* stage: Unreviewed => Accepted
Comment:
The materialization of the list is not required as `str.join` accepts an
`Iterator[str]`.
`', '.join(q.question_text for q in latest_question_list)`
--
Ticket URL: <https://code.djangoproject.com/ticket/31556#comment:2>
Django
Reporter: Alexandre Poitevin | Owner: nobody
Type: Cleanup/optimization | Status: closed
Component: Documentation | Version: 3.0
Severity: Normal | Resolution: wontfix
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Nick Pope):
* status: new => closed
* resolution: => wontfix
Comment:
This has come up before and was rejected… A list comprehension is
preferable here as `str.join()` converts to list internally anyway. It is
better performance to provide a list up front.
- https://stackoverflow.com/questions/9060653/list-comprehension-without-
in-python/9061024#9061024
- https://github.com/adamchainz/flake8-comprehensions/issues/156
--
Ticket URL: <https://code.djangoproject.com/ticket/31556#comment:3>