[Django] #22993: Drop skipIfCustomUser decorator
Django
------------------------------------------------+------------------------
Reporter: timo | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: contrib.auth | Version: master
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
------------------------------------------------+------------------------
With the test discovery changes in 1.6, the tests for `django.contrib`
apps are no longer run as part of user's project. For this reason I
believe we no longer need to decorate tests in `contrib.auth` with
`@skipIfCustomUser`.
--
Ticket URL: <https://code.djangoproject.com/ticket/22993>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
-------------------------------------+-------------------------------------
Reporter: timo | Owner: nobody
Type: | Status: new
Cleanup/optimization | Version: master
Component: contrib.auth | Resolution:
Severity: Normal | Triage Stage:
Keywords: | Someday/Maybe
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by timo):
* stage: Unreviewed => Someday/Maybe
Comment:
[https://groups.google.com/d/topic/django-
developers/ihRZYIcfwVo/discussion django-developers] thread. Consensus
seems to be that we shouldn't drop it now because of projects that may
still be using the old test runner.
--
Ticket URL: <https://code.djangoproject.com/ticket/22993#comment:1>
Django
--------------------------------------+------------------------------------
Reporter: timo | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: contrib.auth | Version: master
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by MarkusH):
* stage: Someday/Maybe => Accepted
Comment:
Can we still deprecate it in 1.8? That way developers can use it through
the LTS version and only need to upgrade to the next LTS after 1.8 and we
can get rid of it in 2.0. If deprecation time for 1.8 is already over,
let's do it for 1.9. Either way should give users plenty of time to update
their test suite.
--
Ticket URL: <https://code.djangoproject.com/ticket/22993#comment:2>
Django
--------------------------------------+------------------------------------
Type: Cleanup/optimization | Status: new
Component: contrib.auth | Version: master
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Comment (by timgraham):
I'm not quite understanding your argument for why it would be advantageous
to deprecate for 1.8. I think 1.9 is fine.
--
Ticket URL: <https://code.djangoproject.com/ticket/22993#comment:3>
Django
--------------------------------------+------------------------------------
Type: Cleanup/optimization | Status: new
Component: contrib.auth | Version: master
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Comment (by claudep):
Django's auth tests no longer use that decorator. Is the decorator still
useful for reusable apps developers (then this bug can be closed)? Or do
we want to remove the decorator from `contrib.auth` (it is currently
documented)?
--
Ticket URL: <https://code.djangoproject.com/ticket/22993#comment:4>
Django
--------------------------------------+------------------------------------
Type: Cleanup/optimization | Status: new
Component: contrib.auth | Version: master
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Comment (by timgraham):
I don't know of any apps that ship tests that are designed to run as part
of your project which would be the reason for the decorator. If we remove
it from Django (after deprecation since it's documented) It's easiest
enough to copy it into your project if you need it.
--
Ticket URL: <https://code.djangoproject.com/ticket/22993#comment:5>
Django
--------------------------------------+------------------------------------
Type: Cleanup/optimization | Status: new
Component: contrib.auth | Version: master
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
--------------------------------------+------------------------------------
Changes (by claudep):
* easy: 0 => 1
--
Ticket URL: <https://code.djangoproject.com/ticket/22993#comment:6>
Django
-------------------------------------+-------------------------------------
Type: | Status: assigned
Cleanup/optimization |
Component: contrib.auth | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
-------------------------------------+-------------------------------------
Changes (by chrisjluc):
* owner: nobody => chrisjluc
* status: new => assigned
--
Ticket URL: <https://code.djangoproject.com/ticket/22993#comment:7>
Django
-------------------------------------+-------------------------------------
Reporter: timo | Owner: chrisjluc
Type: | Status: assigned
Cleanup/optimization |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
-------------------------------------+-------------------------------------
Changes (by chrisjluc):
* stage: Accepted => Ready for checkin
--
Ticket URL: <https://code.djangoproject.com/ticket/22993#comment:8>
Django
-------------------------------------+-------------------------------------
Reporter: timo | Owner: chrisjluc
Type: | Status: assigned
Cleanup/optimization |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
-------------------------------------+-------------------------------------
* has_patch: 0 => 1
* stage: Ready for checkin => Accepted
Comment:
Hi Chris, the `Ready for checkin` flag is only set when someone else has
reviewed your patch. Just set the `Has patch` flag when your pull request
is ready.
--
Ticket URL: <https://code.djangoproject.com/ticket/22993#comment:9>
Django
-------------------------------------+-------------------------------------
Reporter: timo | Owner: chrisjluc
Cleanup/optimization |
Component: contrib.auth | Version: master
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
-------------------------------------+-------------------------------------
* status: assigned => closed
* resolution: => fixed
Comment:
In [changeset:"e37d52bd5eb98e6ddf61b766720583481d18bc2b" e37d52b]:
{{{
#!CommitTicketReference repository=""
revision="e37d52bd5eb98e6ddf61b766720583481d18bc2b"
Fixed #22993 -- Deprecated skipIfCustomUser decorator
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/22993#comment:10>
Django
-------------------------------------+-------------------------------------
Type: | Status: closed
Cleanup/optimization |
Component: contrib.auth | Version: master
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
-------------------------------------+-------------------------------------
Comment (by Tim Graham <timograham@…>):
In [changeset:"e90c745afdcf89bc3416c9cb2d4a06dfacb2a250" e90c745]:
{{{
#!CommitTicketReference repository=""
revision="e90c745afdcf89bc3416c9cb2d4a06dfacb2a250"
Refs #22993 -- Removed skipIfCustomUser per deprecation timeline.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/22993#comment:11>