Re: [Django] #35449: SplitArrayField doesn't validate properly with remove_trailing_nulls=True

[Django]

#35449: SplitArrayField doesn't validate properly with remove_trailing_nulls=True
-------------------------------------+-------------------------------------
Reporter: Matthijs | Owner: Jae Hyuck
| Sa
Type: Bug | Status: assigned
Component: contrib.postgres | Version: 4.2
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Jae Hyuck Sa ):

* owner: (none) => Jae Hyuck Sa
* status: new => assigned

--
Ticket URL: <https://code.djangoproject.com/ticket/35449#comment:2>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

[Django]

#35449: SplitArrayField doesn't validate properly with remove_trailing_nulls=True
-------------------------------------+-------------------------------------
Reporter: Matthijs | Owner: Jae Hyuck
| Sa
Type: Bug | Status: assigned
Component: contrib.postgres | Version: 4.2
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted

Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Jae Hyuck Sa ):

* has_patch: 0 => 1

--
Ticket URL: <https://code.djangoproject.com/ticket/35449#comment:3>

[Django]

#35449: SplitArrayField doesn't validate properly with remove_trailing_nulls=True
-------------------------------------+-------------------------------------
Reporter: Matthijs | Owner: Jae Hyuck
| Sa
Type: Bug | Status: assigned
Component: contrib.postgres | Version: 4.2
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 1

Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Sarah Boyce):

* needs_better_patch: 0 => 1

--
Ticket URL: <https://code.djangoproject.com/ticket/35449#comment:4>

[Django]

#35449: SplitArrayField doesn't validate properly with remove_trailing_nulls=True

----------------------------------+------------------------------------
Reporter: Matthijs | Owner: (none)
Type: Bug | Status: new

Component: contrib.postgres | Version: 4.2
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0

----------------------------------+------------------------------------

Changes (by Jae Hyuck Sa ):

* owner: Jae Hyuck Sa => (none)
* status: assigned => new

--
Ticket URL: <https://code.djangoproject.com/ticket/35449#comment:5>

[Django]

#35449: SplitArrayField doesn't validate properly with remove_trailing_nulls=True

----------------------------------+-------------------------------------
Reporter: Matthijs | Owner: Calvin Vu
Type: Bug | Status: assigned

Component: contrib.postgres | Version: 4.2
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0

----------------------------------+-------------------------------------
Changes (by Calvin Vu):

* owner: (none) => Calvin Vu

* status: new => assigned

--
Ticket URL: <https://code.djangoproject.com/ticket/35449#comment:6>

[Django]

#35449: SplitArrayField doesn't validate properly with remove_trailing_nulls=True
----------------------------------+-------------------------------------
Reporter: Matthijs | Owner: Calvin Vu
Type: Bug | Status: assigned
Component: contrib.postgres | Version: 4.2
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
----------------------------------+-------------------------------------

Comment (by Calvin Vu):

When I include Sarah's test in test_array.py and run:

{{{
python runtests.py postgres_tests.test_array
}}}

The test passes, does this mean that the bug has been resolved?
--
Ticket URL: <https://code.djangoproject.com/ticket/35449#comment:7>

[Django]

#35449: SplitArrayField doesn't validate properly with remove_trailing_nulls=True
----------------------------------+-------------------------------------
Reporter: Matthijs | Owner: Calvin Vu
Type: Bug | Status: assigned
Component: contrib.postgres | Version: 4.2
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
----------------------------------+-------------------------------------

Changes (by Calvin Vu):

* cc: Calvin Vu (added)

--
Ticket URL: <https://code.djangoproject.com/ticket/35449#comment:8>

[Django]

#35449: SplitArrayField doesn't validate properly with remove_trailing_nulls=True
----------------------------------+-------------------------------------
Reporter: Matthijs | Owner: Calvin Vu
Type: Bug | Status: assigned
Component: contrib.postgres | Version: 4.2
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
----------------------------------+-------------------------------------

Comment (by Calvin Vu):

Replying to [comment:7 Calvin Vu]:
> When I include Sarah's test in test_array.py and run the tests with

>
> {{{
> python runtests.py postgres_tests.test_array
> }}}
>
> The test passes, does this mean that the bug has been resolved?

Nevermind, ignore this
--
Ticket URL: <https://code.djangoproject.com/ticket/35449#comment:9>

[Django]

#35449: SplitArrayField doesn't validate properly with remove_trailing_nulls=True
----------------------------------+-------------------------------------
Reporter: Matthijs | Owner: Calvin Vu
Type: Bug | Status: assigned
Component: contrib.postgres | Version: 4.2
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0
----------------------------------+-------------------------------------

Changes (by Jacob Walls):

* needs_better_patch: 1 => 0

Comment:

[https://github.com/django/django/pull/18613 new PR]
--
Ticket URL: <https://code.djangoproject.com/ticket/35449#comment:10>

[Django]

#35449: SplitArrayField doesn't validate properly with remove_trailing_nulls=True
----------------------------------+-------------------------------------
Reporter: Matthijs | Owner: Calvin Vu
Type: Bug | Status: assigned
Component: contrib.postgres | Version: 4.2
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 1

Easy pickings: 0 | UI/UX: 0
----------------------------------+-------------------------------------

Changes (by Sarah Boyce):

* needs_better_patch: 0 => 1

--
Ticket URL: <https://code.djangoproject.com/ticket/35449#comment:11>

[Django]

#35449: SplitArrayField doesn't validate properly with remove_trailing_nulls=True

-------------------------------------+-------------------------------------

Reporter: Matthijs | Owner: Calvin Vu
Type: Bug | Status: assigned
Component: contrib.postgres | Version: 4.2
Severity: Normal | Resolution:

Keywords: | Triage Stage: Ready for
| checkin

Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0

-------------------------------------+-------------------------------------
Changes (by Sarah Boyce):

* needs_better_patch: 1 => 0
* stage: Accepted => Ready for checkin

--
Ticket URL: <https://code.djangoproject.com/ticket/35449#comment:12>

[Django]

#35449: SplitArrayField doesn't validate properly with remove_trailing_nulls=True
-------------------------------------+-------------------------------------
Reporter: Matthijs | Owner: Calvin Vu

Type: Bug | Status: closed
Component: contrib.postgres | Version: 4.2
Severity: Normal | Resolution: fixed

Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Sarah Boyce <42296566+sarahboyce@…>):

* resolution: => fixed
* status: assigned => closed

Comment:

In [changeset:"a417c0efb4b37fe9f59d7b982b2ecf276bf2e306" a417c0e]:
{{{#!CommitTicketReference repository=""
revision="a417c0efb4b37fe9f59d7b982b2ecf276bf2e306"
Fixed #35449 -- Fixed validation of array items in SplitArrayField when
remove_trailing_nulls=True.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/35449#comment:13>