[Django] #33058: Use DiscoverRunner's logger for logging when running checks

[Django]

#33058: Use DiscoverRunner's logger for logging when running checks
-------------------------------------+-------------------------------------
Reporter: Chris | Owner: Chris Jerdonek
Jerdonek |
Type: | Status: assigned
Cleanup/optimization |
Component: Testing | Version: dev
framework |
Severity: Normal | Keywords:
Triage Stage: | Has patch: 0
Unreviewed |
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
-------------------------------------+-------------------------------------
Currently, when a logger is passed to `DiscoverRunner`, there is at least
one case where `DiscoverRunner`'s logger isn't used for logging log-like
messages. This is when `DiscoverRunner` runs the `check` command (code
[https://github.com/django/django/blob/55cf9e93b5e5bdf19bedeb1d900ee8a83f8489fb/django/test/runner.py#L847
here]) and displays a message like the "System check identified no issues
...."

While there is some overlap with ticket #21429 (which is about logging for
''all'' commands), I think this ticket can be kept separate because it can
be done independently, and in particular either before or after that
ticket is complete.

I do have at least one idea of how this ticket can be addressed pretty
simply, and in a way that would help make tangible forward progress on
#21429. I can add a comment to that ticket explaining the approach in
order to keep followers of that ticket in the loop.

--
Ticket URL: <https://code.djangoproject.com/ticket/33058>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

[Django]

#33058: Use DiscoverRunner's logger for logging when running checks
-------------------------------------+-------------------------------------

Reporter: Chris Jerdonek | Owner: Chris
Type: | Jerdonek
Cleanup/optimization | Status: assigned
Component: Testing framework | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Mariusz Felisiak):

* stage: Unreviewed => Accepted

Comment:

> I do have at least one idea of how this ticket can be addressed pretty

simply, ...

Sounds good, I'd be happy to review the patch.

--
Ticket URL: <https://code.djangoproject.com/ticket/33058#comment:1>

[Django]

#33058: Use DiscoverRunner's logger for logging when running checks

--------------------------------------+------------------------------------
Reporter: Chris Jerdonek | Owner: (none)
Type: Cleanup/optimization | Status: new

Component: Testing framework | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted

Has patch: 0 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0

--------------------------------------+------------------------------------
Changes (by Mariusz Felisiak):

* owner: Chris Jerdonek => (none)
* status: assigned => new

--
Ticket URL: <https://code.djangoproject.com/ticket/33058#comment:2>

[Django]

#33058: Use DiscoverRunner's logger for logging when running checks

--------------------------------------+------------------------------------
Reporter: Chris Jerdonek | Owner: (none)
Type: Cleanup/optimization | Status: new
Component: Testing framework | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted

Has patch: 0 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0

--------------------------------------+------------------------------------
Changes (by Ülgen Sarıkavak):

* cc: Ülgen Sarıkavak (added)

--
Ticket URL: <https://code.djangoproject.com/ticket/33058#comment:3>

[Django]

#33058: Use DiscoverRunner's logger for logging when running checks

--------------------------------------+------------------------------------
Reporter: Chris Jerdonek | Owner: (none)
Type: Cleanup/optimization | Status: new
Component: Testing framework | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted

Has patch: 0 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0

--------------------------------------+------------------------------------
Comment (by Ahmed Ibrahim):

What pops in mind is to allow call_command to use external loggers via
params, this may also help the code that uses stdout directly
--
Ticket URL: <https://code.djangoproject.com/ticket/33058#comment:4>

[Django]

#33058: Use DiscoverRunner's logger for logging when running checks
-------------------------------------+-------------------------------------

Reporter: Chris Jerdonek | Owner: pranavh03
Type: | Status: assigned
Cleanup/optimization |

Component: Testing framework | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted

Has patch: 0 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by pranavh03):

* owner: (none) => pranavh03
* status: new => assigned

--
Ticket URL: <https://code.djangoproject.com/ticket/33058#comment:5>

[Django]

#33058: Use DiscoverRunner's logger for logging when running checks
-------------------------------------+-------------------------------------

Reporter: Chris Jerdonek | Owner: pranavh03
Type: | Status: assigned
Cleanup/optimization |

Component: Testing framework | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted

Has patch: 0 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by pranavh03):

Hi team just made a fix : https://github.com/django/django/pull/19975
please check it out
--
Ticket URL: <https://code.djangoproject.com/ticket/33058#comment:6>

[Django]

#33058: Use DiscoverRunner's logger for logging when running checks
-------------------------------------+-------------------------------------

Reporter: Chris Jerdonek | Owner: pranavh03
Type: | Status: assigned
Cleanup/optimization |

Component: Testing framework | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted

Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Jacob Walls):

* has_patch: 0 => 1

--
Ticket URL: <https://code.djangoproject.com/ticket/33058#comment:7>

[Django]

#33058: Use DiscoverRunner's logger for logging when running checks
-------------------------------------+-------------------------------------

Reporter: Chris Jerdonek | Owner: pranavh03
Type: | Status: assigned
Cleanup/optimization |

Component: Testing framework | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted

Has patch: 1 | Needs documentation: 0
Needs tests: 1 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Jacob Walls):

* needs_tests: 0 => 1

--
Ticket URL: <https://code.djangoproject.com/ticket/33058#comment:8>