Re: [Django] #14681: Uploaded files should not set mode to None

[Django]

#14681: Uploaded files should not set mode to None
-------------------------------------+-------------------------------------
Reporter: bgreenlee | Owner: bretth
Type: Bug | Status: assigned
Milestone: | Component: File
Version: SVN | uploads/storage
Resolution: | Severity: Normal
Triage Stage: Accepted | Keywords: sprintdec2010
Needs documentation: 0 | Has patch: 1
Patch needs improvement: 1 | Needs tests: 0
| Easy pickings: 0
-------------------------------------+-------------------------------------
Changes (by patchhammer):

* needs_better_patch: 0 => 1
* easy: => 0

Comment:

revisedtest.diff fails to apply cleanly on to trunk

--
Ticket URL: <http://code.djangoproject.com/ticket/14681#comment:3>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

[Django]

#14681: Uploaded files should not set mode to None
-------------------------------------+-------------------------------------
Reporter: bgreenlee | Owner: bretth
Type: Bug | Status: assigned
Milestone: | Component: File
Version: SVN | uploads/storage
Resolution: | Severity: Normal
Triage Stage: Accepted | Keywords: sprintdec2010
Needs documentation: 0 | Has patch: 1

Patch needs improvement: 0 | Needs tests: 0
| Easy pickings: 0
-------------------------------------+-------------------------------------
Changes (by dmclain):

* needs_better_patch: 1 => 0

--
Ticket URL: <http://code.djangoproject.com/ticket/14681#comment:4>

[Django]

#14681: Uploaded files should not set mode to None
-------------------------------------+-------------------------------------
Reporter: bgreenlee | Owner: bretth
Type: Bug | Status: assigned

Component: File | Version: master
uploads/storage | Resolution:
Severity: Normal | Triage Stage: Ready for
Keywords: sprintdec2010 | checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by moritzs):

* cc: moritz.sichert@… (added)
* stage: Accepted => Ready for checkin

--
Ticket URL: <https://code.djangoproject.com/ticket/14681#comment:6>

[Django]

#14681: Uploaded files should not set mode to None
-------------------------------------+-------------------------------------
Reporter: bgreenlee | Owner: bretth

Type: Bug | Status: closed
Component: File | Version: master
uploads/storage | Resolution: fixed

Severity: Normal | Triage Stage: Ready for
Keywords: sprintdec2010 | checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Claude Paroz <claude@…>):

* status: assigned => closed
* resolution: => fixed

Comment:

In [2626ea4a74d09642a50c3fb30944513b68dda289]:
{{{
#!CommitTicketReference repository=""
revision="2626ea4a74d09642a50c3fb30944513b68dda289"
Fixed #14681 -- Do not set mode to None on file-like objects.

gzip.GzipFile does not support files with mode set to None.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/14681#comment:7>