[Django] #36102: Some Translators comments are dissapearing from the po files

13 views
Skip to first unread message

Django

unread,
Jan 15, 2025, 5:10:57 PM1/15/25
to django-...@googlegroups.com
#36102: Some Translators comments are dissapearing from the po files
-------------------------------------+-------------------------------------
Reporter: Julien Palard | Type: Bug
Status: new | Component:
| contrib.humanize
Version: 5.1 | Severity: Normal
Keywords: i18n | Triage Stage:
| Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
cf. https://forum.djangoproject.com/t/xgettext-and-comments/37967/3

Since 9c19aff7c7561e3a82978a272ecdaad40dda5c00 a few translators comments
are no longer picked up by xgettext.

They just need to be moved one line down.
--
Ticket URL: <https://code.djangoproject.com/ticket/36102>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Jan 16, 2025, 2:19:35 AM1/16/25
to django-...@googlegroups.com
#36102: Some Translators comments are dissapearing from the po files
----------------------------------+------------------------------------
Reporter: Julien Palard | Owner: (none)
Type: Bug | Status: new
Component: contrib.humanize | Version: 5.1
Severity: Normal | Resolution:
Keywords: i18n | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
----------------------------------+------------------------------------
Changes (by Claude Paroz):

* has_patch: 0 => 1
* needs_better_patch: 0 => 1
* stage: Unreviewed => Accepted

--
Ticket URL: <https://code.djangoproject.com/ticket/36102#comment:1>

Django

unread,
Jan 16, 2025, 11:52:25 PM1/16/25
to django-...@googlegroups.com
#36102: Some Translators comments are dissapearing from the po files
-------------------------------------+-------------------------------------
Reporter: Julien Palard | Owner: Julien
| Palard
Type: Bug | Status: assigned
Component: contrib.humanize | Version: 5.1
Severity: Normal | Resolution:
Keywords: i18n | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by JaeHyuckSa):

* owner: (none) => Julien Palard
* status: new => assigned

--
Ticket URL: <https://code.djangoproject.com/ticket/36102#comment:2>

Django

unread,
Feb 9, 2025, 12:00:34 PM2/9/25
to django-...@googlegroups.com
#36102: Some Translators comments are dissapearing from the po files
-------------------------------------+-------------------------------------
Reporter: Julien Palard | Owner: Julien
| Palard
Type: Bug | Status: assigned
Component: contrib.humanize | Version: 5.1
Severity: Normal | Resolution:
Keywords: i18n | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Claude Paroz):

* needs_better_patch: 1 => 0
* stage: Accepted => Ready for checkin

--
Ticket URL: <https://code.djangoproject.com/ticket/36102#comment:3>

Django

unread,
Feb 14, 2025, 9:22:51 AM2/14/25
to django-...@googlegroups.com
#36102: Some Translators comments are dissapearing from the po files
-------------------------------------+-------------------------------------
Reporter: Julien Palard | Owner: Julien
| Palard
Type: Bug | Status: closed
Component: contrib.humanize | Version: 5.1
Severity: Normal | Resolution: fixed
Keywords: i18n | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Sarah Boyce <42296566+sarahboyce@…>):

* resolution: => fixed
* status: assigned => closed

Comment:

In [changeset:"6fcd0440aaa7601aa258d1c956eecfaedf72fbf4" 6fcd0440]:
{{{#!CommitTicketReference repository=""
revision="6fcd0440aaa7601aa258d1c956eecfaedf72fbf4"
Fixed #36102 -- Moved i18n comments directly above the translatable
string.

xgettext only extracts comment blocks if there is no program code between
the comment and the string that gets extracted. For details, see:
https://www.gnu.org/software/gettext/manual/html_node/xgettext-
Invocation.html#Operation-mode

Black formatting has been turned off in some places to ensure the
comments are not moved, which previously resulted in them being removed
from the po files when scripts/manage_translations.py was run.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/36102#comment:4>

Django

unread,
Feb 14, 2025, 9:24:23 AM2/14/25
to django-...@googlegroups.com
#36102: Some Translators comments are dissapearing from the po files
-------------------------------------+-------------------------------------
Reporter: Julien Palard | Owner: Julien
| Palard
Type: Bug | Status: closed
Component: contrib.humanize | Version: 5.1
Severity: Normal | Resolution: fixed
Keywords: i18n | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Sarah Boyce <42296566+sarahboyce@…>):

In [changeset:"e62301091de8c6da45ab4a9d09080ba88229d2d0" e623010]:
{{{#!CommitTicketReference repository=""
revision="e62301091de8c6da45ab4a9d09080ba88229d2d0"
[5.2.x] Fixed #36102 -- Moved i18n comments directly above the
translatable string.

xgettext only extracts comment blocks if there is no program code between
the comment and the string that gets extracted. For details, see:
https://www.gnu.org/software/gettext/manual/html_node/xgettext-
Invocation.html#Operation-mode

Black formatting has been turned off in some places to ensure the
comments are not moved, which previously resulted in them being removed
from the po files when scripts/manage_translations.py was run.

Backport of 6fcd0440aaa7601aa258d1c956eecfaedf72fbf4 from main.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/36102#comment:5>
Reply all
Reply to author
Forward
0 new messages