[Django] #28152: Change SetSerializer to serialize to set literals

5 views
Skip to first unread message

Django

unread,
Apr 28, 2017, 8:01:48 PM4/28/17
to django-...@googlegroups.com
#28152: Change SetSerializer to serialize to set literals
------------------------------------------------+------------------------
Reporter: Jon Dufresne | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: Migrations | Version: master
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
------------------------------------------------+------------------------
While looking for all code that could be converted to set literals and set
comprehension, it was noticed that the migration's `SetSerializer` does
not use set literals. If we're to convert all internal code to user set
literals, the auto generated code should follow the same convention.

Idea originally discussed in [https://github.com/django/django/pull/8432
PR].

--
Ticket URL: <https://code.djangoproject.com/ticket/28152>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Apr 28, 2017, 8:03:35 PM4/28/17
to django-...@googlegroups.com
#28152: Change SetSerializer to serialize to set literals
-------------------------------------+-------------------------------------
Reporter: Jon Dufresne | Owner: Jon
Type: | Dufresne
Cleanup/optimization | Status: assigned
Component: Migrations | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage:
| Unreviewed
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Jon Dufresne):

* status: new => assigned
* owner: nobody => Jon Dufresne
* has_patch: 0 => 1


Comment:

[https://github.com/django/django/pull/8436 PR]

--
Ticket URL: <https://code.djangoproject.com/ticket/28152#comment:1>

Django

unread,
May 15, 2017, 12:48:22 PM5/15/17
to django-...@googlegroups.com
#28152: Change SetSerializer to serialize to set literals
-------------------------------------+-------------------------------------
Reporter: Jon Dufresne | Owner: Jon
Type: | Dufresne
Cleanup/optimization | Status: assigned
Component: Migrations | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Tim Graham):

* stage: Unreviewed => Accepted


--
Ticket URL: <https://code.djangoproject.com/ticket/28152#comment:2>

Django

unread,
May 18, 2017, 9:33:58 AM5/18/17
to django-...@googlegroups.com
#28152: Change SetSerializer to serialize to set literals
-------------------------------------+-------------------------------------
Reporter: Jon Dufresne | Owner: Jon
Type: | Dufresne
Cleanup/optimization | Status: closed
Component: Migrations | Version: master
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Tim Graham <timograham@…>):

* status: assigned => closed
* resolution: => fixed


Comment:

In [changeset:"f599747fc802f1db6cd4394c33fc9afb8aac370b" f599747]:
{{{
#!CommitTicketReference repository=""
revision="f599747fc802f1db6cd4394c33fc9afb8aac370b"
Fixed #28152 -- Made migrations serialize sets as set literals rather than
set().
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/28152#comment:3>

Reply all
Reply to author
Forward
0 new messages