Re: [Django] #14656: Atom1Feed should write atom:published element
Django
-------------------------------------+-------------------------------------
Reporter: | Owner: nobody
ttencate@… | Status: new
Type: Bug | Component: contrib.syndication
Milestone: | Severity: Normal
Version: 1.2 | Keywords:
Resolution: | Has patch: 0
Triage Stage: Accepted | Needs tests: 0
Needs documentation: 0 | Easy pickings: 0
Patch needs improvement: 0 |
-------------------------------------+-------------------------------------
Changes (by floledermann):
* easy: => 0
Comment:
Btw. a hacky workaround is monkeypatching the method:
{{{
from django.utils.feedgenerator import Atom1Feed, rfc3339_date
# monkey patch buggy Atom implementation in Django
Atom1Feed._add_item_elements = Atom1Feed.add_item_elements
def atom1feed_add_item_elements_patched(self, handler, item, *args,
**kwargs):
if item['pubdate'] is not None:
handler.addQuickElement(u"published",
rfc3339_date(item['pubdate']).decode('utf-8'))
# include args, kwargs for future compatibility
self._add_item_elements(handler, item, *args, **kwargs)
Atom1Feed.add_item_elements = atom1feed_add_item_elements_patched
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/14656#comment:3>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
-------------------------------------+-------------------------------------
Reporter: | Owner: nobody
ttencate@… | Status: new
Type: Bug | Component: contrib.syndication
Milestone: | Severity: Normal
Version: 1.2 | Keywords:
Resolution: | Has patch: 0
Triage Stage: Accepted | Needs tests: 0
Needs documentation: 0 | Easy pickings: 0
Patch needs improvement: 0 |
-------------------------------------+-------------------------------------
Comment (by floledermann):
It turns out that Google Reader is in fact ignoring publication dates in
any format and always displays the date when an entry was first read:
http://groups.google.com/group/google-reader-
troubleshoot/browse_thread/thread/beba58f69bb364a0
So in fact this bug seems to be rather academic.
--
Ticket URL: <https://code.djangoproject.com/ticket/14656#comment:4>
Django
-------------------------------------+------------------------------------
Type: Bug | Status: new
Component: contrib.syndication | Version: 1.2
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+------------------------------------
Changes (by Deacalion):
* cc: Deacalion (added)
* has_patch: 0 => 1
* ui_ux: => 0
Comment:
I came across this last night. I've attached a Git patch, for version
1.3.1.
--
Ticket URL: <https://code.djangoproject.com/ticket/14656#comment:5>
Django
-------------------------------------+------------------------------------
Reporter: ttencate@… | Owner: nobody
Type: Bug | Status: new
Component: contrib.syndication | Version: 1.2
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+------------------------------------
* needs_tests: 0 => 1
Comment:
This needs tests in order to get it committed.
--
Ticket URL: <https://code.djangoproject.com/ticket/14656#comment:6>
Django
-------------------------------------+------------------------------------
Reporter: ttencate@… | Owner: nobody
Type: Bug | Status: new
Component: contrib.syndication | Version: 1.2
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 1 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+------------------------------------
Comment (by Deacalion):
Completely forgot about this one, I'll add tests this evening.
--
Ticket URL: <https://code.djangoproject.com/ticket/14656#comment:7>
Django
-------------------------------------+------------------------------------
Reporter: ttencate@… | Owner: nobody
Type: Bug | Status: new
Component: contrib.syndication | Version: 1.2
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 1 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+------------------------------------
Comment (by Deacalion):
Code, tests and a shred of documentation can be found here:
https://github.com/django/django/pull/1366
--
Ticket URL: <https://code.djangoproject.com/ticket/14656#comment:8>
Django
-------------------------------------+------------------------------------
Reporter: ttencate@… | Owner: nobody
Type: Bug | Status: new
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+------------------------------------
* version: 1.2 => master
* needs_tests: 1 => 0
--
Ticket URL: <https://code.djangoproject.com/ticket/14656#comment:9>
Django
Reporter: ttencate@… | Owner: Deacalion
Type: Bug | Status: assigned
Component: contrib.syndication | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Deacalion):
* owner: nobody => Deacalion
* status: new => assigned
--
Ticket URL: <https://code.djangoproject.com/ticket/14656#comment:10>
Django
-------------------------------------+-------------------------------------
Reporter: ttencate@… | Owner: Deacalion
Component: contrib.syndication | Version: master
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* status: assigned => closed
* resolution: => fixed
Comment:
In [changeset:"a269ea4fe0a9a7195f1bd8bf5d462f48c226d525"]:
{{{
#!CommitTicketReference repository=""
revision="a269ea4fe0a9a7195f1bd8bf5d462f48c226d525"
Fixed #14656 -- Added Atom1Feed `published` element
Some feed aggregators make use of the `published` element as well as
the `updated` element (within the Atom standard -- http://bit.ly/2YySb).
The standard allows for these two elements to be present in the same
entry. `Atom1Feed` had implemented the `updated` element which was
incorrectly taking the date from `pubdate`.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/14656#comment:11>