[Django] #31557: Use .assertTrue instead of .assertIs(..., True) in the unit testing section of the polls tutorial

9 views
Skip to first unread message

Django

unread,
May 10, 2020, 1:46:19 AM5/10/20
to django-...@googlegroups.com
#31557: Use .assertTrue instead of .assertIs(..., True) in the unit testing section
of the polls tutorial
------------------------------------------------+------------------------
Reporter: Alexandre Poitevin | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: Documentation | Version: 3.0
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
------------------------------------------------+------------------------
We find this is several places in this section 6.
Maybe it was written before this method was added to the TestCase class?

--
Ticket URL: <https://code.djangoproject.com/ticket/31557>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
May 10, 2020, 2:21:04 AM5/10/20
to django-...@googlegroups.com
#31557: Use .assertTrue instead of .assertIs(..., True) in the unit testing section
of the polls tutorial
-------------------------------------+-------------------------------------
Reporter: yahya-abou-imran | Owner: nobody
Type: | Status: new
Cleanup/optimization |
Component: Documentation | Version: 3.0
Severity: Normal | Resolution:

Keywords: | Triage Stage:
| Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Sergey Fedoseev):

See https://github.com/django/django/pull/6760#discussion_r66713822

--
Ticket URL: <https://code.djangoproject.com/ticket/31557#comment:1>

Django

unread,
May 10, 2020, 12:45:33 PM5/10/20
to django-...@googlegroups.com
#31557: Use .assertTrue instead of .assertIs(..., True) in the unit testing section
of the polls tutorial.
-------------------------------------+-------------------------------------

Reporter: Alexandre Poitevin | Owner: nobody
Type: | Status: closed
Cleanup/optimization |
Component: Documentation | Version: 3.0
Severity: Normal | Resolution: wontfix

Keywords: | Triage Stage:
| Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by felixxm):

* status: new => closed
* resolution: => wontfix


Comment:

Our [https://docs.djangoproject.com/en/3.0/internals/contributing/writing-
code/coding-style/#python-style Python style] describes why we prefer
`assertIs(..., True/False)`:

> Use `assertIs(…, True/False)` for testing boolean values, rather than
`assertTrue()` and `assertFalse()`, so you can check the actual boolean
value, not the truthiness of the expression.

--
Ticket URL: <https://code.djangoproject.com/ticket/31557#comment:2>

Reply all
Reply to author
Forward
0 new messages