[Django] #33457: Expanding local vars in technical 500 causes horizontal scrolling
Django
-------------------------------------+-------------------------------------
Reporter: Keryn | Owner: (none)
Knight |
Type: Bug | Status: new
Component: Error | Version: dev
reporting | Keywords: technical debug 500
Severity: Normal | UI
Triage Stage: | Has patch: 0
Unreviewed |
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
-------------------------------------+-------------------------------------
Whilst working on a little alpha project to [https://github.com/kezabelle
/django-technicalerrors provide alternate error pages], and comparing
output, I noticed that expanding the `Local vars` seems to ''always''
cause a horizontal scrollbar, at least at 1425x???? in Chrome.
As far as I can tell from checking out git tags, this seems to occur at
least back to 2.2 (???? that can't be right, but OK!), and before that I
start getting issues with code which has moved that my project doesn't
support, so ... it may go back further.
A cursory play around with my devtools suggests that the following fixes
it:
{{{
table.vars {
margin: 5px 10px 2px 40px;
width: auto;
}
}}}
Specifically:
- Restore the `width` to not be `100%` (which is currently applied to all
`table`) and use `auto` or `inherit` or `initial` instead.
- Add `10px` right margin so the table lines up vertically with it's
related context lines.
Attaching a gif which shows a slice of the issue.
--
Ticket URL: <https://code.djangoproject.com/ticket/33457>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
-------------------------------------+-------------------------------------
Type: Bug | Status: new
Component: Error reporting | Version: dev
Severity: Normal | Resolution:
Keywords: technical debug 500 | Triage Stage:
UI | Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* Attachment "te500-scroll.gif" added.
animated gif showing the table's end being off-screen, forcing an
horizontal scrollbar to appear when Local vars are toggled
Django
-------------------------------------+-------------------------------------
| Hrushikesh Vaidya
Type: Bug | Status: assigned
Component: Error reporting | Version: dev
Severity: Normal | Resolution:
Keywords: technical debug 500 | Triage Stage:
UI | Unreviewed
Needs tests: 0 | Patch needs improvement: 0
-------------------------------------+-------------------------------------
Changes (by Hrushikesh Vaidya):
* owner: (none) => Hrushikesh Vaidya
* status: new => assigned
* has_patch: 0 => 1
* ui_ux: 0 => 1
Comment:
[https://github.com/django/django/pull/15348 PR]
--
Ticket URL: <https://code.djangoproject.com/ticket/33457#comment:1>
Django
-------------------------------------+-------------------------------------
| Hrushikesh Vaidya
Type: Bug | Status: assigned
Component: Error reporting | Version: dev
Severity: Normal | Resolution:
UI |
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak):
* stage: Unreviewed => Accepted
Comment:
Thanks for the report.
--
Ticket URL: <https://code.djangoproject.com/ticket/33457#comment:2>
Django
-------------------------------------+-------------------------------------
| Hrushikesh Vaidya
Type: Bug | Status: assigned
Component: Error reporting | Version: dev
Severity: Normal | Resolution:
UI | checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak):
* stage: Accepted => Ready for checkin
--
Ticket URL: <https://code.djangoproject.com/ticket/33457#comment:3>
Django
-------------------------------------+-------------------------------------
| Hrushikesh Vaidya
Component: Error reporting | Version: dev
Keywords: technical debug 500 | Triage Stage: Ready for
UI | checkin
Needs tests: 0 | Patch needs improvement: 0
-------------------------------------+-------------------------------------
Changes (by GitHub <noreply@…>):
* status: assigned => closed
* resolution: => fixed
Comment:
In [changeset:"89d137f3be1685dfc2ce0968835c73667bffb0ba" 89d137f3]:
{{{
#!CommitTicketReference repository=""
revision="89d137f3be1685dfc2ce0968835c73667bffb0ba"
Fixed #33457 -- Fixed "Local vars" scrolling in technical 500 debug page.
Thanks Keryn Knight for the report and the initial patch.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/33457#comment:4>