[Django] #32397: django-admin start[project|app] doesn't send proper user agent header when HTTP(S) url is sent.
Django
HTTP(S) url is sent.
-------------------------------------+-------------------------------------
Reporter: rsp2k | Owner: rsp2k
Type: New | Status: assigned
feature |
Component: Core | Version: 3.1
(Management commands) |
Severity: Normal | Keywords:
Triage Stage: | Has patch: 1
Unreviewed |
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
-------------------------------------+-------------------------------------
By default, when fetching a remote template, django-admin
start[app|project] uses the default urllib User Agent which causes some
sites to block requests (namely gitlab, since they use cloudflare See
https://gitlab.com/gitlab-org/gitlab/-/issues/219669).
--
Ticket URL: <https://code.djangoproject.com/ticket/32397>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
HTTP(S) url is sent.
-------------------------------------+-------------------------------------
Reporter: rsp2k | Owner: rsp2k
Component: Core (Management | Version: 3.1
commands) |
Severity: Normal | Resolution:
Keywords: | Triage Stage:
| Unreviewed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* Attachment "add-user-agent-to-django-admin-templates.diff" added.
Django
HTTP(S) url is sent.
-------------------------------------+-------------------------------------
Reporter: rsp2k | Owner: rsp2k
Component: Core (Management | Version: 3.1
commands) |
Severity: Normal | Resolution:
Keywords: | Triage Stage:
| Unreviewed
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Old description:
> By default, when fetching a remote template, django-admin
> start[app|project] uses the default urllib User Agent which causes some
> sites to block requests (namely gitlab, since they use cloudflare See
> https://gitlab.com/gitlab-org/gitlab/-/issues/219669).
New description:
By default, when fetching a remote template, django-admin
start[app|project] uses the default urllib User Agent which causes some
sites to block requests (namely gitlab, since they use cloudflare See
https://gitlab.com/gitlab-org/gitlab/-/issues/219669).
This patch sets the 'User Agent' header to Django/DJANGO_VERSION.
--
--
Ticket URL: <https://code.djangoproject.com/ticket/32397#comment:1>
Django
HTTP(S) url is sent.
-------------------------------------+-------------------------------------
Reporter: rsp2k | Owner: rsp2k
Component: Core (Management | Version: 3.1
commands) |
Severity: Normal | Resolution:
Keywords: | Triage Stage:
| Unreviewed
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* Attachment "add-user-agent-to-django-admin-templates.diff" added.
Django
HTTP(S) url is sent.
-------------------------------------+-------------------------------------
Type: New feature | Status: new
Component: Core (Management | Version: 3.1
commands) |
Severity: Normal | Resolution:
Keywords: | Triage Stage:
| Unreviewed
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* owner: rsp2k => (none)
* status: assigned => new
--
Ticket URL: <https://code.djangoproject.com/ticket/32397#comment:2>
Django
HTTP(S) url is sent.
-------------------------------------+-------------------------------------
Type: | Status: closed
Cleanup/optimization |
Component: Core (Management | Version: 3.1
commands) |
Keywords: | Triage Stage:
| Unreviewed
Has patch: 1 | Needs documentation: 0
Needs tests: 1 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* status: new => closed
* type: New feature => Cleanup/optimization
* resolution: => needsinfo
* needs_tests: 0 => 1
Comment:
Hi rsp2k.
I'm inclined to accept this — no problem setting the User-Agent.
Initially though I'm going to close as `needsinfo` — that info being,
**are you up for finishing this**?
I see you removed your assignment, but the patch needs tests. Specifically
they could go in `django/tests/admin_scripts/tests.py` in the
`StartProject` and `StartApp` classes.
If so can you add the tests, [https://github.com/django/django/pulls open
a PR on GitHub], re-open the ticket, and assign yourself again?
Thanks.
--
Ticket URL: <https://code.djangoproject.com/ticket/32397#comment:3>
Django
HTTP(S) url is sent.
-------------------------------------+-------------------------------------
Type: | Status: new
Cleanup/optimization |
Component: Core (Management | Version: 3.1
commands) |
Severity: Normal | Resolution:
| Unreviewed
Has patch: 1 | Needs documentation: 0
Needs tests: 1 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* status: closed => new
* resolution: needsinfo =>
Comment:
Thank you for your reply. I am working on the tests now and will follow
the steps you outlined.
I took myself off the ticket because I thought it might not get routed
properly, my mistake. I'm reassigning it now.
--
Ticket URL: <https://code.djangoproject.com/ticket/32397#comment:4>
Django
HTTP(S) url is sent.
-------------------------------------+-------------------------------------
Reporter: rsp2k | Owner: rsp2k
Cleanup/optimization |
Component: Core (Management | Version: 3.1
commands) |
Severity: Normal | Resolution:
Keywords: | Triage Stage:
| Unreviewed
Needs tests: 1 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* owner: (none) => rsp2k
* status: new => assigned
--
Ticket URL: <https://code.djangoproject.com/ticket/32397#comment:5>
Django
HTTP(S) url is sent.
-------------------------------------+-------------------------------------
Reporter: rsp2k | Owner: rsp2k
Cleanup/optimization |
Component: Core (Management | Version: 3.1
commands) |
Severity: Normal | Resolution:
Has patch: 1 | Needs documentation: 0
Needs tests: 1 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* stage: Unreviewed => Accepted
Comment:
Super, thanks for the follow-up! Let's accept for review. Welcome aboard!
--
Ticket URL: <https://code.djangoproject.com/ticket/32397#comment:6>
Django
HTTP(S) url is sent.
-------------------------------------+-------------------------------------
Reporter: rsp2k | Owner: rsp2k
Cleanup/optimization |
Component: Core (Management | Version: 3.1
commands) |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* cc: Ad Timmering (added)
* needs_tests: 1 => 0
Comment:
Have taken the liberty of adding tests to rsp2k's patch in this
[https://github.com/django/django/pull/15111 PR].
Feels like there should be a cleaner way to get the UA from the request;
ideas very welcome.
--
Ticket URL: <https://code.djangoproject.com/ticket/32397#comment:7>
Django
HTTP(S) url is sent.
-------------------------------------+-------------------------------------
Reporter: rsp2k | Owner: rsp2k
Cleanup/optimization |
Component: Core (Management | Version: 3.1
commands) |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* needs_better_patch: 0 => 1
--
Ticket URL: <https://code.djangoproject.com/ticket/32397#comment:8>
Django
HTTP(S) url is sent.
-------------------------------------+-------------------------------------
Type: | Timmering
Cleanup/optimization | Status: assigned
Component: Core (Management | Version: 3.1
commands) |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* owner: rsp2k => Ad Timmering
* needs_better_patch: 1 => 0
Comment:
[https://github.com/django/django/pull/15111 PR] updated reflecting
feedback, and rebased to main.
--
Ticket URL: <https://code.djangoproject.com/ticket/32397#comment:9>
Django
HTTP(S) url is sent.
-------------------------------------+-------------------------------------
Type: | Timmering
Cleanup/optimization | Status: assigned
Component: Core (Management | Version: 3.1
commands) |
Severity: Normal | Resolution:
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* stage: Accepted => Ready for checkin
--
Ticket URL: <https://code.djangoproject.com/ticket/32397#comment:10>
Django
HTTP(S) url is sent.
-------------------------------------+-------------------------------------
Type: | Timmering
Component: Core (Management | Version: 3.1
commands) |
Keywords: | Triage Stage: Ready for
| checkin
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* status: assigned => closed
* resolution: => fixed
Comment:
In [changeset:"9a6e2df3a8f01ea761529bec48e5a8dc0ea9575b" 9a6e2df3]:
{{{
#!CommitTicketReference repository=""
revision="9a6e2df3a8f01ea761529bec48e5a8dc0ea9575b"
Fixed #32397 -- Made startapp/startproject management commands set User-
Agent.
This sets User-Agent to 'Django/<version>'.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/32397#comment:11>