Re: [Django] #36656: GZipMiddleware drops content from async streaming responses

[Django]

#36656: GZipMiddleware drops content from async streaming responses
-------------------------------+----------------------------------------
Reporter: Adam Johnson | Owner: Adam Johnson
Type: Bug | Status: assigned
Component: HTTP handling | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------+----------------------------------------
Comment (by AdityaJai@…):

I’d like to work on this issue. Can you assign it to me?
--
Ticket URL: <https://code.djangoproject.com/ticket/36656#comment:2>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

[Django]

#36656: GZipMiddleware drops content from async streaming responses
-------------------------------+----------------------------------------
Reporter: Adam Johnson | Owner: Adam Johnson
Type: Bug | Status: assigned
Component: HTTP handling | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------+----------------------------------------

Comment (by Natalia Bidart):

Replying to [comment:2 AdityaJai@…]:

> I’d like to work on this issue. Can you assign it to me?

This ticket already has an owner as per the ticket metadata so we should
give the owner some time to work on it.
--
Ticket URL: <https://code.djangoproject.com/ticket/36656#comment:3>

[Django]

#36656: GZipMiddleware drops content from async streaming responses
-------------------------------+----------------------------------------
Reporter: Adam Johnson | Owner: Adam Johnson

Type: Bug | Status: closed

Component: HTTP handling | Version: dev

Severity: Normal | Resolution: duplicate
Keywords: gzip flush | Triage Stage: Unreviewed

Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------+----------------------------------------

Changes (by Natalia Bidart):

* cc: Carlton Gibson (added)
* keywords: => gzip flush
* resolution: => duplicate
* status: assigned => closed

Comment:

Hey Adam, thank you for your ticket! My uneducated eye sees this as a dupe
of #36293. What do you think? (Feel free to reopen if you disagree.)
--
Ticket URL: <https://code.djangoproject.com/ticket/36656#comment:4>

[Django]

#36656: GZipMiddleware drops content from async streaming responses
-------------------------------+----------------------------------------
Reporter: Adam Johnson | Owner: Adam Johnson

Type: Bug | Status: new

Component: HTTP handling | Version: dev
Severity: Normal | Resolution:

Keywords: gzip flush | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------+----------------------------------------

Changes (by Adam Johnson):

* resolution: duplicate =>
* status: closed => new

Comment:

I think you meant to close #36655, not this one.
--
Ticket URL: <https://code.djangoproject.com/ticket/36656#comment:5>

[Django]

#36656: GZipMiddleware drops content from async streaming responses
-------------------------------+----------------------------------------
Reporter: Adam Johnson | Owner: Adam Johnson
Type: Bug | Status: new
Component: HTTP handling | Version: dev
Severity: Normal | Resolution:
Keywords: gzip flush | Triage Stage: Unreviewed

Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------+----------------------------------------
Changes (by Adam Johnson):

* has_patch: 0 => 1

--
Ticket URL: <https://code.djangoproject.com/ticket/36656#comment:6>

[Django]

#36656: GZipMiddleware drops content from async streaming responses
-------------------------------+----------------------------------------
Reporter: Adam Johnson | Owner: Adam Johnson
Type: Bug | Status: new
Component: HTTP handling | Version: dev
Severity: Normal | Resolution:
Keywords: gzip flush | Triage Stage: Unreviewed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------+----------------------------------------

Comment (by Natalia Bidart):

Replying to [comment:5 Adam Johnson]:

> I think you meant to close #36655, not this one.

Yes! Sorry I had the two opened at the same time and I mixed them up.
--
Ticket URL: <https://code.djangoproject.com/ticket/36656#comment:7>

[Django]

#36656: GZipMiddleware drops content from async streaming responses
-------------------------------+----------------------------------------
Reporter: Adam Johnson | Owner: Adam Johnson
Type: Bug | Status: new
Component: HTTP handling | Version: dev
Severity: Normal | Resolution:

Keywords: gzip async | Triage Stage: Accepted

Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------+----------------------------------------

Changes (by Jacob Walls):

* keywords: gzip flush => gzip async
* stage: Unreviewed => Accepted

--
Ticket URL: <https://code.djangoproject.com/ticket/36656#comment:8>

[Django]

#36656: GZipMiddleware drops content from async streaming responses

-------------------------------------+-------------------------------------

Reporter: Adam Johnson | Owner: Adam
| Johnson
Type: Bug | Status: new
Component: HTTP handling | Version: dev
Severity: Normal | Resolution:

Keywords: gzip async | Triage Stage: Ready for
| checkin

Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0

-------------------------------------+-------------------------------------
Changes (by Jacob Walls):

* stage: Accepted => Ready for checkin

--
Ticket URL: <https://code.djangoproject.com/ticket/36656#comment:9>

[Django]

#36656: GZipMiddleware drops content from async streaming responses
-------------------------------------+-------------------------------------
Reporter: Adam Johnson | Owner: Adam
| Johnson

Type: Bug | Status: closed

Component: HTTP handling | Version: dev

Severity: Normal | Resolution: fixed

Keywords: gzip async | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Jacob Walls <jacobtylerwalls@…>):

* resolution: => fixed
* status: new => closed

Comment:

In [changeset:"a0323a0c44135c28134672e6e633e5f4a7a68d5d" a0323a0c]:
{{{#!CommitTicketReference repository=""
revision="a0323a0c44135c28134672e6e633e5f4a7a68d5d"
Fixed #36656 -- Avoided truncating async streaming responses in
GZipMiddleware.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/36656#comment:10>

[Django]

#36656: GZipMiddleware drops content from async streaming responses
-------------------------------------+-------------------------------------
Reporter: Adam Johnson | Owner: Adam
| Johnson
Type: Bug | Status: closed
Component: HTTP handling | Version: dev
Severity: Normal | Resolution: fixed
Keywords: gzip async | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Jacob Walls <jacobtylerwalls@…>):

In [changeset:"bb4fcf5f67e6a39440bb1271450319604a755f2e" bb4fcf5f]:
{{{#!CommitTicketReference repository=""
revision="bb4fcf5f67e6a39440bb1271450319604a755f2e"
[6.0.x] Fixed #36656 -- Avoided truncating async streaming responses in
GZipMiddleware.

Backport of a0323a0c44135c28134672e6e633e5f4a7a68d5d from main.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/36656#comment:11>