[Django] #27368: mail.tests.SMTPBackendTests.test_server_login generates ResourceWarning unclosed socket
Django
unclosed socket
------------------------------------------------+------------------------
Reporter: Jon Dufresne | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: Testing framework | Version: master
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
------------------------------------------------+------------------------
{{{
$ python -Wall runtests.py --failfast
mail.tests.SMTPBackendTests.test_server_login
Testing against Django installed in '/home/jon/devel/django/django' with
up to 4 processes
Creating test database for alias 'default'...
Creating test database for alias 'other'...
/usr/lib64/python3.5/socket.py:646: ResourceWarning: unclosed
<socket.socket fd=4, family=AddressFamily.AF_INET,
type=SocketKind.SOCK_STREAM, proto=6, laddr=('127.0.0.1', 50632),
raddr=('127.0.0.1', 36317)>
self._sock = None
.
----------------------------------------------------------------------
Ran 1 test in 0.048s
OK
Destroying test database for alias 'default'...
Destroying test database for alias 'other'...
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/27368>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
unclosed socket
Reporter: Jon Dufresne | Owner: nobody
Cleanup/optimization |
Component: Testing framework | Version: master
Keywords: | Triage Stage:
| Unreviewed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Jon Dufresne):
* has_patch: 0 => 1
Comment:
[https://github.com/django/django/pull/7413 PR]
--
Ticket URL: <https://code.djangoproject.com/ticket/27368#comment:1>
Django
unclosed socket
Reporter: Jon Dufresne | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: Testing framework | Version: master
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Claude Paroz):
* stage: Unreviewed => Accepted
--
Ticket URL: <https://code.djangoproject.com/ticket/27368#comment:2>
Django
unclosed socket
Reporter: Jon Dufresne | Owner: nobody
Cleanup/optimization |
Component: Testing framework | Version: master
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Claude Paroz):
* stage: Accepted => Ready for checkin
--
Ticket URL: <https://code.djangoproject.com/ticket/27368#comment:3>
Django
unclosed socket
Reporter: Jon Dufresne | Owner: nobody
Cleanup/optimization |
Component: Testing framework | Version: master
Keywords: | Triage Stage: Ready for
| checkin
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by GitHub <noreply@…>):
* status: new => closed
* resolution: => fixed
Comment:
In [changeset:"9b9c8c4a81ab67d1bc392b6fd9cc17e0b844f7ff" 9b9c8c4]:
{{{
#!CommitTicketReference repository=""
revision="9b9c8c4a81ab67d1bc392b6fd9cc17e0b844f7ff"
Fixed #27368 -- Modifed BaseEmailBackend.__enter__() to close the
connection if an exception occurs.
Fixes unclosed socket ResourceWarning in mail test.
Thanks Claude Paroz for the review.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/27368#comment:4>