[Django] #28941: testserver invokes runserver shutdown_message option, which does not exist

[Django]

#28941: testserver invokes runserver shutdown_message option, which does not exist
---------------------------------------------+----------------------------
Reporter: peter-rci | Owner: nobody
Type: Bug | Status: new
Component: Testing framework | Version: 2.0
Severity: Normal | Keywords: testserver
Triage Stage: Unreviewed | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 1
UI/UX: 0 |
---------------------------------------------+----------------------------
I believe the testserver command cannot be used at all in Django 2.0. Here
are lines 47-54 from testserver.py:

{{{
call_command(
'runserver',
addrport=options['addrport'],
shutdown_message=shutdown_message,
use_reloader=False,
use_ipv6=options['use_ipv6'],
use_threading=use_threading
)
}}}

Removing the `shutdown_message=shutdown_message` line fixes the problem.

--
Ticket URL: <https://code.djangoproject.com/ticket/28941>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

[Django]

#28941: testserver crashes due to runserver shutdown_message option
-----------------------------------+--------------------------------------
Reporter: peter-rci | Owner: Tim Graham
Type: Bug | Status: assigned

Component: Testing framework | Version: 2.0

Severity: Release blocker | Resolution:
Keywords: testserver | Triage Stage: Accepted

Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0

-----------------------------------+--------------------------------------
Changes (by Tim Graham):

* status: new => assigned
* owner: nobody => Tim Graham
* severity: Normal => Release blocker
* stage: Unreviewed => Accepted

--
Ticket URL: <https://code.djangoproject.com/ticket/28941#comment:1>

[Django]

#28941: testserver crashes due to runserver shutdown_message option
-----------------------------------+--------------------------------------
Reporter: peter-rci | Owner: Tim Graham
Type: Bug | Status: assigned

Component: Testing framework | Version: 2.0

Severity: Release blocker | Resolution:
Keywords: testserver | Triage Stage: Accepted

Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0

-----------------------------------+--------------------------------------
Changes (by Tim Graham):

* has_patch: 0 => 1

Comment:

[https://github.com/django/django/pull/9482 PR]

--
Ticket URL: <https://code.djangoproject.com/ticket/28941#comment:2>

[Django]

#28941: testserver crashes due to runserver shutdown_message option
-----------------------------------+--------------------------------------
Reporter: peter-rci | Owner: Tim Graham

Type: Bug | Status: closed

Component: Testing framework | Version: 2.0

Severity: Release blocker | Resolution: fixed

Keywords: testserver | Triage Stage: Accepted

Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0

-----------------------------------+--------------------------------------
Changes (by Tim Graham <timograham@…>):

* status: assigned => closed
* resolution: => fixed

Comment:

In [changeset:"e7b804c060a1f9fc089cf935801aa85b09db062b" e7b804c0]:
{{{
#!CommitTicketReference repository=""
revision="e7b804c060a1f9fc089cf935801aa85b09db062b"
Fixed #28941 -- Fixed crash in testserver command startup.

Regression in 2b09e4c88e96cb03b29f5a6b0e4838ab4271e631.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/28941#comment:3>

[Django]

#28941: testserver crashes due to runserver shutdown_message option
-----------------------------------+--------------------------------------
Reporter: peter-rci | Owner: Tim Graham
Type: Bug | Status: closed

Component: Testing framework | Version: 2.0

Severity: Release blocker | Resolution: fixed
Keywords: testserver | Triage Stage: Accepted

Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0

-----------------------------------+--------------------------------------

Comment (by Tim Graham <timograham@…>):

In [changeset:"6f86d8bc69aa88a82e1291b4f545184fd9572d9d" 6f86d8bc]:
{{{
#!CommitTicketReference repository=""
revision="6f86d8bc69aa88a82e1291b4f545184fd9572d9d"
[2.0.x] Fixed #28941 -- Fixed crash in testserver command startup.

Regression in 2b09e4c88e96cb03b29f5a6b0e4838ab4271e631.

Backport of e7b804c060a1f9fc089cf935801aa85b09db062b from master
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/28941#comment:4>