[Django] #17262: Refactor the implementations of tzinfo classes

Django

unread,

Nov 19, 2011, 1:20:52 PM11/19/11

to django-...@googlegroups.com

#17262: Refactor the implementations of tzinfo classes
-------------------------------------+-------------------------------------
Reporter: aaugustin | Owner: aaugustin
Type: | Status: new
Cleanup/optimization | Version:
Component: Core | Keywords:
(Other) | Has patch: 0
Severity: Normal | Needs tests: 0
Triage Stage: | Easy pickings: 0
Unreviewed |
Needs documentation: 0 |
Patch needs improvement: 0 |
UI/UX: 0 |
-------------------------------------+-------------------------------------
Since the merge of the time zone support branch, `django.utils.tzinfo` and
`django.utils.timezone` provide subtly different implementations of a
tzinfo subclass representing local time.

The reason is explained at the bottom of [http://groups.google.com/group
/django-developers/msg/c05b469e4335c6cc this message]. In short, the
former is used for display and focuses on robustness; the latter is used
for time zone support and focuses on correctness.

I think `django.utils.tzinfo` should be refactored and merged into
`django.utils.timezone`, but that's probably not doable in a totally
backwards-compatible fashion.

--
Ticket URL: <https://code.djangoproject.com/ticket/17262>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,

Nov 19, 2011, 11:51:57 PM11/19/11

to django-...@googlegroups.com

#17262: Refactor the implementations of tzinfo classes
-------------------------------------+-------------------------------------
Reporter: aaugustin | Owner: aaugustin
Type: | Status: new
Cleanup/optimization | Version:

Component: Core (Other) | Resolution:
Severity: Normal | Triage Stage: Accepted
Keywords: timezone tzinfo | Needs documentation: 0
Has patch: 0 | Patch needs improvement: 0
Needs tests: 0 | UI/UX: 0
Easy pickings: 0 |
-------------------------------------+-------------------------------------
Changes (by ptone):

* keywords: => timezone tzinfo
* stage: Unreviewed => Accepted

--
Ticket URL: <https://code.djangoproject.com/ticket/17262#comment:1>

Django

unread,

Aug 20, 2012, 3:50:38 AM8/20/12

to django-...@googlegroups.com

#17262: Refactor the implementations of tzinfo classes
-------------------------------------+-------------------------------------
Reporter: aaugustin | Owner: aaugustin
Type: | Status: new
Cleanup/optimization | Version:

Comment (by aaugustin):

Django

unread,

Sep 8, 2013, 6:03:28 AM9/8/13

to django-...@googlegroups.com

#17262: Refactor the implementations of tzinfo classes
-------------------------------------+-------------------------------------
Reporter: aaugustin | Owner: aaugustin
Type: | Status: new

Cleanup/optimization | Version: 1.4
Component: Utilities | Resolution:

Severity: Normal | Triage Stage: Accepted
Keywords: timezone tzinfo | Needs documentation: 0

Has patch: 1 | Patch needs improvement: 0

Needs tests: 0 | UI/UX: 0
Easy pickings: 0 |
-------------------------------------+-------------------------------------

Changes (by aaugustin):

* has_patch: 0 => 1
* version: => 1.4

Comment:

Pull request: https://github.com/django/django/pull/1601

Discussion: https://groups.google.com/d/msg/django-
developers/zwQju7hbG78/jxpGZfdlxlcJ

I'll merge this in a few days, unless the discussion on django-developers
reveals some good reasons not to.

--
Ticket URL: <https://code.djangoproject.com/ticket/17262#comment:4>

Django

unread,

Sep 9, 2013, 4:34:36 PM9/9/13

to django-...@googlegroups.com

#17262: Refactor the implementations of tzinfo classes
-------------------------------------+-------------------------------------
Reporter: aaugustin | Owner: aaugustin

Type: | Status: closed
Cleanup/optimization | Version: 1.4
Component: Utilities | Resolution: fixed

Changes (by Aymeric Augustin <aymeric.augustin@…>):

* status: new => closed
* resolution: => fixed

Comment:

In [changeset:"ec2778b445546f624d3b3a1f2118e751b10bb2e7"]:
{{{
#!CommitTicketReference repository=""
revision="ec2778b445546f624d3b3a1f2118e751b10bb2e7"
Fixed #17262 -- Refactored tzinfo implementations.

This commit deprecates django.utils.tzinfo in favor of the more recent
django.utils.timezone which was introduced when Django gained support
for time zones.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/17262#comment:5>

Django

unread,

Sep 9, 2013, 4:34:36 PM9/9/13

to django-...@googlegroups.com

#17262: Refactor the implementations of tzinfo classes
-------------------------------------+-------------------------------------
Reporter: aaugustin | Owner: aaugustin

Comment (by Aymeric Augustin <aymeric.augustin@…>):

In [changeset:"d9413d33b2a8371731a92289123683cf6f440290"]:
{{{
#!CommitTicketReference repository=""
revision="d9413d33b2a8371731a92289123683cf6f440290"
Refactored code and tests that relied on django.utils.tzinfo.

Refs #17262.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/17262#comment:6>

Django

unread,

Jan 17, 2015, 9:45:02 AM1/17/15

to django-...@googlegroups.com

#17262: Refactor the implementations of tzinfo classes
-------------------------------------+-------------------------------------
Reporter: aaugustin | Owner: aaugustin

Comment (by Tim Graham <timograham@…>):

In [changeset:"1b0365ad34151f266fe3faecb4edf31a51a8642c"]:
{{{
#!CommitTicketReference repository=""
revision="1b0365ad34151f266fe3faecb4edf31a51a8642c"
Removed django.utils.tzinfo per deprecation timeline; refs #17262.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/17262#comment:7>

Reply all

Reply to author

Forward