[Django] #31490: Increase length of contrib.sites domain field
Django
-----------------------------------------+------------------------
Reporter: thenewguy | Owner: nobody
Type: Uncategorized | Status: new
Component: contrib.sites | Version: 3.0
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
-----------------------------------------+------------------------
The domain value is currently limited to 100 characters. This seems like
an arbitrary limit. Apps served via cloud providers like AWS can approach
this limit pretty easily when accessed via their public path -> for
example I just checked a few apps available through AWS load balancers and
their FQDN was around 90 characters.
It isn't unfeasible for deeply nested domains to hit this limit either.
Since many apps rely on the site record, these sites are dangerously close
to not working with Django.
It would be helpful here to increase the size to the max portable length
of a charfield at 255 characters.
--
Ticket URL: <https://code.djangoproject.com/ticket/31490>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
Reporter: thenewguy | Owner: nobody
Type: Uncategorized | Status: closed
Component: contrib.sites | Version: 3.0
Severity: Normal | Resolution: needsinfo
Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Carlton Gibson):
* status: new => closed
* resolution: => needsinfo
Comment:
Hi.
I'm not entirely convinced here.
* Seems like even the most horrible names leave some headroom by your
report. Is it even necessary?
* Surely most folks use DNS? What's the % of folks using such names as
site records? Not sure we need to impose a change on everyone for that. A
migration isn't zero cost.
* Why 255? That seems a LOT of extra headroom, given that we're not
hitting the limit already, and in other cases we favored "human values"
over values such as 255.
It's the kind of change that needs consensus on the DevelopersMailingList.
--
Ticket URL: <https://code.djangoproject.com/ticket/31490#comment:1>