[Django] #36805: Use `None` as default value for `from_email` in `send_mail`-function

2 views
Skip to first unread message

Django

unread,
9:59 AM (8 hours ago) 9:59 AM
to django-...@googlegroups.com
#36805: Use `None` as default value for `from_email` in `send_mail`-function
-------------------------------+-----------------------------------------
Reporter: Adrian Bürger | Type: Uncategorized
Status: new | Component: Core (Mail)
Version: 4.2 | Severity: Normal
Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------+-----------------------------------------
The docstring of the function `send_mail` states that

"If from_email is None, use the DEFAULT_FROM_EMAIL setting."

`from_email` is a required argument which would explicitly need to be set
to `None` so that `DEFAULT_FROM_EMAIL` is applied. However, other inputs
of this function such as `auth_user` and `auth_password` which have a
settings-value applied if they are `None`, are given a default value of
`None`. Therefore, I am not a sure whether this behavior is intended;
personally, I would expect `from_email` to have a default value of `None`.
Otherwise, users get an unexpected `TypeError: send_mail() missing 1
required positional argument: 'from_email'`.

I see this in Django 4.2 but still also in the current main branch on
GitHub.

Thank you for your consideration and for your work.
--
Ticket URL: <https://code.djangoproject.com/ticket/36805>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
2:16 PM (3 hours ago) 2:16 PM
to django-...@googlegroups.com
#36805: Use `None` as default value for `from_email` in `send_mail`-function
-------------------------------+--------------------------------------
Reporter: Adrian Bürger | Owner: (none)
Type: Uncategorized | Status: closed
Component: Core (Mail) | Version: 4.2
Severity: Normal | Resolution: wontfix
Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------+--------------------------------------
Changes (by Jacob Walls):

* resolution: => wontfix
* status: new => closed

Comment:

Thanks for the ticket. If the proposal is to change the signature, it's
not worth breaking backward compatibility if it's not causing any issues.
--
Ticket URL: <https://code.djangoproject.com/ticket/36805#comment:1>
Reply all
Reply to author
Forward
0 new messages