[Django] #25916: New Feature: Add lastmod support to sitemapindex

7 views
Skip to first unread message

Django

unread,
Dec 10, 2015, 7:20:56 PM12/10/15
to django-...@googlegroups.com
#25916: New Feature: Add lastmod support to sitemapindex
----------------------------------+-----------------------------
Reporter: mgd020 | Owner:
Type: Uncategorized | Status: new
Component: contrib.sitemaps | Version: master
Severity: Normal | Keywords: sitemap lastmod
Triage Stage: Unreviewed | Has patch: 0
Easy pickings: 0 | UI/UX: 0
----------------------------------+-----------------------------
Add support for `<lastmod>` for generated `<sitemapindex>`

--
Ticket URL: <https://code.djangoproject.com/ticket/25916>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Dec 10, 2015, 7:21:14 PM12/10/15
to django-...@googlegroups.com
#25916: New Feature: Add lastmod support to sitemapindex
----------------------------------+--------------------------------------
Reporter: mgd020 | Owner: mgd020
Type: Uncategorized | Status: assigned
Component: contrib.sitemaps | Version: master
Severity: Normal | Resolution:

Keywords: sitemap lastmod | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0
----------------------------------+--------------------------------------
Changes (by mgd020):

* owner: => mgd020
* needs_better_patch: => 0
* status: new => assigned
* needs_tests: => 0
* needs_docs: => 0


--
Ticket URL: <https://code.djangoproject.com/ticket/25916#comment:1>

Django

unread,
Dec 10, 2015, 7:25:55 PM12/10/15
to django-...@googlegroups.com
#25916: New Feature: Add lastmod support to sitemapindex
----------------------------------+--------------------------------------
Reporter: mgd020 | Owner: mgd020
Type: New feature | Status: assigned
Component: contrib.sitemaps | Version: master
Severity: Normal | Resolution:

Keywords: sitemap lastmod | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0
----------------------------------+--------------------------------------
Changes (by mgd020):

* type: Uncategorized => New feature


--
Ticket URL: <https://code.djangoproject.com/ticket/25916#comment:2>

Django

unread,
Dec 10, 2015, 11:15:01 PM12/10/15
to django-...@googlegroups.com
#25916: New Feature: Add lastmod support to sitemapindex
----------------------------------+--------------------------------------
Reporter: mgd020 | Owner: mgd020
Type: New feature | Status: assigned
Component: contrib.sitemaps | Version: master
Severity: Normal | Resolution:

Keywords: sitemap lastmod | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0
----------------------------------+--------------------------------------
Description changed by mgd020:

Old description:

> Add support for `<lastmod>` for generated `<sitemapindex>`

New description:

Add support for `<lastmod>` for generated `<sitemapindex>`

https://github.com/django/django/pull/5814

--

--
Ticket URL: <https://code.djangoproject.com/ticket/25916#comment:3>

Django

unread,
Dec 12, 2015, 9:48:35 AM12/12/15
to django-...@googlegroups.com
#25916: Add lastmod support to sitemapindex
----------------------------------+------------------------------------

Reporter: mgd020 | Owner: mgd020
Type: New feature | Status: assigned
Component: contrib.sitemaps | Version: master
Severity: Normal | Resolution:
Keywords: sitemap lastmod | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0
----------------------------------+------------------------------------
Changes (by timgraham):

* has_patch: 0 => 1
* stage: Unreviewed => Accepted


--
Ticket URL: <https://code.djangoproject.com/ticket/25916#comment:4>

Django

unread,
Feb 3, 2016, 10:07:58 AM2/3/16
to django-...@googlegroups.com
#25916: Add lastmod support to sitemapindex
----------------------------------+------------------------------------
Reporter: mgd020 | Owner: mgd020
Type: New feature | Status: assigned
Component: contrib.sitemaps | Version: master

Severity: Normal | Resolution:
Keywords: sitemap lastmod | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1

Easy pickings: 0 | UI/UX: 0
----------------------------------+------------------------------------
Changes (by timgraham):

* needs_better_patch: 0 => 1


Comment:

Left comments for improvement on the pull request.

--
Ticket URL: <https://code.djangoproject.com/ticket/25916#comment:5>

Django

unread,
Feb 23, 2016, 7:21:00 PM2/23/16
to django-...@googlegroups.com
#25916: Add lastmod support to sitemapindex
----------------------------------+------------------------------------
Reporter: mgd020 | Owner: mgd020
Type: New feature | Status: assigned
Component: contrib.sitemaps | Version: master

Severity: Normal | Resolution:
Keywords: sitemap lastmod | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0
----------------------------------+------------------------------------
Changes (by timgraham):

* needs_better_patch: 1 => 0


--
Ticket URL: <https://code.djangoproject.com/ticket/25916#comment:6>

Django

unread,
Dec 29, 2020, 4:51:07 AM12/29/20
to django-...@googlegroups.com
#25916: Add lastmod support to sitemapindex
----------------------------------+---------------------------------------
Reporter: Matthew Downey | Owner: David Smith

Type: New feature | Status: assigned
Component: contrib.sitemaps | Version: master

Severity: Normal | Resolution:
Keywords: sitemap lastmod | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1

Easy pickings: 0 | UI/UX: 0
----------------------------------+---------------------------------------
Changes (by David Smith):

* owner: Matthew Downey => David Smith

Django

unread,
Mar 1, 2021, 4:02:44 PM3/1/21
to django-...@googlegroups.com
#25916: Add lastmod support to sitemapindex
----------------------------------+---------------------------------------
Reporter: Matthew Downey | Owner: David Smith
Type: New feature | Status: assigned
Component: contrib.sitemaps | Version: master

Severity: Normal | Resolution:
Keywords: sitemap lastmod | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0
----------------------------------+---------------------------------------
Changes (by David Smith):

* needs_better_patch: 1 => 0


Comment:

[https://github.com/django/django/pull/14068 PR]

--
Ticket URL: <https://code.djangoproject.com/ticket/25916#comment:7>

Django

unread,
Aug 25, 2021, 5:06:10 AM8/25/21
to django-...@googlegroups.com
#25916: Add lastmod support to sitemapindex
----------------------------------+---------------------------------------
Reporter: Matthew Downey | Owner: David Smith
Type: New feature | Status: assigned
Component: contrib.sitemaps | Version: dev

Severity: Normal | Resolution:
Keywords: sitemap lastmod | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 1
Needs tests: 0 | Patch needs improvement: 1

Easy pickings: 0 | UI/UX: 0
----------------------------------+---------------------------------------
Changes (by Carlton Gibson):

* needs_better_patch: 0 => 1

* needs_docs: 0 => 1


--
Ticket URL: <https://code.djangoproject.com/ticket/25916#comment:8>

Django

unread,
Sep 25, 2021, 3:04:50 AM9/25/21
to django-...@googlegroups.com
#25916: Add lastmod support to sitemapindex
----------------------------------+---------------------------------------
Reporter: Matthew Downey | Owner: David Smith
Type: New feature | Status: assigned
Component: contrib.sitemaps | Version: dev
Severity: Normal | Resolution:
Keywords: sitemap lastmod | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0
----------------------------------+---------------------------------------
Changes (by David Smith):

* needs_better_patch: 1 => 0

* needs_docs: 1 => 0


--
Ticket URL: <https://code.djangoproject.com/ticket/25916#comment:9>

Django

unread,
Sep 30, 2021, 5:02:30 AM9/30/21
to django-...@googlegroups.com
#25916: Add lastmod support to sitemapindex
----------------------------------+---------------------------------------
Reporter: Matthew Downey | Owner: David Smith
Type: New feature | Status: assigned
Component: contrib.sitemaps | Version: dev
Severity: Normal | Resolution:
Keywords: sitemap lastmod | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1

Easy pickings: 0 | UI/UX: 0
----------------------------------+---------------------------------------
Changes (by Carlton Gibson):

* needs_better_patch: 0 => 1


Comment:

A few minor tweaks remaining.

--
Ticket URL: <https://code.djangoproject.com/ticket/25916#comment:10>

Django

unread,
Oct 14, 2021, 2:13:39 AM10/14/21
to django-...@googlegroups.com
#25916: Add lastmod support to sitemapindex
----------------------------------+---------------------------------------
Reporter: Matthew Downey | Owner: David Smith
Type: New feature | Status: assigned
Component: contrib.sitemaps | Version: dev
Severity: Normal | Resolution:
Keywords: sitemap lastmod | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
----------------------------------+---------------------------------------

Comment (by Carlton Gibson <carlton@…>):

In [changeset:"f345c9fb3e6bcc1ad78fead35fc17eaf8133fed5" f345c9f]:
{{{
#!CommitTicketReference repository=""
revision="f345c9fb3e6bcc1ad78fead35fc17eaf8133fed5"
Refs #25916 -- Added tests for a callable lastmod on Sitemaps.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/25916#comment:11>

Django

unread,
Oct 17, 2021, 3:43:23 AM10/17/21
to django-...@googlegroups.com
#25916: Add lastmod support to sitemapindex
----------------------------------+---------------------------------------
Reporter: Matthew Downey | Owner: David Smith
Type: New feature | Status: assigned
Component: contrib.sitemaps | Version: dev
Severity: Normal | Resolution:
Keywords: sitemap lastmod | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0
----------------------------------+---------------------------------------
Changes (by David Smith):

* needs_better_patch: 1 => 0


--
Ticket URL: <https://code.djangoproject.com/ticket/25916#comment:12>

Django

unread,
Oct 21, 2021, 9:28:30 AM10/21/21
to django-...@googlegroups.com
#25916: Add lastmod support to sitemapindex
-------------------------------------+-------------------------------------

Reporter: Matthew Downey | Owner: David
| Smith
Type: New feature | Status: assigned
Component: contrib.sitemaps | Version: dev
Severity: Normal | Resolution:
Keywords: sitemap lastmod | Triage Stage: Ready for
| checkin

Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Carlton Gibson):

* stage: Accepted => Ready for checkin


--
Ticket URL: <https://code.djangoproject.com/ticket/25916#comment:13>

Django

unread,
Oct 21, 2021, 10:08:43 AM10/21/21
to django-...@googlegroups.com
#25916: Add lastmod support to sitemapindex
-------------------------------------+-------------------------------------
Reporter: Matthew Downey | Owner: David
| Smith
Type: New feature | Status: closed
Component: contrib.sitemaps | Version: dev
Severity: Normal | Resolution: fixed

Keywords: sitemap lastmod | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Carlton Gibson <carlton.gibson@…>):

* status: assigned => closed
* resolution: => fixed


Comment:

In [changeset:"480191244d12fefbf95854b2b117c71ffe44749a" 4801912]:
{{{
#!CommitTicketReference repository=""
revision="480191244d12fefbf95854b2b117c71ffe44749a"
Fixed #25916 -- Added lastmod support to sitemap index view.

Co-authored-by: Matthew Downey <matthew...@webit.com.au>
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/25916#comment:15>

Django

unread,
Oct 21, 2021, 10:08:45 AM10/21/21
to django-...@googlegroups.com
#25916: Add lastmod support to sitemapindex
-------------------------------------+-------------------------------------
Reporter: Matthew Downey | Owner: David
| Smith
Type: New feature | Status: assigned

Component: contrib.sitemaps | Version: dev
Severity: Normal | Resolution:
Keywords: sitemap lastmod | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Carlton Gibson <carlton.gibson@…>):

In [changeset:"2ce03a2bac9f41b803196a45dcd07cc342838e58" 2ce03a2]:
{{{
#!CommitTicketReference repository=""
revision="2ce03a2bac9f41b803196a45dcd07cc342838e58"
Refs #25916 -- Isolated sitemap.test_utils tests
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/25916#comment:14>

Django

unread,
Jan 17, 2023, 5:49:43 AM1/17/23
to django-...@googlegroups.com
#25916: Add lastmod support to sitemapindex
-------------------------------------+-------------------------------------
Reporter: Matthew Downey | Owner: David
| Smith
Type: New feature | Status: closed
Component: contrib.sitemaps | Version: dev
Severity: Normal | Resolution: fixed

Keywords: sitemap lastmod | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Mariusz Felisiak <felisiak.mariusz@…>):

In [changeset:"daf88e778bd39d908dca9efc3571d37adbd2ff4a" daf88e77]:
{{{
#!CommitTicketReference repository=""
revision="daf88e778bd39d908dca9efc3571d37adbd2ff4a"
Refs #25916 -- Removed SitemapIndexItem.__str__() per deprecation
timeline.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/25916#comment:16>

Reply all
Reply to author
Forward
0 new messages