[Django] #30555: Migration files generated do not follow PEP8 E501 rule
Django
----------------------------------------+------------------------
Reporter: algomaster99 | Owner: nobody
Type: Bug | Status: new
Component: Migrations | Version: 2.2
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
----------------------------------------+------------------------
Migration files, which are automatically created by Django on running
`python manage.py makemigrations`, do not seem to follow PEP8 guidelines
completely. The rule **E501 line too long** is not respected in the file.
I have attached a file to support my arguments.
--
Ticket URL: <https://code.djangoproject.com/ticket/30555>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
Reporter: algomaster99 | Owner: nobody
Type: Bug | Status: new
Component: Migrations | Version: 2.2
Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by algomaster99):
* Attachment "Screenshot from 2019-06-08 11-40-35.png" added.
PEP8 throwing warnings when ran on `migrations` directory
Django
Reporter: algomaster99 | Owner: nobody
Type: Bug | Status: closed
Component: Migrations | Version: 2.2
Severity: Normal | Resolution: wontfix
Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Carlton Gibson):
* status: new => closed
* resolution: => wontfix
Comment:
This isn’t something worth addressing. I suggest you add `migrations`
folders to the [https://flake8.pycqa.org/en/latest/user/options.html
#cmdoption-flake8-exclude flake8 exclude] list.
--
Ticket URL: <https://code.djangoproject.com/ticket/30555#comment:1>
Django
Reporter: Aman Sharma | Owner: nobody
Type: Bug | Status: closed
Component: Migrations | Version: 2.2
Severity: Normal | Resolution: wontfix
Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Comment (by Adam (Chainz) Johnson):
...or run Black on your codebase, like Django will :)
--
Ticket URL: <https://code.djangoproject.com/ticket/30555#comment:2>
Django
Reporter: Aman Sharma | Owner: nobody
Type: Bug | Status: closed
Component: Migrations | Version: 2.2
Severity: Normal | Resolution: wontfix
Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Comment (by Jarek Glowacki):
Ooh really?
It's a little inconsistent currently, with how the `dependencies` list
(from makemigrations) gets nicely newlined, whereas the `replaces` list
(from squashmigrations) doesn't.
This has been a little pet peeve of mine for yonks, where `replaces` lists
are difficult to interact with when doing manual migration tinkering, but
I never got round to raising a ticket for it..
Despite this being closed as a wontfix, would a PR still be accepted if
one were submitted? :D
--
Ticket URL: <https://code.djangoproject.com/ticket/30555#comment:3>
Django
Reporter: Aman Sharma | Owner: nobody
Type: Bug | Status: closed
Component: Migrations | Version: 2.2
Severity: Normal | Resolution: wontfix
Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Comment (by felixxm):
No, if a ticket is `wontfix` then we will close PR.
--
Ticket URL: <https://code.djangoproject.com/ticket/30555#comment:4>