[Django] #11796: Change Permission ordering to sort by application, model, then permission

0 views
Skip to first unread message

Django

unread,
Aug 28, 2009, 1:39:49 PM8/28/09
to djang...@holovaty.com, django-...@googlegroups.com
#11796: Change Permission ordering to sort by application, model, then permission
---------------------------------+------------------------------------------
Reporter: russryba | Owner: nobody
Status: new | Milestone:
Component: Authentication | Version: 1.0
Keywords: Permission ordering | Stage: Unreviewed
Has_patch: 1 |
---------------------------------+------------------------------------------
Using Django 1.0.2 final.

Problem:
Permissions are automatically sorted by application name, then by the
permission, then by the model. This makes setting up permissions look
like this:


{{{
polls | choice | Can add choice
polls | poll | Can add poll
polls | choice | Can change choice
polls | poll | Can change poll
polls | choice | Can delete choice
polls | poll | Can delete poll
}}}



Instead I would like it to be


{{{
polls | choice | Can add choice
polls | choice | Can change choice
polls | choice | Can delete choice
polls | poll | Can add poll
polls | poll | Can change poll
polls | poll | Can delete poll
}}}



I found this is how the system used to work according to tickets #7115 and
#8246. I don't think 8246 is correct. This should be a one line change
to '''django/contrib/auth/models.py''' as follows to sort by application,
then model, then permission.


{{{
# pre 7115 ordering = ('content_type', 'codename')
# post 8246 ordering = ('content_type__app_label', 'codename')
ordering = ('content_type__app_label', 'content_type', 'codename')
}}}

--
Ticket URL: <http://code.djangoproject.com/ticket/11796>
Django <http://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Aug 28, 2009, 1:49:16 PM8/28/09
to djang...@holovaty.com, django-...@googlegroups.com
#11796: Change Permission ordering to sort by application, model, then permission
-------------------------------------+--------------------------------------
Reporter: russryba | Owner: nobody
Status: new | Milestone:
Component: Authentication | Version: 1.0
Resolution: | Keywords: Permission ordering
Stage: Unreviewed | Has_patch: 1
Needs_docs: 0 | Needs_tests: 0
Needs_better_patch: 0 |
-------------------------------------+--------------------------------------
Changes (by russryba):

* needs_better_patch: => 0
* needs_tests: => 0
* needs_docs: => 0

Comment:

The diff file was generated using command line diff instead of svn diff. I
just noticed it wasn't formatting correctly using the diff viewer and that
is why. Sounds silly for a single line change.

--
Ticket URL: <http://code.djangoproject.com/ticket/11796#comment:1>

Django

unread,
Jan 12, 2010, 5:35:12 PM1/12/10
to djang...@holovaty.com, django-...@googlegroups.com
#11796: Change Permission ordering to sort by application, model, then permission
-------------------------------------+--------------------------------------
Reporter: russryba | Owner: jezdez
Status: assigned | Milestone:
Component: Authentication | Version: SVN
Resolution: | Keywords: Permission ordering
Stage: Accepted | Has_patch: 1
Needs_docs: 0 | Needs_tests: 0
Needs_better_patch: 0 |
-------------------------------------+--------------------------------------
Changes (by jezdez):

* owner: nobody => jezdez
* status: new => assigned
* version: 1.0 => SVN
* stage: Unreviewed => Accepted

--
Ticket URL: <http://code.djangoproject.com/ticket/11796#comment:2>
Reply all
Reply to author
Forward
0 new messages