Re: [Django] #14483: Implement subqueries in geodjango spatial lookup
Django
-------------------------------------+------------------------------------
Reporter: milosu | Owner: nobody
Type: New feature | Status: new
Component: GIS | Version: 1.2
Severity: Normal | Resolution:
Keywords: geodjango, subquery | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+------------------------------------
Changes (by aaugustin):
* stage: Design decision needed => Accepted
Comment:
No GeoDjango expert made the call, and it still seems reasonable.
--
Ticket URL: <https://code.djangoproject.com/ticket/14483#comment:5>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
-------------------------------------+------------------------------------
Reporter: milosu | Owner: nobody
Type: New feature | Status: new
Component: GIS | Version: 1.2
Severity: Normal | Resolution:
Keywords: geodjango, subquery | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+------------------------------------
* needs_better_patch: 0 => 1
Comment:
Patch will need to be updated to apply cleanly.
--
Ticket URL: <https://code.djangoproject.com/ticket/14483#comment:6>
Django
-------------------------------------+------------------------------------
Reporter: milosu | Owner: nobody
Type: New feature | Status: new
Component: GIS | Version: 1.2
Severity: Normal | Resolution:
Keywords: geodjango, subquery | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------------+------------------------------------
Comment (by claudep):
I have a branch where this is working with PostGIS.
https://github.com/claudep/django/commit/53783c93a551fe769d5395e6ee54d01729b23722
However, it still fails on MySQL and Spatialite because of the
`ops.select` format (AsText()) which is applied to the subquery select. I
don't know if there is a mean to prevent that special formatting for
subqueries. ORM master needed :-)
--
Ticket URL: <https://code.djangoproject.com/ticket/14483#comment:7>
Django
-------------------------------------+------------------------------------
Reporter: milosu | Owner: nobody
Type: New feature | Status: new
Component: GIS | Version: 1.2
Severity: Normal | Resolution:
Keywords: geodjango, subquery | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+------------------------------------
* needs_better_patch: 1 => 0
Comment:
#24164 resolution (thanks Tim!) allows now the current PR to pass on
MySQL/Spatialite also.
--
Ticket URL: <https://code.djangoproject.com/ticket/14483#comment:8>
Django
Reporter: milosu | Owner: nobody
Type: New feature | Status: new
Component: GIS | Version: 1.2
Severity: Normal | Resolution:
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by timgraham):
* stage: Accepted => Ready for checkin
--
Ticket URL: <https://code.djangoproject.com/ticket/14483#comment:9>
Django
-------------------------------------+-------------------------------------
Reporter: milosu | Owner: nobody
Component: GIS | Version: 1.2
Severity: Normal | Resolution: fixed
Keywords: geodjango, subquery | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* status: new => closed
* resolution: => fixed
Comment:
In [changeset:"a0b5f15ea5f1abd91da9a5e4e5b6a0fb5a880c43"]:
{{{
#!CommitTicketReference repository=""
revision="a0b5f15ea5f1abd91da9a5e4e5b6a0fb5a880c43"
Fixed #14483 -- Allowed using subqueries with GIS lookups
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/14483#comment:10>
Django
-------------------------------------+-------------------------------------
Reporter: milosu | Owner: nobody
Type: New feature | Status: closed
Component: GIS | Version: 1.2
Severity: Normal | Resolution: fixed
Keywords: geodjango, subquery | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Claude Paroz <claude@…>):
In [changeset:"c77dd64402e64e3e53b49634175f1e010a480b67"]:
{{{
#!CommitTicketReference repository=""
revision="c77dd64402e64e3e53b49634175f1e010a480b67"
[1.8.x] Fixed #14483 -- Allowed using subqueries with GIS lookups
Backport of a0b5f15ea5f from master.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/14483#comment:11>