Re: [Django] #33805: SelectMultiple in ModelAdminForm display help text when allow_multiple_selected is False.

22 views
Skip to first unread message

Django

unread,
Jun 24, 2022, 5:30:55 AM6/24/22
to django-...@googlegroups.com
#33805: SelectMultiple in ModelAdminForm display help text when
allow_multiple_selected is False.
-------------------------------------+-------------------------------------
Reporter: Maxim Danilov | Owner: nobody
Type: | Status: new
Cleanup/optimization |
Component: contrib.admin | Version: 4.1
Severity: Normal | Resolution:
Keywords: modeladmin, | Triage Stage: Accepted
AdminForm |
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Maxim Danilov):

>> As far as I understand correctly, you have a subclass of SelectMultiple
with allow_multiple_selected set to False.
Exactly.

--
Ticket URL: <https://code.djangoproject.com/ticket/33805#comment:2>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Jun 25, 2022, 9:20:21 AM6/25/22
to django-...@googlegroups.com
#33805: SelectMultiple in ModelAdminForm display help text when
allow_multiple_selected is False.
-------------------------------------+-------------------------------------
Reporter: Maxim Danilov | Owner: Ankur Roy
Type: | Status: assigned

Cleanup/optimization |
Component: contrib.admin | Version: 4.1
Severity: Normal | Resolution:
Keywords: modeladmin, | Triage Stage: Accepted
AdminForm |
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Ankur Roy):

* owner: nobody => Ankur Roy
* status: new => assigned


--
Ticket URL: <https://code.djangoproject.com/ticket/33805#comment:3>

Django

unread,
Jun 26, 2022, 11:55:18 PM6/26/22
to django-...@googlegroups.com
#33805: SelectMultiple in ModelAdminForm display help text when
allow_multiple_selected is False.
-------------------------------------+-------------------------------------
Reporter: Maxim Danilov | Owner: Ankur Roy
Type: | Status: assigned
Cleanup/optimization |
Component: contrib.admin | Version: 4.1
Severity: Normal | Resolution:
Keywords: modeladmin, | Triage Stage: Accepted
AdminForm |
Has patch: 1 | Needs documentation: 0
Needs tests: 1 | Patch needs improvement: 1

Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak):

* needs_better_patch: 0 => 1
* has_patch: 0 => 1
* needs_tests: 0 => 1


Comment:

[https://github.com/django/django/pull/15799 PR]

--
Ticket URL: <https://code.djangoproject.com/ticket/33805#comment:4>

Django

unread,
Jun 28, 2022, 12:12:20 AM6/28/22
to django-...@googlegroups.com
#33805: SelectMultiple in ModelAdminForm display help text when
allow_multiple_selected is False.
-------------------------------------+-------------------------------------
Reporter: Maxim Danilov | Owner: Ankur Roy
Type: | Status: assigned
Cleanup/optimization |
Component: contrib.admin | Version: 4.1
Severity: Normal | Resolution:
Keywords: modeladmin, | Triage Stage: Ready for
AdminForm | checkin

Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak):

* needs_better_patch: 1 => 0
* needs_tests: 1 => 0
* stage: Accepted => Ready for checkin


--
Ticket URL: <https://code.djangoproject.com/ticket/33805#comment:5>

Django

unread,
Jun 28, 2022, 1:25:58 AM6/28/22
to django-...@googlegroups.com
#33805: SelectMultiple in ModelAdminForm display help text when
allow_multiple_selected is False.
-------------------------------------+-------------------------------------
Reporter: Maxim Danilov | Owner: Ankur Roy
Type: | Status: closed

Cleanup/optimization |
Component: contrib.admin | Version: 4.1
Severity: Normal | Resolution: fixed

Keywords: modeladmin, | Triage Stage: Ready for
AdminForm | checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak <felisiak.mariusz@…>):

* status: assigned => closed
* resolution: => fixed


Comment:

In [changeset:"eb7b8f3699fbe5ad6aaafb264355741648fdd5e4" eb7b8f3]:
{{{
#!CommitTicketReference repository=""
revision="eb7b8f3699fbe5ad6aaafb264355741648fdd5e4"
Fixed #33805 -- Made admin's many-to-many widgets do not display help text
for selecting values when allow_multiple_selected is False.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/33805#comment:6>

Reply all
Reply to author
Forward
0 new messages