[Django] #35661: `test_too_many_digits_to_render` test fails with PyPy3.10 7.3.16

18 views
Skip to first unread message

Django

unread,
Aug 7, 2024, 9:43:36 AM8/7/24
to django-...@googlegroups.com
#35661: `test_too_many_digits_to_render` test fails with PyPy3.10 7.3.16
------------------------------+-----------------------------------------
Reporter: Michał Górny | Type: Bug
Status: new | Component: Uncategorized
Version: 5.0 | Severity: Normal
Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
------------------------------+-----------------------------------------
When running the test suite in 5.0.8 (also reproduced via `tox -e pypy3`
on a05187fce613a70a5e5c93c978d36497a10fcf1f):

{{{
======================================================================
ERROR: test_too_many_digits_to_render
(template_tests.filter_tests.test_floatformat.FunctionTests) [<object
object at 0x000055ed663acdd8>]
(value='10000000000000000000000000000[...]0000000')
----------------------------------------------------------------------
Traceback (most recent call last):
File "/usr/lib/pypy3.10/unittest/case.py", line 59, in testPartExecutor
yield
File "/usr/lib/pypy3.10/unittest/case.py", line 498, in subTest
yield
File "/tmp/portage/dev-
python/django-5.0.8/work/Django-5.0.8/tests/template_tests/filter_tests/test_floatformat.py",
line 153, in tes
t_too_many_digits_to_render
self.assertEqual(floatformat(value), value)
File "/tmp/portage/dev-
python/django-5.0.8/work/Django-5.0.8/django/template/defaultfilters.py",
line 156, in floatformat
d = Decimal(input_val)
File "/usr/lib/pypy3.10/_pydecimal.py", line 566, in __new__
self._int = str(int(intpart+fracpart))
ValueError: Exceeds the limit (4300) for integer string conversion: value
has 1000001 digits

----------------------------------------------------------------------
Ran 16827 tests in 541.813s

FAILED (errors=1, skipped=1300, expected failures=5)
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/35661>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Aug 7, 2024, 5:00:49 PM8/7/24
to django-...@googlegroups.com
#35661: `test_too_many_digits_to_render` test fails with PyPy3.10 7.3.16
---------------------------------+------------------------------------
Reporter: Michał Górny | Owner: (none)
Type: Bug | Status: new
Component: Template system | Version: 5.0
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
---------------------------------+------------------------------------
Changes (by Natalia Bidart):

* cc: Sarah Boyce (added)
* component: Uncategorized => Template system
* stage: Unreviewed => Accepted

Comment:

Hello Michał Górny, thank you for this report.

Confirmed this is failing for PyPy in our scheduled tests actions
([https://github.com/django/django/actions/runs/10277279955/job/28439069262
PyPy+SQLite] and
[https://github.com/django/django/actions/runs/10277279955/job/28439068581
PyPy+Postgresql]).

Issue introduced in c19465ad87e33b6122c886b97a202ad54cd43672.
--
Ticket URL: <https://code.djangoproject.com/ticket/35661#comment:1>

Django

unread,
Aug 8, 2024, 2:19:25 AM8/8/24
to django-...@googlegroups.com
#35661: `test_too_many_digits_to_render` test fails with PyPy3.10 7.3.16
-------------------------------------+-------------------------------------
Reporter: Michał Górny | Owner: Mariusz
| Felisiak
Type: Bug | Status: assigned
Component: Template system | Version: 5.0
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak):

* has_patch: 0 => 1
* owner: (none) => Mariusz Felisiak
* status: new => assigned

Comment:

[https://github.com/django/django/pull/18460 PR]
--
Ticket URL: <https://code.djangoproject.com/ticket/35661#comment:2>

Django

unread,
Aug 8, 2024, 3:38:41 AM8/8/24
to django-...@googlegroups.com
#35661: `test_too_many_digits_to_render` test fails with PyPy3.10 7.3.16
-------------------------------------+-------------------------------------
Reporter: Michał Górny | Owner: Mariusz
| Felisiak
Type: Bug | Status: assigned
Component: Template system | Version: 5.0
Severity: Normal | Resolution:
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Sarah Boyce):

* stage: Accepted => Ready for checkin

--
Ticket URL: <https://code.djangoproject.com/ticket/35661#comment:3>

Django

unread,
Aug 8, 2024, 3:53:14 AM8/8/24
to django-...@googlegroups.com
#35661: `test_too_many_digits_to_render` test fails with PyPy3.10 7.3.16
-------------------------------------+-------------------------------------
Reporter: Michał Górny | Owner: Mariusz
| Felisiak
Type: Bug | Status: closed
Component: Template system | Version: 5.0
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Sarah Boyce <42296566+sarahboyce@…>):

* resolution: => fixed
* status: assigned => closed

Comment:

In [changeset:"7fb15ad5bcae05324ee8913e4b2c6c982e8f2de0" 7fb15ad5]:
{{{#!CommitTicketReference repository=""
revision="7fb15ad5bcae05324ee8913e4b2c6c982e8f2de0"
Fixed #35661 -- Fixed test_too_many_digits_to_rander() test crash on PyPy.

Thanks Michał Górny for the report.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/35661#comment:4>

Django

unread,
Aug 8, 2024, 3:55:55 AM8/8/24
to django-...@googlegroups.com
#35661: `test_too_many_digits_to_render` test fails with PyPy3.10 7.3.16
-------------------------------------+-------------------------------------
Reporter: Michał Górny | Owner: Mariusz
| Felisiak
Type: Bug | Status: closed
Component: Template system | Version: 5.0
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Sarah Boyce <42296566+sarahboyce@…>):

In [changeset:"d9aeb23edb6cc861360ffbb59a45beccafe55dcb" d9aeb23e]:
{{{#!CommitTicketReference repository=""
revision="d9aeb23edb6cc861360ffbb59a45beccafe55dcb"
[5.1.x] Fixed #35661 -- Fixed test_too_many_digits_to_rander() test crash
on PyPy.

Thanks Michał Górny for the report.

Backport of 7fb15ad5bcae05324ee8913e4b2c6c982e8f2de0 from main.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/35661#comment:5>
Reply all
Reply to author
Forward
0 new messages