[Django] #28890: Broken layout due to whitespace in multiwidget rendering

10 views
Skip to first unread message

Django

unread,
Dec 5, 2017, 9:41:41 AM12/5/17
to django-...@googlegroups.com
#28890: Broken layout due to whitespace in multiwidget rendering
-------------------------------------+-------------------------------------
Reporter: Nick Pope | Owner: Nick Pope
Type: Bug | Status: assigned
Component: Forms | Version: 1.11
Severity: Normal | Keywords: whitespace,
Triage Stage: | multiwidget, widgets
Unreviewed | Has patch: 1
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
-------------------------------------+-------------------------------------
Since upgrading to 1.11, due to the addition of template-based widget
rendering in #15667, I've experienced some form layouts breaking.

This is due to the way that white-space is handled in the templates which
was previously not an issue when strings were being joined in
{{{MultiWidget.format_output()}}}.

This may well affect more than {{{MultiWidget}}}.

See the attached screenshot - top is how things looked before, bottom is
how things look after upgrading to 1.11.

--
Ticket URL: <https://code.djangoproject.com/ticket/28890>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Dec 5, 2017, 9:42:02 AM12/5/17
to django-...@googlegroups.com
#28890: Broken layout due to whitespace in multiwidget rendering
-------------------------------------+-------------------------------------
Reporter: Nick Pope | Owner: Nick Pope
Type: Bug | Status: assigned
Component: Forms | Version: 1.11
Severity: Normal | Resolution:

Keywords: whitespace, | Triage Stage:
multiwidget, widgets | Unreviewed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Nick Pope):

* Attachment "multiwidget-spacing-bug.png" added.

Django

unread,
Dec 5, 2017, 10:59:55 AM12/5/17
to django-...@googlegroups.com
#28890: Broken layout due to whitespace in multiwidget rendering
-------------------------------------+-------------------------------------
Reporter: Nick Pope | Owner: Nick Pope
Type: Bug | Status: assigned
Component: Forms | Version: 1.11
Severity: Normal | Resolution:
Keywords: whitespace, | Triage Stage: Accepted
multiwidget, widgets |

Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Claude Paroz):

* stage: Unreviewed => Accepted


--
Ticket URL: <https://code.djangoproject.com/ticket/28890#comment:1>

Django

unread,
Dec 5, 2017, 11:56:47 AM12/5/17
to django-...@googlegroups.com
#28890: Broken layout due to whitespace in multiwidget rendering
-------------------------------------+-------------------------------------
Reporter: Nick Pope | Owner: Nick Pope
Type: Bug | Status: closed
Component: Forms | Version: 1.11
Severity: Normal | Resolution: fixed

Keywords: whitespace, | Triage Stage: Accepted
multiwidget, widgets |
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Tim Graham <timograham@…>):

* status: assigned => closed
* resolution: => fixed


Comment:

In [changeset:"e014f91a70aa3ccdddb363a733c76e35597424fa" e014f91]:
{{{
#!CommitTicketReference repository=""
revision="e014f91a70aa3ccdddb363a733c76e35597424fa"
Fixed #28890 -- Removed newlines between MultiWidget's subwidgets.

Regression in b52c73008a9d67e9ddbb841872dc15cdd3d6ee01.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/28890#comment:2>

Django

unread,
Dec 5, 2017, 12:01:26 PM12/5/17
to django-...@googlegroups.com
#28890: Broken layout due to whitespace in multiwidget rendering
-------------------------------------+-------------------------------------
Reporter: Nick Pope | Owner: Nick Pope
Type: Bug | Status: closed
Component: Forms | Version: 1.11

Severity: Normal | Resolution: fixed
Keywords: whitespace, | Triage Stage: Accepted
multiwidget, widgets |
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Tim Graham <timograham@…>):

In [changeset:"c1d57615ac60171a73e1922a48ebc27fe513357e" c1d57615]:
{{{
#!CommitTicketReference repository=""
revision="c1d57615ac60171a73e1922a48ebc27fe513357e"
[2.0.x] Fixed #28890 -- Removed newlines between MultiWidget's subwidgets.

Regression in b52c73008a9d67e9ddbb841872dc15cdd3d6ee01.

Backport of e014f91a70aa3ccdddb363a733c76e35597424fa from master
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/28890#comment:3>

Django

unread,
Dec 5, 2017, 12:01:35 PM12/5/17
to django-...@googlegroups.com
#28890: Broken layout due to whitespace in multiwidget rendering
-------------------------------------+-------------------------------------
Reporter: Nick Pope | Owner: Nick Pope
Type: Bug | Status: closed
Component: Forms | Version: 1.11

Severity: Normal | Resolution: fixed
Keywords: whitespace, | Triage Stage: Accepted
multiwidget, widgets |
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Tim Graham <timograham@…>):

In [changeset:"47681af34447e5d45f3fdb316497cdf9fbd0b7ce" 47681af3]:
{{{
#!CommitTicketReference repository=""
revision="47681af34447e5d45f3fdb316497cdf9fbd0b7ce"
[1.11.x] Fixed #28890 -- Removed newlines between MultiWidget's
subwidgets.

Regression in b52c73008a9d67e9ddbb841872dc15cdd3d6ee01.

Backport of e014f91a70aa3ccdddb363a733c76e35597424fa from master
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/28890#comment:4>

Reply all
Reply to author
Forward
0 new messages