[Django] #26051: Rename ATOMIC_REQUESTS to ATOMIC_VIEWS

7 views
Skip to first unread message

Django

unread,
Jan 7, 2016, 5:06:18 AM1/7/16
to django-...@googlegroups.com
#26051: Rename ATOMIC_REQUESTS to ATOMIC_VIEWS
--------------------------------------+--------------------
Reporter: srkunze | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: HTTP handling | Version: master
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Easy pickings: 0 | UI/UX: 0
--------------------------------------+--------------------
Internal discussion within our company revealed that the common
misunderstanding results from a slightly wrong name of the config
parameter: {{{ ATOMIC_REQUESTS }}}

We found that {{{ ATOMIC_VIEWS }}} would be better.

Also related: https://code.djangoproject.com/ticket/26043

--
Ticket URL: <https://code.djangoproject.com/ticket/26051>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Jan 7, 2016, 6:34:51 AM1/7/16
to django-...@googlegroups.com
#26051: Rename ATOMIC_REQUESTS to ATOMIC_VIEWS
-------------------------------------+-------------------------------------
Reporter: srkunze | Owner: nobody
Type: | Status: new
Cleanup/optimization |

Component: HTTP handling | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage:
| Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by aaugustin):

* needs_better_patch: => 0
* needs_tests: => 0
* needs_docs: => 0


Comment:

That makes sense. However I'm not convinced the slight improvement in
naming correctness is worth the backwards incompatibility.

There's a proposal for a new middleware schema floating around. Perhaps it
will allow implementating a safe `TransactionMiddleware` again. I'd rather
wait for this to happen.

I'm leaving the ticket open to get other opinions.

--
Ticket URL: <https://code.djangoproject.com/ticket/26051#comment:1>

Django

unread,
Jan 7, 2016, 12:21:16 PM1/7/16
to django-...@googlegroups.com
#26051: Rename ATOMIC_REQUESTS to ATOMIC_VIEWS
-------------------------------------+-------------------------------------
Reporter: srkunze | Owner: nobody
Type: | Status: closed
Cleanup/optimization |

Component: HTTP handling | Version: master
Severity: Normal | Resolution: wontfix
Keywords: | Triage Stage:
| Unreviewed

Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by timgraham):

* status: new => closed
* resolution: => wontfix


Comment:

Agreed that if the new middleware proposal works out, that'll be better in
the long run. Here's the [https://github.com/django/django/pull/5591 draft
pull request].

--
Ticket URL: <https://code.djangoproject.com/ticket/26051#comment:2>

Django

unread,
Jan 28, 2016, 3:11:10 AM1/28/16
to django-...@googlegroups.com
#26051: Rename ATOMIC_REQUESTS to ATOMIC_VIEWS
-------------------------------------+-------------------------------------
Reporter: srkunze | Owner: nobody
Type: | Status: closed
Cleanup/optimization |

Component: HTTP handling | Version: master
Severity: Normal | Resolution: wontfix
Keywords: | Triage Stage:
| Unreviewed

Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by TZanke):

* cc: tzanke@… (added)


--
Ticket URL: <https://code.djangoproject.com/ticket/26051#comment:3>

Reply all
Reply to author
Forward
0 new messages