[Django] #25117: Update urlify.js with Romanian missing characters
Django
--------------------------------------+--------------------
Reporter: ionescu77 | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: contrib.admin | Version: 1.8
Severity: Normal | Keywords: admin
Triage Stage: Unreviewed | Has patch: 0
Easy pickings: 0 | UI/UX: 0
--------------------------------------+--------------------
Hi,
after some reading, I think my issue seems to be similar to #5044 (latvian
characters missing).
I have the same problem with romanian characters missing (slugify,
urlify):
- ă should be a
- î should be i
- ș should be s
- ț should be t
- â should be a
Right now the romanian characters get lost (for a slugfield when
prepopulating from another field in admin) .
I am using Django version 1.7.1 on my laptop but I have checked the latest
django branches on github and there is no ROMANIAN language entry in:
django/django/contrib/admin/static/admin/js/urlify.js
I will try to do a pull request (I am kind of new to github). I am
currently reading the how-to's on contributing/fixing.
--
Ticket URL: <https://code.djangoproject.com/ticket/25117>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
Reporter: ionescu77 | Owner: nobody
Type: | Status: new
Cleanup/optimization |
Component: contrib.admin | Version: 1.8
Severity: Normal | Resolution:
Keywords: admin | Triage Stage:
| Unreviewed
Needs tests: 1 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by ionescu77):
* needs_better_patch: => 0
* has_patch: 0 => 1
* needs_tests: => 1
* needs_docs: => 0
Comment:
Hi,
following instructions I created a branch for this ticket on github with
the added ROMANIAN_MAP:
[https://github.com/ionescu77/django/tree/ticket_25117]
I hope all is fine like this.
--
Ticket URL: <https://code.djangoproject.com/ticket/25117#comment:1>
Django
Reporter: ionescu77 | Owner: nobody
Type: | Status: new
Cleanup/optimization |
Component: contrib.admin | Version: 1.8
Severity: Normal | Resolution:
Keywords: admin | Triage Stage:
| Unreviewed
Easy pickings: 0 | UI/UX: 0
Comment (by ionescu77):
Github Pull request 4990
I have tested locally and it works. I do not know where to write/include
the unit tests.
Thx
--
Ticket URL: <https://code.djangoproject.com/ticket/25117#comment:2>
Django
Reporter: ionescu77 | Owner: nobody
Type: Bug | Status: new
Component: contrib.admin | Version: 1.8
Severity: Normal | Resolution:
Keywords: admin | Triage Stage: Unreviewed
Easy pickings: 0 | UI/UX: 0
Changes (by ionescu77):
* type: Cleanup/optimization => Bug
--
Ticket URL: <https://code.djangoproject.com/ticket/25117#comment:3>
Django
Reporter: ionescu77 | Owner: nobody
Type: Bug | Status: new
Component: contrib.admin | Version: master
Severity: Normal | Resolution:
Keywords: admin | Triage Stage: Unreviewed
Easy pickings: 0 | UI/UX: 0
Changes (by ionescu77):
* version: 1.8 => master
--
Ticket URL: <https://code.djangoproject.com/ticket/25117#comment:4>
Django
Reporter: ionescu77 | Owner: ionescu77
Type: Bug | Status: assigned
Component: contrib.admin | Version: master
Severity: Normal | Resolution:
Easy pickings: 0 | UI/UX: 0
Changes (by ionescu77):
* status: new => assigned
* owner: nobody => ionescu77
--
Ticket URL: <https://code.djangoproject.com/ticket/25117#comment:5>
Django
Reporter: ionescu77 | Owner: ionescu77
Component: contrib.admin | Version: master
Severity: Normal | Resolution: fixed
Keywords: admin | Triage Stage: Unreviewed
Easy pickings: 0 | UI/UX: 0
Changes (by ionescu77):
* status: assigned => closed
* resolution: => fixed
--
Ticket URL: <https://code.djangoproject.com/ticket/25117#comment:6>
Django
Reporter: ionescu77 | Owner: ionescu77
Type: Bug | Status: new
Component: contrib.admin | Version: master
Severity: Normal | Resolution:
| checkin
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Changes (by timgraham):
* status: closed => new
* resolution: fixed =>
* needs_tests: 1 => 0
* stage: Unreviewed => Ready for checkin
Comment:
Ticket isn't marked fixed until the patch is merged.
--
Ticket URL: <https://code.djangoproject.com/ticket/25117#comment:7>
Django
Reporter: ionescu77 | Owner: ionescu77
Component: contrib.admin | Version: master
Severity: Normal | Resolution: fixed
Keywords: admin | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Tim Graham <timograham@…>):
* status: new => closed
* resolution: => fixed
Comment:
In [changeset:"97bc875234c5578a16e9e89be2b3431153e7b413" 97bc8752]:
{{{
#!CommitTicketReference repository=""
revision="97bc875234c5578a16e9e89be2b3431153e7b413"
Fixed #25117 -- Added Romanian char map for Javascript slug generation
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/25117#comment:8>